From 23a984416f7405d8ac65174fb2a4a0d4f2225124 Mon Sep 17 00:00:00 2001 From: gouri-panda Date: Sun, 17 Dec 2023 23:18:33 +0530 Subject: [PATCH 1/2] Fixed #3613 --- contrib/instrumentation.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/instrumentation.sh b/contrib/instrumentation.sh index b8ac5841d..70ff8fd64 100644 --- a/contrib/instrumentation.sh +++ b/contrib/instrumentation.sh @@ -15,7 +15,7 @@ do adb logcat ./*:E -v color & ./gradlew clean retry=$(( $retry + 1 )) - if [ $retry == 3 ]; then + if [ $retry -eq 3 ]; then adb exec-out screencap -p >screencap.png exit 1 fi From bdbfe2f3d17d6dd34d709d262f4cf0775ae55d7f Mon Sep 17 00:00:00 2001 From: MohitMaliFtechiz Date: Mon, 18 Dec 2023 16:56:53 +0530 Subject: [PATCH 2/2] Fixed: `$/${} is unnecessary on arithmetic variables` error while incrementing the count of retry variable. Since In Bash arithmetic expansion, the `$` is not needed when referencing variables see https://www.shellcheck.net/wiki/SC2004 for more details. --- contrib/instrumentation.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/instrumentation.sh b/contrib/instrumentation.sh index 70ff8fd64..6ab3998c5 100644 --- a/contrib/instrumentation.sh +++ b/contrib/instrumentation.sh @@ -14,7 +14,7 @@ do adb logcat -c adb logcat ./*:E -v color & ./gradlew clean - retry=$(( $retry + 1 )) + retry=$(( retry + 1 )) if [ $retry -eq 3 ]; then adb exec-out screencap -p >screencap.png exit 1