From f5f2b3477976e2e7ccae4fff3216af036ff1629d Mon Sep 17 00:00:00 2001 From: MohitMali Date: Fri, 2 Dec 2022 11:11:34 +0530 Subject: [PATCH] Improved code --- .../kiwix/kiwixmobile/core/data/local/dao/BookmarksDao.kt | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/core/src/main/java/org/kiwix/kiwixmobile/core/data/local/dao/BookmarksDao.kt b/core/src/main/java/org/kiwix/kiwixmobile/core/data/local/dao/BookmarksDao.kt index 34c7de0a6..278b7c0e2 100644 --- a/core/src/main/java/org/kiwix/kiwixmobile/core/data/local/dao/BookmarksDao.kt +++ b/core/src/main/java/org/kiwix/kiwixmobile/core/data/local/dao/BookmarksDao.kt @@ -58,13 +58,11 @@ class BookmarksDao @Inject constructor(private val kiwixDatabase: KiwixDatabase) Query.select(Bookmark.ROWID, Bookmark.BOOKMARK_URL) ) while (bookmarkCursor.moveToNext()) { - var url = bookmarkCursor.get(Bookmark.BOOKMARK_URL) - url = operation.apply(url) - if (url != null) { + operation.apply(bookmarkCursor.get(Bookmark.BOOKMARK_URL))?.let { bookmarkUrl -> kiwixDatabase.update( Update.table(Bookmark.TABLE) .where(Bookmark.ROWID.eq(bookmarkCursor.get(Bookmark.ROWID))) - .set(Bookmark.BOOKMARK_URL, url) + .set(Bookmark.BOOKMARK_URL, bookmarkUrl) ) } }