kiwix/kiwix-android
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-android.git synced 2025-09-09 07:16:04 -04:00
Code Issues Packages Projects Releases Wiki Activity

Update the disposabe and improve test methods

Browse Source
This commit is contained in:
Yash Khare 2020-04-17 20:08:10 +05:30
parent 9401b688bc
commit f837a45d21
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/org/kiwix/kiwixmobile/zim_manager/ZimManageViewModel.kt
View File

@ -110,7 +110,7 @@ class ZimManageViewModel @Inject constructor(
val requestFiltering = BehaviorProcessor.createDefault<String>("") val requestFiltering = BehaviorProcessor.createDefault<String>("")
val currentPage = PublishProcessor.create<Int>() val currentPage = PublishProcessor.create<Int>()
val libraryTabIsVisible = currentPage.filter { it == 1 } val libraryTabIsVisible = currentPage.map { it == 1 }.filter { it }
private val compositeDisposable = CompositeDisposable() private val compositeDisposable = CompositeDisposable()

2
app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/ZimFileSelectFragment.kt
View File

@ -115,7 +115,7 @@ class ZimFileSelectFragment : BaseFragment() {
disposable.add(zimManageViewModel.libraryTabIsVisible.subscribe { finishActionMode() }) disposable.add(zimManageViewModel.libraryTabIsVisible.subscribe { finishActionMode() })
} }
fun finishActionMode() { private fun finishActionMode() {
actionMode?.finish() actionMode?.finish()
} }

6
app/src/test/java/org/kiwix/kiwixmobile/zim_manager/ZimManageViewModelTest.kt
View File

@ -519,14 +519,14 @@ class ZimManageViewModelTest {
} }
@Test @Test
fun `finish actionMode on tab change to online section`() { fun `libraryTabIsVisible emits when currentPage is 1`() {
viewModel.libraryTabIsVisible.test() viewModel.libraryTabIsVisible.test()
.also { viewModel.currentPage.offer(1) } .also { viewModel.currentPage.offer(1) }
.assertValue(1) .assertValue(true)
} }
@Test @Test
fun `no change in actionMode`() { fun `libraryTabIsVisible does not emit when currentPage is 0`() {
viewModel.libraryTabIsVisible.test() viewModel.libraryTabIsVisible.test()
.also { viewModel.currentPage.offer(0) } .also { viewModel.currentPage.offer(0) }
.assertEmpty() .assertEmpty()