From fe459e6902c010c14a9fe6239dbf6860fdc66c0c Mon Sep 17 00:00:00 2001
From: Priyank Shankar <shankarpriyank312002@gmail.com>
Date: Sat, 7 Jan 2023 22:41:11 +0530
Subject: [PATCH] Remove Label From Dialog Box

---
 .../core/utils/dialog/AlertDialogShower.kt    | 15 ++++++++----
 .../core/utils/ExternalLinkOpenerTest.kt      | 24 ++++++++++++++++---
 2 files changed, 31 insertions(+), 8 deletions(-)

diff --git a/core/src/main/java/org/kiwix/kiwixmobile/core/utils/dialog/AlertDialogShower.kt b/core/src/main/java/org/kiwix/kiwixmobile/core/utils/dialog/AlertDialogShower.kt
index 16afb3d27..81bd73581 100644
--- a/core/src/main/java/org/kiwix/kiwixmobile/core/utils/dialog/AlertDialogShower.kt
+++ b/core/src/main/java/org/kiwix/kiwixmobile/core/utils/dialog/AlertDialogShower.kt
@@ -34,6 +34,11 @@ import javax.inject.Inject
 
 class AlertDialogShower @Inject constructor(private val activity: Activity) :
   DialogShower {
+  private val viewSpacingLeftForLink = 0
+  private val viewSpacingRightForLink = 0
+  private val viewSpacingTopForLink = 10
+  private val viewSpacingBottomForLink = 0
+
   override fun show(dialog: KiwixDialog, vararg clickListeners: () -> Unit, url: URL?) =
     create(dialog, *clickListeners, url = url).show()
 
@@ -77,14 +82,14 @@ class AlertDialogShower @Inject constructor(private val activity: Activity) :
               Toast.LENGTH_SHORT
             ).show()
           }
-          textView.text = Html.fromHtml(" <b>Link - <b></br><a href=$url> <b>$url</b>")
+          textView.text = Html.fromHtml("</br><a href=$url> <b>$url</b>")
 
           setView(
             textView,
-            0,
-            20,
-            0,
-            0
+            viewSpacingLeftForLink,
+            viewSpacingTopForLink,
+            viewSpacingRightForLink,
+            viewSpacingBottomForLink
           )
         }
         dialog.getView?.let { setView(it()) }
diff --git a/core/src/test/java/org/kiwix/kiwixmobile/core/utils/ExternalLinkOpenerTest.kt b/core/src/test/java/org/kiwix/kiwixmobile/core/utils/ExternalLinkOpenerTest.kt
index daef60f7d..78c1bfb2c 100644
--- a/core/src/test/java/org/kiwix/kiwixmobile/core/utils/ExternalLinkOpenerTest.kt
+++ b/core/src/test/java/org/kiwix/kiwixmobile/core/utils/ExternalLinkOpenerTest.kt
@@ -47,7 +47,13 @@ internal class ExternalLinkOpenerTest {
     val externalLinkOpener = ExternalLinkOpener(activity, sharedPreferenceUtil, alertDialogShower)
     externalLinkOpener.openExternalUrl(intent)
     verify {
-      alertDialogShower.show(KiwixDialog.ExternalLinkPopup, capture(lambdaSlot), any(), any())
+      alertDialogShower.show(
+        KiwixDialog.ExternalLinkPopup,
+        capture(lambdaSlot),
+        any(),
+        any(),
+        any()
+      )
     }
     lambdaSlot.captured.invoke()
     verify { activity.startActivity(intent) }
@@ -61,7 +67,13 @@ internal class ExternalLinkOpenerTest {
     val externalLinkOpener = ExternalLinkOpener(activity, sharedPreferenceUtil, alertDialogShower)
     externalLinkOpener.openExternalUrl(intent)
     verify {
-      alertDialogShower.show(KiwixDialog.ExternalLinkPopup, any(), capture(lambdaSlot), any())
+      alertDialogShower.show(
+        KiwixDialog.ExternalLinkPopup,
+        any(),
+        capture(lambdaSlot),
+        any(),
+        any()
+      )
     }
     lambdaSlot.captured.invoke()
     verify(exactly = 0) { activity.startActivity(intent) }
@@ -75,7 +87,13 @@ internal class ExternalLinkOpenerTest {
     val externalLinkOpener = ExternalLinkOpener(activity, sharedPreferenceUtil, alertDialogShower)
     externalLinkOpener.openExternalUrl(intent)
     verify {
-      alertDialogShower.show(KiwixDialog.ExternalLinkPopup, any(), any(), capture(lambdaSlot))
+      alertDialogShower.show(
+        KiwixDialog.ExternalLinkPopup,
+        any(),
+        any(),
+        capture(lambdaSlot),
+        any()
+      )
     }
     lambdaSlot.captured.invoke()
     verify {