8286 Commits

Author SHA1 Message Date
MohitMaliFtechiz
e391b407b2 Fixed the left margin on the placeholder to make it look nice on the phone. 2023-12-06 17:05:43 +05:30
MohitMaliFtechiz
bbcf8bea8c Added a placeholder for search in custom apps.
* Introduced a search placeholder for custom apps; if any custom app is configured not to show the title in the toolbar, it will display the search placeholder with a border. To implement this change, a layout has been added inside the toolbar.
* To enhance understanding of this change, proper comments have been added to the methods.
2023-12-06 16:00:35 +05:30
MohitMaliFtechiz
88475d8601 The app icon will no longer automatically be replaced with three lines after closing the tabs screen in custom apps when the custom app is configured not to show the title. 2023-12-06 16:00:28 +05:30
MohitMaliFtechiz
2c1c678819 Fixed code formatting issue. 2023-12-06 16:00:22 +05:30
MohitMaliFtechiz
cd7b988fe1 Adjusted the size of the hamburger icon. * To address unexpected behavior, where setting the icon directly to the hamburger resulted in it taking the full width and height of the toolbar, we resized the app icon and applied it to the hamburger icon. 2023-12-06 16:00:15 +05:30
MohitMaliFtechiz
f46f2f324b Introduced the disable title option for custom apps. 2023-12-06 16:00:07 +05:30
MohitMaliFtechiz
952b539fa8 Adjusted the zone for triggering search suggestions.
* We had restricted the toolbar click to the toolbar title. So, if the user clicked on the title, it would initiate the search. Now, we have removed the restriction of clicking only on the title. If the user taps anywhere on the toolbar except the menu items and hamburger, it will initiate the search.
2023-12-06 15:59:59 +05:30
gouri-panda
2a3d479509
Fixes a small bug in the apk dir variable 3.8.1 2023-12-03 16:05:47 +01:00
Kelson
f6d86fb7d9
Merge pull request #3567 from kiwix/develop
3.8.1 branch
2023-12-02 14:09:14 +01:00
Kelson
6a6706cf7b
Merge pull request #3537 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2023-12-01 21:05:41 +01:00
translatewiki.net
e2585529d2 Localisation updates from https://translatewiki.net. 2023-12-01 21:05:15 +01:00
Kelson
7028489bb3
Merge pull request #3561 from kiwix/update_changelog_of_3.8.1
Updated the CHANGELOG for milestone `3.8.1`.
2023-12-01 21:04:25 +01:00
MohitMaliFtechiz
dff852ca4e Updated the CHANGELOG for milestone 3.8.1 2023-12-01 21:04:11 +01:00
Kelson
6832acc831
Merge pull request #3562 from kiwix/update_kiwix_version_to_3.8.1
Updated kiwix version to 3.8.1
2023-12-01 21:03:43 +01:00
MohitMaliFtechiz
9d129d5a95 Updated kiwi version to 3.8.1 2023-12-01 21:03:28 +01:00
Kelson
c3e46bb6d9
Merge pull request #3558 from kiwix/Issue#3556
Fixed: Version 3.8.0 shuts down after searching for an entry.
2023-12-01 21:03:08 +01:00
MohitMaliFtechiz
c90c6312f4 Fixed unit test cases.
* Fixed: `Search action is debounced` test.
* Fixed: `SearchState combines sources from inputs` test.
2023-11-29 19:29:20 +05:30
MohitMaliFtechiz
c3da77b596 Added unit test cases to properly test the search functionalities scenario. 2023-11-29 18:48:40 +05:30
MohitMaliFtechiz
a1df0fedfe Implemented debouncing mechanism for the search functionality.
* Implemented a debouncing mechanism to enhance the handling of search functionalities. This approach is employed to prevent unnecessary data loads from libkiwix, addressing the issue of crashes when users rapidly type and search for results.
2023-11-29 14:56:55 +05:30
Kelson
acb90366d8
Merge pull request #3552 from kiwix/better-cd-release-event
Use GitHub 'release' event to trigger release
2023-11-25 11:44:13 +01:00
Emmanuel Engelhart
88f020ea80
Use GitHub 'release' event to trigger release 2023-11-25 10:26:18 +01:00
Kelson
edee77d57d
Merge pull request #3550 from kiwix/Issue#3549
Fixed: Numerous issues with links were reported by the Play Store.
2023-11-25 10:16:06 +01:00
MohitMaliFtechiz
04868ecfdd Fixed: Numerous issues with links were reported by the Play Store.
* The Play Store highlighted the need to add "/" to the beginning of the `android:pathPattern`. As a result, we have now included "/" at the beginning of all `android:pathPattern` instances to ensure compatibility with the Play Store.
* Additionally, the `android:autoVerify="true"` attribute has been added to intent filters to verify domain ownership. This was identified as an issue by both the Play Store and the App Links Assistant tool in Android Studio.
2023-11-25 10:14:53 +01:00
Kelson
4929c5aa24
Merge pull request #3546 from kiwix/develop
3.8.0 code patch
3.8.0
2023-11-22 19:41:18 +01:00
Kelson
0dac73c5fd
Merge pull request #3542 from kiwix/Issue#3541
Fixed, Bookmark toggle is not on when opening bookmarks for existing opened book.
2023-11-22 18:58:05 +01:00
MohitMaliFtechiz
68f811bd2c Fixed the issue by correctly setting up the bookmark disposable for the current ZIM file in custom apps when opening bookmarks for the currently opened book. 2023-11-22 11:32:18 +05:30
MohitMaliFtechiz
46b51bb710 Fixed, Bookmark toggle is not on when opening bookmarks for existing opened book.
* Fixed the issue by correctly setting up the bookmark disposable for the current ZIM file when opening bookmarks for the currently opened book.
2023-11-22 11:30:42 +05:30
Kelson
43e6ce6bee
Merge pull request #3544 from kiwix/Issue#3543
Fixed, Sidebar adds unwanted space after closing the full screen mode.
2023-11-22 06:43:19 +01:00
MohitMaliFtechiz
a9088c0918 Fixed, Sidebar adds unwanted space after closing the full screen mode.
* Previously, when exiting full-screen mode, the `WindowCompat.setDecorFitsSystemWindows` configuration was set to `false`, causing a blank space between the sidebar logo and the Bookmark item.
* This change sets the configuration to `true` when exiting full-screen mode to ensure proper adjustment of the sidebar content, eliminating the undesired blank space.
* The adjustment is necessary to maintain a seamless layout and appearance, particularly after transitioning from full-screen mode.
2023-11-21 21:24:19 +01:00
Kelson
d2ba06baeb
Merge pull request #3545 from kiwix/remove_unnecessary_keys_from_playstore.json 2023-11-21 19:41:29 +01:00
MohitMaliFtechiz
b52e844e75 Remove Content from playstore.json file.
* This file, typically associated with Firebase, is unnecessary for our project since we do not utilize Firebase.
* However, the file is essential for publishing the application on the Play Store. The credentials for publishing are stored in this file during the publish CI process.
* To avoid any confusion, it is better to remove the content of this file.
2023-11-21 19:45:10 +05:30
Kelson
527e27027c
Merge pull request #3540 from kiwix/move_version_from_both_gradles
Moved version-related properties from individual build.gradle files to a common configuration file (`Config.kt`).
2023-11-21 10:02:26 +01:00
MohitMaliFtechiz
52fefe7df7 Moved version-related properties from individual build.gradle files to a common configuration file (Config.kt).
* The `Config.kt` now holds the version information we can directly change the versionCode here and it will automatically replace in both gradle files.
* Removed duplicate version configurations from build.gradle files.
2023-11-21 12:44:37 +05:30
Kelson
72197c2bf8
Merge pull request #3533 from kiwix/Issue#3530
Fixed, Using TTS on Wikivoyage 2023-06 (Android 13) reads code aloud.
2023-11-20 20:58:31 +01:00
MohitMali
65c262e1aa Fixed the lines skip issue in read aloud feature.
* The issue was caused by an unnecessary increment of the 'currentPiece' index in the onDone callback of the TextToSpeech engine. This double increment led to the skipping of lines. The redundant increment at the end of the method has been removed, ensuring that each line is read correctly.
2023-11-20 18:39:28 +01:00
MohitMali
baf2429fa3 Fixed, Using TTS on Wikivoyage 2023-06 (Android 13) reads code aloud. 2023-11-20 18:39:28 +01:00
Kelson
3e03201fbb
Merge pull request #3538 from kiwix/bump-up-version-3.8.0
Bump-up version to 3.8.0
2023-11-20 16:34:45 +01:00
Emmanuel Engelhart
45c12e7272
Bump-up version to 3.8.0 2023-11-20 16:34:15 +01:00
Kelson
7c11c5ab96
Merge pull request #3534 from kiwix/update_changelog_3.8.0
Updated CHANGELOG file to show the changes made in the version `3.8.0`.
2023-11-20 16:19:54 +01:00
MohitMali
b5f6c54c82 Updated CHANGELOG file to show the changes made in the version 3.8.0. 2023-11-18 09:14:10 +01:00
Kelson
e6b76a5327
Merge pull request #3535 from kiwix/search_not_working_in_dwds_app
Fixed, the search is not working in dwds app.
2023-11-17 17:41:22 +01:00
MohitMali
c4f5b3f978 Fixed, the search is not working in dwds app.
* We now utilize `AssetFileDescriptor` to open the ZIM file for custom apps. For the search functionality, we are creating a reader with a file object, but we need to create a reader with the `AssetFileDescriptor` instead of a file for custom apps.
2023-11-17 21:01:50 +05:30
Kelson
252d846b64
Merge pull request #3512 from kiwix/Issue#3507
Fixed, Hitting back on the DWDS app exits it.
2023-11-16 21:35:43 +01:00
MohitMali
4a9682427f Added comments on CoreReaderFragment method that are implemented in CustomReaderFragment. 2023-11-16 19:10:34 +05:30
MohitMali
b75221959c Added comments to CustomReaderFragment to explain why we have overridden these methods and describe their functionality. 2023-11-16 19:10:26 +05:30
MohitMali
748f0c4d5f Moved openSearchItem, findInPage functionality to our CoreReaderFragment as we were using same code twice for these methods in app and custom module. 2023-11-16 19:10:02 +05:30
MohitMali
e0c4b453bd Removed unnecessary overriding of onBackPressed method. 2023-11-16 18:59:05 +05:30
MohitMali
132f376243 Fixed, Hitting back on the DWDS app exits it.
* We removed the activity finishing triggered by pressing the back button in the reader fragment. We initially added this when we were converting CustomReader to a fragment, as we encountered crashing issues at the time. However, it was quite some time ago, and we have since refactored our code. Now, it no longer crashes and functions smoothly without terminating the activity when the back button is pressed. We also made this change for when a user presses the back button from the download screen. This back button press is within the CustomReaderFragment, so it does not impact the functionality of the DownloadFragment.
2023-11-16 18:58:58 +05:30
Kelson
fdbfe3801b
Merge pull request #3527 from kiwix/Issue#1447
Fixed, I can't open Zim from an external download.
2023-11-16 13:58:05 +01:00
MohitMali
088f28d1d6 Fixed MimeTypeTest. 2023-11-16 18:16:35 +05:30