2766 Commits

Author SHA1 Message Date
Seán Mac Gillicuddy
0701c1aa7b
Merge pull request #1366 from kiwix/feature/macgills/#1359-delete-bookmark
#1359 Unable to remove Bookmark from bottom bar
2019-08-14 13:21:16 +01:00
Isaac Hutt
c3f7e6f0ad
Merge pull request #1365 from kiwix/julianharty/fix-issue-1364
Fix for a bug that affects custom apps missing their contents.
2019-08-14 14:14:22 +02:00
Seán Mac Gillicuddy
15ddc39b61
Merge pull request #1367 from kiwix/macgills/feature/#1319-lint-synthetic-accessor
#1319 update project inspection settings
2019-08-14 12:59:23 +01:00
Isaac Hutt
cb2e89a89f
Add details on building with kiwix-lib 2019-08-14 13:59:12 +02:00
Aditya-Sood
35a0bffb47 Remove extra code-style and inspection profile 2019-08-14 17:19:43 +05:30
julianharty
37d3f43c29 Applied changes suggested in https://github.com/kiwix/kiwix-android/pull/1365
Additional testing notes available in #1364
2019-08-14 12:41:20 +01:00
Sean Mac Gillicuddy
037ead23f8 #1319 update project inspection settings 2019-08-14 11:46:17 +01:00
Isaac Hutt
b35c1db449
Merge pull request #1348 from kiwix/feature/mhutti1/#1259-subfix
#1259 Allow a local kiwix-lib aar to be used
2019-08-14 12:38:06 +02:00
Sean Mac Gillicuddy
338c607ce6 #1359 Unable to remove Bookmark from bottom bar 2019-08-14 11:31:27 +01:00
Aditya-Sood
a1c5c6a1ed Minor restyle 2019-08-14 00:38:05 +05:30
Aditya-Sood
1f154259bb Code cleanup
Removed extra methods + refactor
2019-08-14 00:21:12 +05:30
Aditya-Sood
c856f1cd74 Refactor: Remove use of LFTA as Activity
Keeping with the I in SOLID, WDM now uses a plain Activity instead of LocalFileTransferActivity specifically
2019-08-13 22:50:47 +05:30
Aditya-Sood
e415bd862e Refactor: Remove extra variable filesSent & methods 2019-08-13 22:39:52 +05:30
Aditya-Sood
e0651dd88c Minor refactor 2019-08-13 22:23:28 +05:30
Aditya-Sood
f00abecbd1 Increment: LFTA restricted to 'Device' tab
The 'Get zim from nearby device' option now only shows in 'Device' tab of library
2019-08-13 22:04:39 +05:30
julianharty
cf7e392c85 Fix for a bug that affects custom apps missing their contents.
See https://github.com/kiwix/kiwix-android/issues/1364 for details.
2019-08-13 16:45:03 +01:00
Aditya-Sood
a17db838ff Reformat LocalFileTransfer sub-package 2019-08-13 21:00:24 +05:30
Aditya-Sood
bdf979d973 Fix gitignore issue
Wasn't ignoring some .idea files
2019-08-13 20:46:34 +05:30
Aditya-Sood
bec4b8e3c5 Fix lint errors
- Removed extra comment
- 'SyntheticAccessor' now marked as a warning
2019-08-13 20:29:11 +05:30
Seán Mac Gillicuddy
00c4440de9
Merge pull request #1363 from kiwix/macgills/feature/#1319-lint-synthetic-accessor
#1319 Lint Issue: SyntheticAccessor
2019-08-13 15:31:59 +01:00
Sean Mac Gillicuddy
8675e4b54d #1319 Lint Issue: SyntheticAccessor 2019-08-13 14:54:33 +01:00
Sean Mac Gillicuddy
b455c20165 Merge remote-tracking branch 'origin/develop' into feature/macgills/#1212-automated-test-architecture
# Conflicts:
#	app/src/main/java/org/kiwix/kiwixmobile/utils/files/FileUtils.kt
2019-08-13 14:35:24 +01:00
Seán Mac Gillicuddy
9905ab0d3a
Merge pull request #1362 from kiwix/feature/macgills/#1361-custom-app-contents
#1361 Custom app cannot find contents bug
2019-08-13 14:32:02 +01:00
Aditya-Sood
b1774304ad Merge branch 'develop' into feature/LocalFileTransfer 2019-08-13 18:09:28 +05:30
Sean Mac Gillicuddy
9349e29502 #1361 Custom app cannot find contents bug 2019-08-13 13:17:57 +01:00
Sean Mac Gillicuddy
4fee17d5ea #1212 share test model functions between unit/instrumentation tests 2019-08-13 13:13:50 +01:00
Sean Mac Gillicuddy
cec8e7e7a0 #1212 correct usage of MockServer 2019-08-13 12:31:27 +01:00
Aditya-Sood
d2c3e447c5 Refactor FileListAdapter
Use ButterKnife for list items
2019-08-12 21:20:02 +05:30
Aditya-Sood
20e1eebf37 Refactor isLocationServiceEnabled()
- Change method implementation
- Inject LocationManager into LFTA
2019-08-12 20:44:14 +05:30
Sean Mac Gillicuddy
0669f20666 #1212 clean up KiwixMockServer 2019-08-12 14:20:59 +01:00
Aditya-Sood
1baafc9db4 Refactor KiwixWifiP2pBroadcastReceiver
Forward only what's required to WDM
2019-08-12 18:39:15 +05:30
Aditya-Sood
d78f07be6a Refactor WDM
Remove extra null checks for wifi-p2p manager
2019-08-12 18:22:09 +05:30
Aditya-Sood
4b260e15ed Refactor FileItem
- No longer Parcelable
- Add private constructor for the two public constructors
2019-08-12 17:34:24 +05:30
Aditya-Sood
72ccd4f7e3 Refactor WDM
Inject dependencies AlertDialogShower & SharedPreferenceUtil directly into WDM
2019-08-12 16:30:01 +05:30
Seán Mac Gillicuddy
974c2d9f04
Merge pull request #1353 from kiwix/abdulwd/issue1352
Fix #1352 Download button is fixed to right even for RTL scripts
2019-08-12 11:48:42 +01:00
Abdul Wadood
cc4daa37e2 Add comment for using app:layout_constraintRight_toRightOf 2019-08-12 12:04:32 +02:00
Aditya-Sood
da141c8622 Increment: Inject WDM into LFTA 2019-08-12 15:21:54 +05:30
Abdul Wadood
3ed840334c Fix #1352 Download button is fixed to right even for RTL scripts 2019-08-12 11:15:11 +02:00
Aditya-Sood
5167e22466 Refactor isLocationServicesEnabled()
Revert to original implementation of the method
2019-08-12 13:07:25 +05:30
Aditya-Sood
f071ad60b7 Refactor WDM.Callbacks interface 2019-08-12 00:18:03 +05:30
Aditya-Sood
c1288e6766 Refactor isLocationServicesEnabled() 2019-08-12 00:10:47 +05:30
Aditya-Sood
32bfe70643 Refactor: BroadcastReceiver handled by WDM 2019-08-12 00:04:52 +05:30
Isaac Hutt
5d69f20478
Merge pull request #1349 from kiwix/feature/mhutti1/menu-reorder
#1344 Reorder menu to make search visible again
2019-08-11 18:47:26 +02:00
Aditya-Sood
d6cc0b8faa Major refactor: Incorporate file uris in FileItem 2019-08-11 21:23:12 +05:30
mhutti1
983817d96a #1344 Reorder menu to make search visible again 2019-08-11 17:39:49 +02:00
Isaac Hutt
3efa55c969
Merge pull request #1336 from kiwix/#960-update-popup-icon
#960 updated external link warning popup icon to match others
2019-08-11 17:14:34 +02:00
mhutti1
0e895b192c #1259 Allow a local kiwix-lib aar to be used 2019-08-11 16:37:44 +02:00
Aditya-Sood
4e7a2e03c2 Minor refactors 2019-08-11 18:22:58 +05:30
Isaac Hutt
bb57ea4def
Merge pull request #1346 from kiwix/siddharth2010/ReloadZimList
Update Zim File queue on Home Screen on onResume
2019-08-11 14:11:26 +02:00
Aditya-Sood
3b1e073f05 Refactor SenderDeviceAsyncTask 2019-08-11 15:35:09 +05:30