I changed the code to make toolbar hide when user scroll up as
default.In setting it will give an option to enable the
"Not hide toolbar".By enabling it toolbar will not hide as the
user scrolls up else default will work as usual.
Closes https://github.com/kiwix/kiwix-android/issues/10
This commit fixes#323 by checking if books is null before:
Attempt to invoke virtual method 'int java.util.LinkedList.size()' on a null object reference
Signed-off-by: David Sn <divad.nnamtdeis@gmail.com>
option.
Duplicated the text that appears on the preferences in the summary so
that the user can actually read what it says. This particularly affects
smaller screened device. It might be worth revising the title, however
that'd then need any changes to be retranslated. This change isn't ideal
(duplicating content on the screen) however it seems practical and
helpful. You're welcome to help improve it.
Created custom LanguageSelectDialog class. This can be reused in multiple places. The library screen has been modified to use this class. Settings screen still requires modification.
A sample library_zim.xml is available at
https://github.com/kiwix/testfiles/blob/master/libraryfiles/one_item_in_library/library_zim.xml
The bug seems to have been introduced inadvertently in
b9930252e1
which returned a null to `getView(...)`
I've left a key log statement as this was one clue (after checking
various other areas of the codebase) that indicated there might be a
problem related to the number of entries rather than the attributes of
the item. I aim to revise the format of the log message as part of a
wider update on logging.