8066 Commits

Author SHA1 Message Date
Kelson
4a39ba80ca
Merge pull request #3922 from kiwix/Fixes3890
Fixed: Duplicate bookmarks showing on the bookmark screen, and bookmark.xml showing to bookmarks connected to each other.
2024-07-04 07:47:52 +02:00
MohitMaliFtechiz
19666d51e2 Fixed ImportBookmarkTest. 2024-07-04 07:40:34 +02:00
MohitMaliFtechiz
2f000d7400 Showing the original bookmark as and removed the unrelated page bookmark. 2024-07-04 07:40:34 +02:00
MohitMaliFtechiz
c2dd8a894d Fixed: Duplicate bookmarks showing on the bookmark screen, and bookmark.xml showing to bookmarks connected to each other. 2024-07-04 07:40:34 +02:00
Kelson
46b0e2c616
Merge pull request #3923 from kiwix/Fixes#3920
Fixed: Suggestions to 90% broken on Wikimed FR.
2024-07-04 07:18:39 +02:00
MohitMaliFtechiz
31e1458928 Fixed emulator is not starting while running custom apps test cases. 2024-07-03 20:27:28 +05:30
MohitMaliFtechiz
01cce5307e Refactored the test case to use the scientific-alliance zim file since this zim can reproduce this bug. 2024-07-03 18:09:30 +05:30
MohitMaliFtechiz
32e1ba69de Fixed the test cases failure. 2024-07-03 17:28:11 +05:30
MohitMaliFtechiz
998edda2aa Removed the testing code 2024-07-03 16:27:20 +05:30
MohitMaliFtechiz
2a4c9c51d4 Added test cases for custom apps so that we can avoid the error in search functionality of custom apps. 2024-07-03 16:25:41 +05:30
MohitMaliFtechiz
16844541c0 Fixed: Suggestions to 90% broken on Wikimed FR.
* In custom apps we are using the assetFileDescriptor, and the `dup()` method of `parcelFileDescriptor` is internally throwing resource leak exception(found in the debug stacktrace while running the application under the strace) and it somehow impacting the suggestion API.
* Removed the dup method of the `parcelFileDescriptor`.
2024-07-03 16:25:16 +05:30
Shaun Burch
afb188542b #1553 Update test for QR 2024-07-01 22:01:53 -04:00
Shaun Burch
b6b87b9b8c #1553 Default QR to gone 2024-07-01 22:01:53 -04:00
Shaun Burch
4b951df961 #1553 Remove unused code 2024-07-01 22:01:53 -04:00
Shaun Burch
90b3137216 #1553 Move QR above ZIM files 2024-07-01 22:01:53 -04:00
Shaun Burch
fe22851843 #1553 Use getSocketAddress 2024-07-01 22:01:53 -04:00
Shaun Burch
f40185de2a #1553 Remove ZXing comment 2024-07-01 22:01:53 -04:00
Shaun Burch
9e1a212cb2 #1553 Add QR to hotspot notification 2024-07-01 22:01:53 -04:00
Shaun Burch
7f19919317 #1553 PR Feedback
- Rename to QRCodeDialog
- Move to core module
- Inject GenerateQR
- Remove preview string
2024-07-01 22:01:53 -04:00
Shaun Burch
4ae59f1369 #1553 Fix testZimHostFragment 2024-07-01 22:01:53 -04:00
Shaun Burch
fa1113fc00 #1553 Tests 2024-07-01 22:01:53 -04:00
Shaun Burch
f2e7e7a3c0 #1553 Use String for share by QR 2024-07-01 22:01:53 -04:00
Shaun Burch
a8d27596fe #1553 Touch up QR dialog 2024-07-01 22:01:53 -04:00
Shaun Burch
3c8f5a44e9 #1553 Generate & show QR 2024-07-01 22:01:53 -04:00
Shaun Burch
f02d4b8f03 #1553 Add Share by QR 2024-07-01 22:01:53 -04:00
Kelson
3c0397d9fc
Merge pull request #3918 from kiwix/Fixes#3912
Fixed: latency in showing whether a bookmark is added in the toggle button.
2024-07-01 22:04:05 +02:00
MohitMaliFtechiz
5f9ef86733 Fixed: latency in showing whether a bookmark is added in the toggle button.
* Previously, we are checking the bookmark is added or not when a page is fully loaded in the webView. In the meantime previously set bookmark toggle is showing e.g. if the previous page is added as a bookmark then until the page is fully loaded the toggle is showing that the current is added as a bookmark. However, this new page is not added as a bookmark.
* To fix this latency, we moved our `updateUrlProcessor()` method to the `webViewProgressChanged` method to update the bookmark toggle when a page starts loading in the webView. This fixes the latency in updating the bookmark toggle.
2024-07-01 17:55:38 +05:30
Kelson
ad9e7e6b5b
Merge pull request #3914 from kiwix/Fixes#3908
Displaying the ZIM title in the notification instead of the file name.
2024-06-29 13:41:35 +02:00
MohitMaliFtechiz
7015812411 Displaying the ZIM title in the notification instead of the file name.
* In the notification, the information coming from `fetch` does not include the ZIM title (only the file name is currently shown in the notification). However, we have the `FetchDownloadDao` where we save all the details related to downloads. We have created a method in `FetchDownloadDao` that retrieves the downloadEntity from the file name, which includes the ZIM title, and we are now displaying that title in the notification.
2024-06-29 14:56:25 +05:30
Kelson
e960848b2c
Merge pull request #3911 from kiwix/Fixes#3907
Fixed: Sometimes migration test took longer in migration in lower device(e.g. API level 25) and fails the test case.
2024-06-28 16:55:55 +02:00
MohitMaliFtechiz
a283e9491f Fixed: Sometimes migration test took longer in migration in lower device(e.g. API level 25) and fails the test case.
* Increased the migration timing a little bit as migration sometimes takes a few milliseconds more on CI.
2024-06-28 18:43:27 +05:30
Kelson
9c4ae35c42
Merge pull request #3906 from kiwix/update_changelog_file_for_3.11.1
Updated CHANGELOG file to show the changes made in milestone `3.11.1`.
3.11.1
2024-06-27 14:28:19 +02:00
MohitMaliFtechiz
5dd16354f9 Updated CHANGELOG file to show the changes made in milestone 3.11.1. 2024-06-27 17:49:28 +05:30
Kelson
cbfb5e262a
Merge pull request #3876 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2024-06-27 14:11:23 +02:00
translatewiki.net
0f6232cac6 Localisation updates from https://translatewiki.net. 2024-06-27 14:11:08 +02:00
Kelson
c6b025f04a
Merge pull request #3905 from kiwix/upgrade_kiwix_version_to_3.11.1
Upgraded the kiwix version to 3.11.1
2024-06-27 14:09:49 +02:00
MohitMaliFtechiz
4e96703b11 Upgrade the kiwix version to 3.11.1 2024-06-27 14:08:04 +02:00
Kelson
262b4e5d75
Merge pull request #3904 from kiwix/Fixes#3901
Fixed: A `NotSerializableException` was attached to the crash logs instead of the actual crash logs when there was an error in the coroutine.
2024-06-27 14:07:45 +02:00
MohitMaliFtechiz
0d5a330d3f Improved logging for exceptions that do not have a stack trace. 2024-06-27 15:52:16 +05:30
MohitMaliFtechiz
a2ac6429a7 Fixed: A NotSerializableException was attached to the crash logs instead of the actual crash logs when there was an error in the coroutine.
* The serialization issue was fixed in coroutine version `1.7.0`, so we have upgraded the coroutine dependency to `1.7.0` to address this issue.
* In the new version of coroutines, `ConflatedBroadcastChannel` is replaced with `StateFlow`, so we have refactored our code to use `StateFlow`.
* Fixed some detekt issues which occurs after upgrading this dependency.
2024-06-27 14:50:23 +05:30
Kelson
e4c3d1a6e8
Merge pull request #3900 from kiwix/Fixes#3899
Fixed: `SQLiteConstraintException` when inserting the same id item of hisotry/notes in room database.
2024-06-27 08:33:48 +02:00
MohitMaliFtechiz
91eacae0f4 Improved DeletePageItemsTest test. 2024-06-26 22:35:24 +05:30
MohitMaliFtechiz
13233e0dcc Fixed: SQLiteConstraintException when inserting the same id item of hisotry/notes in room database.
* id is the primary key for notes/history and when there is an already id available in the room database, and if there is the same id present in the objectbox database and we try to put that entity in the room it gives the SQLiteConstraintException. To fix this we have modified our saving functions of history and notes. If there is already an ID that exists in the room database that we are trying to put in the database it will set the ID to 0 so that the room will automatically assign the ID to that entity and our history/notes will prevent to be lost.
* Added the test cases to properly test these scenarios.
2024-06-26 22:25:18 +05:30
Kelson
2dd933e7ba
Merge pull request #3898 from kiwix/Fixes#3897
Fixed: `getDirectAccessInformation()` method throw the `InvocationTargetException` and crash the application.
2024-06-26 13:13:49 +02:00
MohitMaliFtechiz
352c4038d3 Improved the exception handling. 2024-06-26 15:29:31 +05:30
MohitMaliFtechiz
a902f15480 Fixed: getDirectAccessInformation() method throw the InvocationTargetException and crash the application. 2024-06-26 15:29:24 +05:30
Kelson
4a30af5462
Merge pull request #3893 from kiwix/Fixes#3889
Fixed: Sometimes not all Bookmarks are showing.
2024-06-25 21:44:45 +02:00
MohitMaliFtechiz
f209aa6c6a Fixed BookmarkStateTest, BookmarkViewModelTest, and ShowDeleteBookmarksDialogTest. 2024-06-25 23:22:15 +05:30
MohitMaliFtechiz
38e4fe41cb Fixed DownloadTest, initialDownload. The Library order and zim file name is changed so these test cases are failing so we have implemented a generic approach to not dependent on zim file name. 2024-06-25 23:22:08 +05:30
MohitMaliFtechiz
b0c5db4ad3 Added test cases for testing all the saved bookmarks should show on the bookmarks screen. 2024-06-25 23:22:02 +05:30