macgills
7b97931994
Merge pull request #1230 from kiwix/feature/macgills/#1229-remove-build-types
...
PR: #1229 BuildTypes removed
2019-07-01 10:09:25 +01:00
Kelson
9b3c827261
Merge pull request #1241 from kiwix/feature/kelson42/#1236-use-kotlin
...
Feature/kelson42/#1236 use kotlin
2019-07-01 11:06:04 +02:00
Aditya-Sood
085ed7f7bd
Refactor AddNoteDialog
...
- Added @NonNull annotations & replaced return values accordingly
- Use ternary operator
2019-06-30 18:19:43 +05:30
Aditya-Sood
1dcffa41bd
UI background update
...
Use a softer dark gray background for compatibility with both dark and light modes
2019-06-29 23:37:46 +05:30
Aditya-Sood
93cf742d89
Increment: Ask user to confirm destination device before connecting
2019-06-29 23:21:21 +05:30
Aditya-Sood
ece703fbb9
Bugfix & Increment
...
- Fix user circumventing permissions: Permissions are now checked everytime the user taps the search icon, preventing the user from initiating search without required permissions.
- Added: Display rationale for the permission being requested
2019-06-29 23:04:19 +05:30
Aditya-Sood
adeffa854b
Add responses to user
...
For refusing to enable WiFi or Location Services
2019-06-29 22:28:31 +05:30
Aditya-Sood
37b09bfa4b
UI bug fix
...
Fix alignment offset between progress bar and status icon in FileItem list
2019-06-29 22:07:02 +05:30
Aditya-Sood
ff6768cbaa
Refactor & Documentation
...
TransferProgressFragment, FileItem & FileListAdapter
2019-06-29 21:55:50 +05:30
Aditya-Sood
f9103e2d5a
Remove FileTransferService
...
Functionality has already been replaced by the SenderDeviceAsyncTask
2019-06-29 21:08:28 +05:30
Aditya-Sood
dd2b4dfa76
Refactor WifiDirectBroadcastReceiver
2019-06-29 21:03:38 +05:30
Aditya-Sood
91b26a9f08
Major Refactor!
...
Comprehensive refactoring of DeviceListFragment, includes:
- Shifting all async-tasks to separate files
- Exceptions in the async-tasks are now handled by showing a toast and closing the LocalFileTransferActivity
- Added a new 'Error' status for file items
- If a file has error status after transfer, then an error icon is shown for it TransferProgressFragment
- Documentation and other additions/changes
2019-06-29 18:18:58 +05:30
Kelson
9fa55c3d8b
#1236 Kiwix is written in Kotlin
2019-06-29 10:12:02 +02:00
Sean Mac Gillicuddy
c0de738470
#1238 100% StorageObserver
2019-06-28 17:03:39 +01:00
Sean Mac Gillicuddy
39a964bf42
#1238 aim for 100% coverage
2019-06-28 16:23:30 +01:00
Sean Mac Gillicuddy
5079df2469
#1238 just use plus
2019-06-28 15:02:49 +01:00
Sean Mac Gillicuddy
fd9f797105
#1238 Unit test FileSearch
2019-06-28 14:18:16 +01:00
Aditya-Sood
147dbb033b
Refactor LocalFileTransferActivity
2019-06-28 16:58:47 +05:30
Aditya-Sood
74ab4b4a44
Refactor activity_local_file_transfer.xml
...
- Add title to activity
- Divide screen space between list of available peers and files for transfer
2019-06-28 16:56:17 +05:30
Aditya-Sood
36f563e209
Remove extra stuff
...
Unnecessary comments, todos, variables, imports, methods
2019-06-27 23:32:29 +05:30
Aditya-Sood
865b579057
Bug fix: Correct the usage of close icon
...
MainActivity, AnimationUtils & tab_switcher.xml were using the "ic_close_white_24dp" (whose colouring was corrected in a previous commit of this branch from black to white, which caused the 'Close all tabs' button to appear completely white without any icons)
2019-06-27 20:40:46 +05:30
Aditya-Sood
f568857952
Refactor & documentation
...
- Refactor: AddNoteDialog
- Doucumentation: AddNoteDialog & ZimContentProvider
2019-06-27 17:13:30 +05:30
Aditya-Sood
ea3490e048
Increment: Change path for storage of note files
...
Code now uses ".../Kiwix/Notes/ZimFileName/ArticleUrl.txt" instead of ".../Notes/ZimFileTitle/ArticleTitle.txt" for storing notes
- Changed because multiple zim files can have the same ZimFileTitle, whereas ZimFileName is the actual name of the zim file (& hence unique).
- Chose ArticleUrl over ArticleTitle for greater stability (as article urls, being a core part of Kiwix, will always exist and hence are less likely to break the app)
2019-06-27 16:50:52 +05:30
Isaac Hutt
0539d56849
Merge pull request #1198 from kiwix/feature/NoteKeeper
...
GSoC 2019 Deliverable: Note Keeper
2019-06-26 21:23:51 +01:00
Aditya-Sood
7759a4eb47
Refactor: Remove changeDeviceName() and related code
...
Device name for WiFi Direct is supposed to be changed manually (from the advanced wifi settings) by the user.
This solution used reflection to access the hidden method used by the system to perform the same. However use of non-SDK interfaces (fields/methods accessed using reflection) will be restricted and subsequently lead to exceptions, hence the feature needs to be removed.
For more: developer.android.com/distribute/best-practices/develop/restrictions-non-sdk-interfaces
2019-06-27 01:22:14 +05:30
Aditya-Sood
26c92ee64e
Increment: Add cancelSearch() method
...
For disconnecting a connection to an erroneous peer device
2019-06-27 01:05:22 +05:30
Aditya-Sood
99b93659f2
Refactor exit from LocalFileTransferActivity
...
- Separate device disconnection to separate method
- Override back button
2019-06-27 00:47:14 +05:30
Aditya-Sood
c474d02391
Fix Bug Part 2: Add finish() activity on sender side once files have been transferred
2019-06-26 23:31:52 +05:30
Aditya-Sood
cf66b61a7d
Fix bug: Last file being transferred gets corrupted
...
Best guess - Calling disconnect after sending the last file was somehow corrupting the output stream to the server. Replacing with Toast (or just finish()) has corrected it.
2019-06-26 22:47:54 +05:30
Aditya-Sood
8874204d0f
Increment: Disconnect devices post file transfer
2019-06-26 22:39:05 +05:30
Aditya-Sood
4115ca3bfb
Increment: Transfer progress is now displayed in the list of files
2019-06-26 21:16:50 +05:30
Aditya-Sood
98184e82cd
Increment: Improve file list display
2019-06-26 21:11:49 +05:30
Sean Mac Gillicuddy
65a28a2f66
#1214 upload universal apk to download.kiwix on nightly build and to Github Releases on a tagged release
2019-06-26 15:09:14 +01:00
Kelson
63599fa685
Merge pull request #1233 from kiwix/https
...
Replace a few HTTP links with HTTPS
2019-06-26 15:53:18 +02:00
Kelson
23347677d0
More links using HTTPS in README
2019-06-26 15:40:37 +02:00
Kelson
624dbe58ef
Merge pull request #1232 from kiwix/macgills/feature/fix-contributing-branching
...
Escape angle brackets
2019-06-26 13:03:47 +02:00
Sean Mac Gillicuddy
51d1729d51
Escape angle brackets
2019-06-26 11:27:43 +01:00
Sean Mac Gillicuddy
62d456ecc4
#1219 use the density from the output file
2019-06-26 10:42:45 +01:00
Sean Mac Gillicuddy
a1094285fb
#1229 BuildTypes removed
2019-06-26 10:29:22 +01:00
Sean Mac Gillicuddy
b4e28323e5
Merge branch 'develop' into feature/macgills/#1219-density-splits
2019-06-26 09:34:45 +01:00
macgills
2481ead365
Merge pull request #1225 from kiwix/feature/macgills/#1224-fix-crash-reporting
...
#1224 use correct fileProvider suffix
2019-06-26 09:32:39 +01:00
Aditya-Sood
af5a4e1c65
Increment: Update code to use FileItem to represent files for transfer
2019-06-26 01:05:31 +05:30
Aditya-Sood
b40cfe779a
Refactor: Fix margin errors in file item layout
2019-06-26 01:04:31 +05:30
Aditya-Sood
4b82f254e2
Increment: Setup file item to show status of transfer
...
3 possible states: To be sent (wait icon) -> sending (progress bar) -> sent (check icon)
2019-06-26 00:20:31 +05:30
Aditya-Sood
f90ba10b75
Add 'FileItem' class to represent files when being transferred
...
Fields: File name and transfer status (to be sent, sending, sent)
2019-06-26 00:17:39 +05:30
Aditya-Sood
be5c377917
Increment: After handshake, both devices display list of files being transferred
...
Next step - Use this list to display progress of transfer
2019-06-25 23:29:02 +05:30
Sean Mac Gillicuddy
5635a50920
#1224 remove extraneous dash in .travis.yml
2019-06-25 15:52:30 +01:00
Sean Mac Gillicuddy
afb62ba9f1
#1224 attempt to fix build
2019-06-25 15:16:59 +01:00
macgills
5274ba81c0
Merge pull request #1227 from kiwix/feature/macgills/#1226-stalebot
...
#1226 create stalebot configuration
2019-06-25 14:18:18 +01:00
Sean Mac Gillicuddy
c21703a4b3
#1226 create stalebot configuration
2019-06-25 13:25:32 +01:00