MohitMaliFtechiz
26bb7c62c1
Fixed all memory leaks in application.
...
* Improved the LanguageFragmentTest by updating it to no longer wait for the "Off the grid" file, which no longer exists. The test case has been enhanced to check whether the data is loaded without relying on any specific ZIM file name.
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
79b441b29a
Trying to run the android 14 emulator on default apis.
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
aed1dd1661
Fixed namespace issue in custom module.
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
1e64f37f2d
Now we have upgraded the kotlin version of our project so we don't need to exclude the kotlin-stdlib package from libkiwix since we are now using the latest version kotlin.
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
132ad353fd
Improved the SearchFragmentTest which sometimes failing.
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
09070d187b
Fixed Instrumentation test cases was failing.
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
302580b425
Fixed the CI was not running on emulators.
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
bfff033af8
Fixed app_name is not found in core module.
...
* Fixed some ids are not found in the project.
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
533ed67f84
Fixed, assemble CI failure.
...
* After upgrading the gradle to `8.1.3` now it is treating proguard warnings as errors. So to fix this we have modify our proguard rules file.
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
69ade98e5c
Fixed all the compilation issues occurring in instrumentation test cases
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
899bca2389
Fixed namespace error in instrumentation test cases
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
d7a870c562
Suppressed TypographyQuotes lint error after upgrading the gradle.
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
2a88bd89d0
Fixed, drawerLayout ids not set in app and custom module. * Fixed memory leak in CoreReaderFragment. * Improved variables and method for better optimization.
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
3cdb7d998d
Fixed, ids and string are not found in app and custom module
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
8f6cde05b3
Fixed, package name and R classes not found in custom module
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
1d7cbbd96b
FIxed, detekt and lint issues
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
f352d27616
Fixed, coordinatorLayoutStyle, colorOnSurface, colorPrimary not found errors after upgrading the gradle
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
d2f33f8270
Removed butterknife from core module
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
8c522daa07
Upgraded few dependencies. * Upgraded kotlin to to make it compatible with gradle . * Upgraded dagger to to make it compatible with gradle . * Removed from project since it is not maintained from 2020 and new gradle is not compatible with this library, so we have changed the it with binding.
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
2a9bbe71b3
Resolve namespace issues for compatibility with Gradle 8.0 and above. * In compliance with the requirement to specify a namespace for each module, we have eliminated package names from manifests and introduced namespace declarations in the Gradle files. * Considering the presence of multiple apps in the custom app, we configured the namespace during the creation of product flavors. * To enhance clarity and understanding, comprehensive comments have been added.
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
0f65ebeff9
Enabled BuildConfig file, since it is by default turened off in new gradle
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
19e18f6276
Configured CI to use Java 17 instead of Java 11 because new gradle version are needed Java 17 to compile the project.
2024-08-16 15:35:10 +00:00
MohitMali
f314e70d0c
Upgraded Gradle to 8.1.3 * Added the namespace property in the build.gradle file because, in the newer Gradle version, it is necessary to specify the namespace in the build.gradle file instead of declaring it in the manifest file.
2024-08-16 15:35:10 +00:00
MohitMali
2b8f7300f6
Fixed detekt issues.
2024-08-16 15:35:10 +00:00
MohitMali
f066272087
Running the Android 14 test cases with aosp_atd emulators since default apis is not available for Android 14.
2024-08-16 15:35:10 +00:00
Gouri Panda
86b977c950
Add API 34 to default
2024-08-16 15:35:10 +00:00
MohitMaliFtechiz
88a83be01d
Updated to Android 14 & refactored some methods inorder to compile with the SDK 14
2024-08-16 15:35:10 +00:00
Kelson
453c1d38ef
Merge pull request #3977 from CalebKL/task/bottom-page-content-cut-bug-fix
...
Fix bottom page content being cut
2024-08-16 15:34:45 +00:00
CalebK
173db42aa0
updated bottom navigation padding
2024-08-16 18:19:05 +05:30
CalebK
0b954eeaf0
Revert contentFrame padding values
2024-08-16 18:19:05 +05:30
CalebK
f99a68ac37
Bump padding to 40dp
2024-08-16 18:19:05 +05:30
CalebK
d44eb701ab
Fix bottom page content being cut
2024-08-16 18:19:05 +05:30
Kelson
d43092f774
Merge pull request #3974 from kiwix/Fixes#3965
...
Fixed: Dark mode failing on "Astrolabe" homepage.
2024-08-16 10:58:09 +00:00
MohitMaliFtechiz
68137fb363
Fixed: Dark mode failing on "Astrolabe" homepage.
...
* Removed the unnecessary rule that was inverting the header image. Since the image was already inverted, there is no need to apply the filter again.
* The poster image was being inverted due to the first rule being applied to the poster element, which caused the image and video inside the poster to be inverted. To correct this, a CSS rule is added to prevent the inversion of the poster's image and video.
2024-08-14 12:59:58 +05:30
Kelson
78e63497c9
Merge pull request #3935 from kiwix/Fixes#3141
...
Replacing the fetch library with Android's DownloadManager.
2024-08-12 18:08:26 +02:00
MohitMaliFtechiz
d34dd376d7
Improved the migration of storage for existing users according to DownloadManager's storage configuration.
2024-08-12 17:47:03 +05:30
MohitMaliFtechiz
c9b43117e6
Removed the fetch library from README file.
...
* Also, now we are not using fetch library anymore so we have removed this from our credits files.
* Removed the unused code from detekt_baseline.xml file.
2024-08-12 17:15:42 +05:30
CalebK
a267ae835d
refactor shouldEnablePauseResumeButtonForPauseReason to clarify functionality of the function
2024-08-12 17:14:18 +05:30
CalebK
1df1cab9ac
minor improvements on shouldEnablePauseResumeButton
2024-08-12 17:14:18 +05:30
MohitMaliFtechiz
6b60a8c444
Removed the unnecessary variables and logs from code
2024-08-12 17:14:18 +05:30
MohitMaliFtechiz
df9bbb0ad3
Fixed the pause/resume functionality:
...
* When there is no available connection that the user started the download with, the pause/resume button is disabled to prevent attempts to resume or pause the download, which would not work in this state.
* If the user attempts to resume the download but it does not resume due to some issue, the code will automatically try to resume the download. This ensures a smooth user experience.
* Proper pause reasons are displayed to the user, keeping them informed about the current state of the download.
* If a download fails for any reason, the pause/resume button is disabled. At this point, the pause/resume functionality is unnecessary and would not work, so the button is disabled to avoid confusion.
* To ensure clarity and understanding, we have added necessary comments on the method and conditions.
2024-08-12 17:14:18 +05:30
MohitMaliFtechiz
64c80ac6dd
Fixing the pause/resume functionality
2024-08-12 17:14:18 +05:30
MohitMaliFtechiz
a41899bae6
Fixed the issue where the Pause/Resume button was enabled when a download failed. In such cases, the pause/resume functionality does not work, so we have disabled the button to prevent unexpected behavior.
2024-08-12 17:14:18 +05:30
MohitMaliFtechiz
2c8a9a45f8
Fixed Downloading is not working on Android 11, and Android 12.
...
* For Android 11 and above, we now download ZIM files to the app-specific directory because the download manager does not allow downloads to custom paths. Therefore, ZIM files are now downloaded inside the app-specific directory for these versions.
* Removed the folder selection dialog from the application for selecting the SD card in non-Play Store variants on Android 11 and Android 12.
* For Android 10 and below, ZIM files are now downloading to the public directory on the SD card. This ensures that the files are not lost when the application is uninstalled, as they are stored in a public directory similar to internal storage on these versions.
* Also improved the showing pause reason on download screen when downloadManager is paused due to "PAUSED_WAITING_TO_RETRY" error so that user can know about the downloading state.
2024-08-12 17:14:18 +05:30
MohitMaliFtechiz
3e9ff05bd9
Disabled the controls in the notification when the download is in a paused state, as the pause state could occur if DownloadManager is waiting for WiFi.
...
* Fixed the user behavior when attempting to download the ZIM file only on WiFi, and added a proper message explaining why the download is paused.
2024-08-12 17:14:18 +05:30
MohitMaliFtechiz
68b091ea6d
Enabled the controls in the notification for pausing/canceling the downloads when the download is in a Queued state.
2024-08-12 17:14:18 +05:30
MohitMaliFtechiz
623d65e06f
Fixed sometimes downloads remain on the "Download Screen" after successfully downloading.
...
* Improved the "DownloadTest".
2024-08-12 17:14:18 +05:30
MohitMaliFtechiz
88d828e5ce
Removed the fetch library and its code from project.
...
* Fixed the Downloading for Authentication URL.
2024-08-12 17:14:18 +05:30
MohitMaliFtechiz
775fab14bc
Fixed unit coverage
2024-08-12 17:14:18 +05:30
MohitMaliFtechiz
cb8829ea5f
Fixed the resume is not working properly.
2024-08-12 17:14:18 +05:30
