8300 Commits

Author SHA1 Message Date
Kelson
29c3962172
Merge pull request #3797 from kiwix/Fix#3796
Fixed: PlayStore reported IndexOutOfBoundsException, when we are selecting the item from rightDrawer.
2024-04-17 19:50:34 +02:00
MohitMaliFtechiz
5e9962b5a1 Fixed: PlayStore reported IndexOutOfBoundsException, when we are selecting the item from rightDrawer.
* The error is not reproducible on my device and emulators too. But playStore reported this error so somehow this error is occurring. So to fix this issue we are now only performing the click action when the item is available in the DocumentSectionsList. This will avoid this type of error.
2024-04-17 22:51:43 +05:30
Kelson
65591d26dd
Merge pull request #3793 from kiwix/Fix#3792
Fixed: Tabs are not restoring if we accidentally click twice on the Close all tabs button.
2024-04-17 19:05:31 +02:00
MohitMaliFtechiz
a96d5de33b Fixed: Tabs are not restoring if we accidentally click twice on the Close all tabs button.
* This issue occurred because when the Close all tabs button was first clicked, it closed all tabs and stored them into the temp list, emptying the main list. However, if the button was immediately clicked again, it would attempt to copy the main list to the temp list, which was already empty. To address this issue, we have disabled the button after the first click to prevent such situations, as they can occur due to accidental clicks.
* Enhanced the behavior of the "Tabs closed" snackBar. Now, when the user clicks the "UNDO" button to restore a tab, we disable the snackBar's "UNDO" button to prevent subsequent clicks. This prevents the addition of multiple tabs if the "UNDO" button is clicked multiple times, as such restored tabs can lead to unexpected behavior.
2024-04-17 18:35:47 +02:00
Kelson
236f695166
Merge pull request #3791 from kiwix/Fix#3790
Fixed: Play Store reported a crash error when closing the tabs.
2024-04-17 18:35:25 +02:00
MohitMaliFtechiz
40e86d02b6 Enhanced the Tab closed snackBar behavior. Now, when the user clicks the UNDO button to restore a tab, we disable the snackBar's "UNDO" button to prevent subsequent clicks. This prevents the addition of multiple tabs if the UNDO button is clicked multiple times, as this type of restored tab leads to unexpected behavior see below video. 2024-04-17 18:16:22 +02:00
MohitMaliFtechiz
dda2200a4b Fixed: Play Store reported a crash error when closing the tabs.
* This error was occurring due to the user frequently clicking the close icon of the same tab, in this situation first click closes the tab, and the second immediate click again triggers the `closeTab` function but recyclerView does not have the valid view for this position because it is in removing process so this makes this view invalid and recyclerView returns the `-1` index for invalid views. So this was the reason for this issue, to address this issue we have added a check in our `closeTab` method if the incoming index is `-1` then it will not execute the further code.
2024-04-17 18:16:22 +02:00
Kelson
cf745d3cad
Merge pull request #3795 from kiwix/Fix#3794
Fixed: PlayStore reported `UninitializedPropertyAccessException` when launching the `KiwixMainActivity`.
2024-04-17 18:15:46 +02:00
MohitMaliFtechiz
ebfea07fd4 Fixed: PlayStore reported UninitializedPropertyAccessException when launching the KiwixMainActivity.
* The error was occurring when launching the `KiwixMainActivity`. At this moment, `coreComponent` was in creation process so it is not initialized at this moment, and we are passing this component in our `KiwixMainActivity` through interface for injection of this activity. But we are not using `coreComponent` object in our `KiwixMainActivity` so passing it to the activity is unused because we are injecting this activity through `cachedComponent`, and this unused object causing the error. So we have removed this interface from our `BaseActivity` and directly injecting `KiwixMainActivity` in via `cachedComponent`.
2024-04-17 20:33:09 +05:30
Kelson
4ccaca5df5
Merge pull request #3786 from kiwix/Fixes#3784
Changing runner to `ubuntu-latest`.
2024-04-16 17:15:44 +02:00
MohitMaliFtechiz
b0caf69715 Changed the runner version to ubuntu-22.04. 2024-04-16 10:50:03 +05:30
MohitMaliFtechiz
30424518a8 Re-enabled the caching of avd. 2024-04-15 16:51:58 +05:30
MohitMaliFtechiz
d0cf899009 Add heap-size to emulator. Also, set to not force create the avd when running the test cases. 2024-04-15 16:51:51 +05:30
MohitMaliFtechiz
fa5e1cfc82 Changing runner to ubuntu-latest.
* Changed the runner of CI to `ubuntu-latest` to boost the performance.
*  Enabled the `fail-fast` option in CI, if any of jobs fail on any emulator then it will cancel the all jobs running on other emulators in the current process so that other PRs do not need to wait to finish this job. Also, this will reduce the running timing on CI since if a job fails on any emulator we need to fix that so running others jobs does not make sense. So we are canceling those jobs if any fail.
* Introducing caching for AVD to run test cases faster. It will reduce emulator boot time.
* Changed emulator configurations for the 'ubuntu-latest' runner. Removed the 'disk-size' option since it was throwing an error, causing the emulator not to boot. Also, reduced the SD card size to 2GB from 4GB.
* Reduced the SD card size to 2GB from 4GB.
2024-04-15 16:51:44 +05:30
Kelson
735bf1caa3
Merge pull request #3789 from kiwix/polish-readme
Small refresh of the README.md
2024-04-13 15:25:59 +02:00
Emmanuel Engelhart
59531677d5
Small refresh of the README.md 2024-04-13 15:24:28 +02:00
Kelson
5e3a5661e0
Merge pull request #3788 from kiwix/codecov-token
Add CODECOV_TOKEN
2024-04-12 20:10:04 +02:00
Emmanuel Engelhart
4ed3511660
Add CODECOV_TOKEN 2024-04-12 18:43:48 +02:00
Kelson
ef9fcd6ee9
Merge pull request #3785 from kiwix/fix_allocate_buffers_on_ci
Fixed allocate_buffer_size on CI.
2024-04-12 17:58:13 +02:00
MohitMaliFtechiz
1251dc403e Improved KiwixSplashActivityTest which failed once on CI. 2024-04-12 20:33:06 +05:30
MohitMaliFtechiz
3a0054e97d Improved ZimHostFragmentTest which sometimes unable to find the "PROCEED" button. 2024-04-12 18:11:33 +05:30
MohitMaliFtechiz
8c72d404bb Improved the systemDialog checking method, Last CI was failed due to a system dialog is visible but with some different title so closing the system dialog code does not work. So we have improved a bit this method because most of the system dialog have the "WAIT","Wait","OK" or "Ok" button in it. 2024-04-12 17:51:12 +05:30
MohitMaliFtechiz
248dd79a27 Fixed allocate_buffer_size on CI.
* The allocated buffer size exceeded due to the retry policy of our test cases. When we retry a test, more objects are allocated to memory, causing this issue.
* When retrying a test case that failed initially, the "MANAGE_EXTERNAL_STORAGE" permission dialog appears on the window due to clearing the preferences in our test case. Therefore, we have removed that code from our test cases.
* Enhanced the test code to detect the views inside the dialogs since our test cases fail due to these dialog's views, which take a moment to appear on the window, making our test cases flaky on CI. This is also the reason for allocating more objects in memory when we retry the test case.
* Improved the `LocalFileTransferTest` as it sometimes fails on API level 33 due to the unavailability of WIFI. When WIFI is not available, the "Enable WIFI P2P" dialog appears on the window, causing our test case to fail. Subsequently, our RetryRule attempts to run this test case again, leading to the allocation of more objects in memory.
* Created a `testFlakyView` function this function is helpful in testing the flakyViews.
2024-04-12 16:57:08 +05:30
Kelson
a9f17432e4
Merge pull request #3782 from kiwix/Fix#3781
Fixed: Sometimes all the test cases crash on first time and some fail due to the navigation drawer being visible on the window. (Android 13).
2024-04-10 17:43:13 +02:00
MohitMaliFtechiz
94e02c3585 Fixed a few flaky test cases which sometimes fails on CI. 2024-04-10 19:02:36 +05:30
MohitMaliFtechiz
00580d5afa Increased ram, cores and heap-size for API level 30 emulator for better test performance.
* Improved test performance.
2024-04-10 19:02:25 +05:30
MohitMaliFtechiz
f90d92e1e4 Improved ObjectBoxToLibkiwixMigratorTest to not show the PlayStoreRestrictionDialog while running the other test cases, also removed the duplicate code from few test cases. 2024-04-10 19:02:07 +05:30
MohitMaliFtechiz
50ea34228e Improved the Refreshing data check for loading the ZIM files from phones storage.
* Improved the `LanguageFragmentTest` slightly to wait for the searched language to appear at the top of the list.
* Running the CI on `aosp_atd` instead of `google_apis`.
2024-04-10 19:01:51 +05:30
MohitMaliFtechiz
1a5575c800 Waiting until the scanning process is running before deleting the ZIM files in the local library screen since it takes a few seconds to load the ZIM files that are available in storage.
* Closing the tabs if visible in `NavigationHistoryTest`, since sometimes tabs are visible in this test case, and the test case does not find the views and fails.
2024-04-10 19:01:30 +05:30
MohitMaliFtechiz
82a82106cb Improved the closeSystemDialogs method since it was not closing the system dialogs on Android 11 and above. So we have improved this method to close the system dialogs on Android 11 and above by clicking on dialog's button instead of sending broadcast to system.
* Added wait before deleting the ZIM files in the local library screen since it takes a few seconds to load the ZIM files that are available in storage.
2024-04-10 19:01:21 +05:30
MohitMaliFtechiz
dfdbc1be35 Fixed: Sometimes all the test cases crash on first time and some fail due to the navigation drawer being visible on the window. (Android 13).
* We are clearing the data of application on 2nd and 3rd run, and the test cases are running normally so now we are clearing the application data on first run as well.
* Additionally, we've implemented drawer closure in `LanguageFragmentTest`, `LocalFileTransferTest`, and `NoteFragmentTest`. These tests sometimes encountered an open navigation drawer due to test failures or process crashes.
* Enhancements have been made to the `testShowCaseFeatureShowOnce` test case. It's now independent of other test cases, ensuring it remains unaffected in the event of a test process crash or failure.
2024-04-10 18:59:06 +05:30
Kelson
db10e1e7ba
Merge pull request #3777 from Sagar0-0/develop
#3764 Added ripple into FIND IN PAGE
2024-04-09 14:50:02 +02:00
Sagar
dad5e7a319 #3764 Added ripple into FIND IN PAGE 2024-04-08 23:57:42 +05:30
Sagar
75a7068a04 #3764 Added ripple into FIND IN PAGE 2024-04-05 17:18:48 +05:30
Sagar
6113822aaf #3764 Added ripple into FIND IN PAGE 2024-04-05 15:02:49 +05:30
Sagar
c3d1c72923
Merge branch 'kiwix:main' into develop 2024-04-05 15:02:19 +05:30
Kelson
0e8de98ebc
Merge pull request #3780 from kiwix/Fix#3779
Fixed: The wrong message appears while committing the code, if Lint/Static analysis has failed.
2024-04-04 07:18:14 +02:00
MohitMaliFtechiz
61f87f1b13 Fixed: The wrong message appears while committing the code, if Lint/Static analysis has failed.
* Refactored the error message to show the correct information to the developers, since our projects needs JDK11 to run so we have added this JDK version in error message. Also, corrected the gradle wrapper version in this message.
2024-04-04 07:17:51 +02:00
Kelson
18f7876f64
Merge pull request #3775 from kiwix/Fix#3774
Fixed: If restoring the tabs fails it shows the message in English language even if you are using the application in other languages.
2024-04-04 07:16:53 +02:00
MohitMaliFtechiz
2704c787aa Fixed: If restoring the tabs fails it shows the message in English language even if you are using the application in other languages.
* Fixed a static toast which is showing when there is an error in restoring the tabs. We have moved this static error message to our string file so that it will be translated in every language and user will see the error message in their own language.
2024-04-04 07:16:34 +02:00
Kelson
65bb979b51
Merge pull request #3778 from kiwix/Fix#3776
Added information about JDK configuration to the README file.
2024-04-04 07:16:13 +02:00
MohitMaliFtechiz
45be2860bb Added information about JDK configuration to the README file.
* Our project requires `Java 11` to run. Therefore, developers should set the `Gradle JDK` to `Java 11`. We have included this information in the `Build Instructions` section of the `README` file.
2024-04-04 07:16:03 +02:00
Kelson
f0af00b7f2
Merge pull request #3773 from kiwix/Fix#3647
Fixed: Spurious message: "Error: Loading article (Url: https://uploadwikimedia.org/wikipedia/commons/6/65/Lock-green.svg"
2024-04-04 07:14:04 +02:00
MohitMaliFtechiz
3820fee220 Fixed: Spurious message: "Error: Loading article (Url: https://upload.wikimedia.org/wikipedia/commons/6/65/Lock-green.svg"
* The error toast message is no longer displayed if a URL fails to load. Instead, a debug error message is logged.
* Restricting the loading of external resources when rendering the pages.
2024-04-04 07:13:46 +02:00
Kelson
fd9b39baa4
Merge pull request #3768 from kiwix/Fix#3755
Fixed: Processing of special characters / URL encoded links is not working as expected.
2024-04-04 07:13:03 +02:00
MohitMaliFtechiz
36d0c1193b Improved adding the query params in the URL only for those URLs that has the query params.
* Removing the URL decoding to verify whether the query string is present in the URL or not. This is because we only need to append the query string for URLs that contain "?", not for those containing "%3F" (indicating direct paths to ZIM entries). We decoded the URL to evaluate this condition, which inadvertently added "?" at the end of the URL unnecessarily. This is redundant as we extract the query string only after "?", and encoded URLs do not include "?".
* Added more test cases for all the scenarios.
2024-04-04 07:12:24 +02:00
MohitMaliFtechiz
4d29224881 Fixed: Processing of special characters / URL encoded links is not working as expected.
* Now our application is processing URL like kiwix-server.
* Added a test case for testing few scenarios of special characters/URL encoded.
2024-04-04 07:12:24 +02:00
Kelson
937876648f
Merge pull request #3771 from kiwix/Fix#3769
Fixed: Improved the creation of logDirectory on lower devices (Below Android 10).
2024-04-04 07:11:39 +02:00
MohitMaliFtechiz
47e371e5ba Fixed: Improved the creation of logDirectory on lower devices (Below Android 10).
* Efficiently creating the log file directory so that it will work on every Android version.
2024-04-02 16:52:45 +05:30
Sagar
43474734e4 #3764 Added ripple into FIND IN PAGE 2024-04-01 19:56:15 +05:30