8300 Commits

Author SHA1 Message Date
Kelson
7400c26c8f
Merge pull request #4015 from kiwix/Fixes#4008
Fixed: In Samsung tablet of Android 14, downloaded files can not be opened via file picker or deep linking in non-PS variant.
2024-10-30 07:25:53 +01:00
MohitMaliFtechiz
946b5cc260 Improved the getFilePathWithFolderFromUri, and getFullFilePathFromFilePath methods to properly resolve the other folders uri. 2024-10-30 07:25:37 +01:00
MohitMaliFtechiz
96e9b8913f Improved the getFullFilePathFromFilePath method to not return the filePath for null fileNames. 2024-10-30 07:25:37 +01:00
MohitMaliFtechiz
b4bb0f98c8 Fixed the issue where files would not open on Huawei phones when directly accessed from the file manager.
* Improved the method for resolving content type URIs to properly return the file path of the selected URI.
* Refined the code and methods for improved clarity in their operations.
2024-10-30 07:25:37 +01:00
MohitMaliFtechiz
777c0fff4b Fixed: In Samsung tablet of Android 14, downloaded files can not be opened via file picker or deep linking.
* When we open a file from different browsers, they provide a URI through their own file provider, and the content resolver cannot retrieve the file path for these types of URIs. To fix this issue, we have introduced a fallback method that returns the exact path of the file located in the Downloads folder.
* Another issue we encountered on tablets is that the URIs are different from those on regular mobile devices, and our `documentProviderContentQuery` method could not return the path for these types of URIs from the Downloads folder. To fix this issue, we used our fallback method to retrieve the file path for these URIs.
2024-10-30 07:25:37 +01:00
Kelson
eaa28d66df
Merge pull request #4042 from kiwix/Fixes#4005
Fixed: "Send diagnostic report" function should open the user's email client.
2024-10-24 13:26:52 +02:00
MohitMaliFtechiz
61dd97ce9a Attaching the device logs in the email body instead of as a file.
* We cannot attach a file to the email when using the `ACTION_SENDTO` action in the intent. However, we must use this intent action because it is the only one handled exclusively by email apps. This ensures that only email apps appear in the suggestions.
2024-10-22 10:57:24 +05:30
MohitMaliFtechiz
e12387e256 Fixed: "Send diagnostic report" function should open the user's email client.
* Previously, other apps were appearing in the suggestions when sending the diagnostic report. We have improved our intent so that it now directly opens the user's email client to send the diagnostic report to us.
2024-10-22 10:52:32 +05:30
Kelson
9954193fed
Merge pull request #4040 from kiwix/Fixes#4039
Fixed: Move `canReadFile()` method to IO thread.
2024-10-21 15:52:17 +02:00
MohitMaliFtechiz
9861133662 Clearing the webView list to avoid loading previous ZIM file URLs if we open a new ZIM file in the reader. 2024-10-21 14:29:11 +05:30
MohitMaliFtechiz
d46a850c44 Fixed: sometimes a native crash happens when opening new ZIM files in the reader. 2024-10-21 12:19:39 +05:30
MohitMaliFtechiz
b834e62b6a Fixed: OpenSearchItemTest was failing after fixing the search functionality. 2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
c7f8d99eb0 Fixed: Search was not working properly, it always showing the current loaded page when we click on any searched item. 2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
ecbf1b3813 Fixed: books deletes entities whose file does not exist failing. 2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
c97cf0725d Fixed: test search cancellation sometimes failing in CI. 2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
22daa3d86f Reintroduced the fallback method for searched items. 2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
78e265b942 Fixed an issue where bookmarks would not open for a ZIM file if another ZIM file was already opened in the reader. Instead of opening the bookmarked page, it always opens the home page of the current ZIM file. 2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
31bb875d87 Removed the unused ZimReaderContainerUtils.kt class.
* Refactored some unnecessary code.
2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
656a64df32 Improved the search functionality of our application:
* The article URL was already available in the searchState, but we were redundantly retrieving the article URL from the pageTitle, resulting in an unnecessary extra call to libkiwix. To optimize this, we now directly use the URL provided by libkiwix for the searched item, reducing the extra call.
2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
a7f662fe45 Fixed: The search fragment test was failing in both the custom and app modules due to a socket exception during the ZIM file download. 2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
5c25b20ad7 Fixed: DonationDialogHandlerTest. 2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
01320a563e Improved the refreshing of bookmarks after adding, deleting.
* Fixed the test cases.
2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
93a01e5c29 Fixed: NewBookDaoTest, and DonationDialogHandlerTest.
* Improved the saving of bookmarks.
2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
13014db1a1 Fixed EncodedUrlTest, LibkiwixBookmarkTest, MimeTypeTest, and ZimFileReaderWithSplittedZimFileTest. 2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
33bd3397e3 Fixed: Move canReadFile() method to IO thread.
* Moved the file readability check to the IO thread to prevent ANR.
* Refactored the code to accommodate this change.
2024-10-21 10:55:12 +05:30
Kelson
5ceb3ceccb
Merge pull request #4030 from kiwix/Fixes#4029
Generated a dummy bundle to manually upload it to the playStore via CI.
2024-10-18 15:59:48 +02:00
MohitMaliFtechiz
da3654426e Generated a dummy bundle to manually upload it to the playStore via CI.
* We have created a dummy_bundle.yml file that will trigger on the dummy_bundle tag and generate the app bundle, which can be uploaded to the Play Store or used in other scenarios.
2024-10-18 15:53:56 +02:00
Kelson
ad6d2c6339
Merge pull request #4007 from kiwix/Fixes#4000
Fixed: Medical wikimedia (mini) keeps crashing.
2024-10-18 15:53:37 +02:00
MohitMaliFtechiz
c3d9bb74f7 Added the test cases for CustomFileValidator with edge cases. 2024-10-18 15:18:42 +02:00
MohitMaliFtechiz
e25f0f0aad Added unit test cases for testing this scenario to avoid this type of errors in future. 2024-10-18 15:18:42 +02:00
MohitMaliFtechiz
5f898be238 Fixed: Medical wikimedia (mini) keeps crashing.
* This issue occurred when we tried to access ZIM files from the application’s folder in the `zimFiles()` method. In this method, we add directories to a non-null list of files. However, when attempting to retrieve the list of files from the application directory, the SD card path was null due to the SD card being unmounted, which caused the application to crash.
* To fix this, we have improved our `zimFiles()` and `obbFiles()` methods to return only existing, non-null directories. This ensures proper handling of file system detection, so if a directory is unavailable or returns null, these methods handle it appropriately.
2024-10-18 15:18:42 +02:00
Kelson
f307700236
Merge pull request #4027 from kiwix/Fixes#4026
Removed the `Hotspot` feature from custom apps, and used the normal service instead of foreground service for `readAloud` feature.
2024-10-18 15:17:27 +02:00
MohitMaliFtechiz
f32d0d6e5b Now we are using normal service instead of foreground service for readAloud feature.
* Since the `readAloud` feature only runs when the reader screen is active if we move to another screen, or close the application then `readAloud` stops so we do not need to use the foreground service for this.
2024-10-18 10:52:02 +05:30
MohitMaliFtechiz
9f7af51788 Refactored the test cases according to our this change. 2024-10-15 22:52:20 +02:00
MohitMaliFtechiz
02d732f763 Corrected the comments. 2024-10-15 22:52:20 +02:00
MohitMaliFtechiz
2bea9be589 Reverted the permission. 2024-10-15 22:52:20 +02:00
MohitMaliFtechiz
06ae81b8b0 Refactored the remaining code to remove the Hotspot feature from custom app. 2024-10-15 22:52:20 +02:00
MohitMaliFtechiz
4cb8776644 Re-enabled the WifiHotspot for app only and removed this for custom apps. 2024-10-15 22:52:20 +02:00
MohitMaliFtechiz
820c455d75 Changed the HotspotService type to dataSync. 2024-10-15 22:52:20 +02:00
MohitMaliFtechiz
c6ed1a91d0 Fixed: "Publish App to playStore" task failed to upload the application on PlayStore. 2024-10-15 22:52:20 +02:00
Kelson
bad8f4c716
Merge pull request #4034 from kiwix/Fixes#4031
Fixed: Application crashing due to `Input dispatching timed out` when deleting the ZIM files.
2024-10-15 18:14:17 +02:00
MohitMaliFtechiz
79a61e330d Fixed CopyMoveFileHandlerTest failing. 2024-10-15 15:38:26 +05:30
MohitMaliFtechiz
a839b8d40c Improved the deleting logic of files.
* Removed the unused code from FileUtils class.
2024-10-15 15:37:19 +05:30
MohitMaliFtechiz
676056a89f Fixed the compilation error in CopyMoveFileHandlerTest. 2024-10-15 15:37:12 +05:30
MohitMaliFtechiz
7e8658bb83 Fixed: Application crashing due to Input dispatching timed out when deleting the ZIM files.
* Moved the file deleting logic on IO thread, and refactored our code according to this change.
2024-10-15 15:37:04 +05:30
Kelson
9c2b355f65
Merge pull request #4033 from kiwix/Fixes#4032
Upgraded the `java-libkiwix` to `2.2.3` to start using the `libkiwix14`.
2024-10-15 11:32:18 +02:00
MohitMaliFtechiz
0dc7224c2a Upgraded the java-libkiwix to 2.2.3 to start using the libkiwix14. 2024-10-15 09:48:11 +05:30
Kelson
ff42e9f09a
Merge pull request #4025 from kiwix/Fixes#4024
Fixed: `app:theme` is now deprecated. Please move to using `android:theme` instead.
2024-10-10 09:31:38 +02:00
MohitMaliFtechiz
c2bacd6c41 Little improvement in DownloadTest, since we are downloading the smallest ZIM file so it can be downloaded immediately after starting, so in this case, do not fail the test case. Since we are testing the pause/resume functionality in our other DownloadTest. 2024-10-10 12:11:33 +05:30
MohitMaliFtechiz
3e52a897cd Fixed: app:theme is now deprecated. Please move to using android:theme instead.
* Now we are using the `android:theme` everywhere in our project instead of `app:theme`.
2024-10-10 11:56:22 +05:30