1964 Commits

Author SHA1 Message Date
Abdul Wadood
6e36bd95d0 Add onboarding screens 2018-06-19 16:23:03 +01:00
Siddharth Sharma
f47bd50f37 Unit Test the Database (#758)
* Add TODOs for BookDatabaseTest

* minor change to BookDatabaseTest

* add TODOs for BookmarksDatabaseTest

* add TODOs for BookmarksDatabaseTest

* Add TODOs for networkLanguageDatabaseTest

* add TODOs for RecentSearchDatabaseTest

* Approach not working. new attempt required

* stuck trying to access the database using overridden mocked DAO class. New way to do the stuff

* able to access the database

* two conflicting databases created. need to fix

* fix a bug due to pass by value and not by reference

* remove redundant code

* separate the internal logic and the DAO wrapper in BookDao class

* intial draft working

* create test for BookDao.getBooks()

test has minor bug that needs to be rectified

* internal BookDao methods returning null values during testing. needs to be fixed

* Add TODOs for testing utils/files/FileUtils

* Add tests for utils/files/FileUtils.java

* Add tests for RecentSearchDatabaseTest

* fix travis build failure

the file NetworkLanguageDatabase test contains no test and is deleted

* Add comments to RecentSearchDatabaseTest

* minor formatting changes

* delete FileUtilsTest

* changed access type of methods as private

* delete extra unnecessary code

* need to fix a powermock bug

* fix the file.exists() error

* totally fix the file.exists() issue

* fix the File.exists() issue

* update Databas tests

* commenting all code and checking whether travis passes

* fix all travis build errors

* improve the test structure

* update tests

* remove unused import statements

* fix spacing

* comment test to find bug

* test if build works
2018-06-15 16:52:02 +01:00
Siddharth Sharma
c97420cd04 make code more uniform
insert the path of the temporary directory inside the base path itself instead of adding it every time a new file has to be created
2018-06-14 23:46:08 +01:00
Siddharth Sharma
e3e901671f Remove commented code 2018-06-14 23:46:08 +01:00
siddharth2010
f13a3e29da fix spaces 2018-06-14 23:46:08 +01:00
siddharth2010
56b3d6104b remove commented code 2018-06-14 23:46:08 +01:00
siddharth2010
a6b8fd751c fix indentation and spacing 2018-06-14 23:46:08 +01:00
siddharth2010
40083ffc8c update the logic to delete all the temporary files 2018-06-14 23:46:08 +01:00
siddharth2010
0edc4078fe FIX EVERYTHING. tests running perfectly 2018-06-14 23:46:08 +01:00
siddharth2010
f5995ea7b8 Files not being deleted at the end of the test
Also. the test works perfectly in the first attempt, but after that it continuously fails each and everytime. This is expected because of the files that were created and not deleted
2018-06-14 23:46:08 +01:00
siddharth2010
1419522344 complete test. need to fix a bug 2018-06-14 23:46:08 +01:00
siddharth2010
be5b820d28 Add the basic test 2018-06-14 23:46:08 +01:00
siddharth2010
819bd77523 test for getAllZimParts complete. need to fix a small bug 2018-06-14 23:46:08 +01:00
siddharth2010
08bca7507b create first draft of the instrumentation test 2018-06-14 23:46:08 +01:00
siddharth2010
0d17268444 Add instrumentation test for FileUtils 2018-06-14 23:46:08 +01:00
siddharth2010
e6a26f541c final commit 2018-06-14 23:46:08 +01:00
siddharth2010
5c92e20b06 fix the bug with powermock code
the code was not working as the file was being instantiated inside another class. So I have to find another method to mock the file.exists method in here.
2018-06-14 23:46:08 +01:00
siddharth2010
99772598aa unable to fix powerMock issue 2018-06-14 23:46:08 +01:00
siddharth2010
066700bd46 need to fix bug in last test case 2018-06-14 23:46:08 +01:00
siddharth2010
67388ddd56 Test all base cases in FileUtils.getAllZimParts 2018-06-14 23:46:08 +01:00
siddharth2010
9fb27f52ad fix powermock bug 2018-06-14 23:46:08 +01:00
siddharth2010
60b9d173d9 Need to fix bug in powermock code 2018-06-14 23:46:08 +01:00
siddharth2010
689e98563b convert the FileUtils instrumentation test into a unit test 2018-06-14 23:46:08 +01:00
siddharth2010
1af0d11f86 Add TODOs for FileUtilsTest 2018-06-14 23:46:08 +01:00
siddharth2010
d0a034a65e Add tests for FileUtilsTest 2018-06-14 23:46:08 +01:00
siddharth2010
e2558af84a remove unused imports and check indentation 2018-06-14 23:46:08 +01:00
siddharth2010
0184e5adfe complete testing ChunkUtils 2018-06-14 23:46:08 +01:00
siddharth2010
443fb855d4 Add PowerMock to the project 2018-06-14 23:46:08 +01:00
siddharth2010
4a453dfe40 Add tests for downloader/ChunkUtils 2018-06-14 23:46:08 +01:00
Abdul Wadood
f44b949b86 Add app shortcuts 2018-06-05 23:04:01 +01:00
siddharth2010
4ff6bc60f1 Fix Codestyle: Add spaces after commas 2018-06-04 19:19:12 +01:00
siddharth2010
5759207fbe delete StyleUtilsTest
StyleUtilsTest does not have any internal logic to be tested and so unit tests for it are not needed
2018-06-04 19:19:12 +01:00
siddharth2010
8bbb8bf7a4 Add TODOs for StyleUtilsTest 2018-06-04 19:19:12 +01:00
siddharth2010
dea45194e9 Add BookUtilsTest 2018-06-04 19:19:12 +01:00
siddharth2010
a2ee79da52 add test for utils/DimenUtils 2018-06-04 19:19:12 +01:00
siddharth2010
995d69297d add test for utils/NetworkUtils 2018-06-04 19:19:12 +01:00
siddharth2010
97958665bd add test for zim_manager/library_view/LibraryUtils 2018-06-04 19:19:12 +01:00
Abdul Wadood
05ca65f525 Add BaseContract 2018-05-30 23:24:11 +01:00
Abdul Wadood
0691ac5e5b Move SplashActivity to splash package 2018-05-30 23:24:11 +01:00
Abdul Wadood
2bd4b8988a Rename KiwixErrorActivity to ErrorActivity and move it to error package 2018-05-30 23:24:11 +01:00
Abdul Wadood
974ec85da9 Move ZimContentProvider to data package 2018-05-30 23:24:11 +01:00
Abdul Wadood
0a45040747 Remove views package.
Move classes to their respective package.
2018-05-30 23:24:11 +01:00
Abdul Wadood
d052b0bfd6 Rename bookmarks_view package to bookmark 2018-05-30 23:24:11 +01:00
Abdul Wadood
18f06d8f27 Make local and remote data sources 2018-05-30 23:24:11 +01:00
Abdul Wadood
9845985099 Rename KiwixMobileActivity to MainActivity and move it to main package 2018-05-30 23:24:11 +01:00
mhutti1
ac59840bcd Remove stack exchange zim files from remote library 2018-05-20 14:55:50 +01:00
Brijesh Shah
51d241bfc4 Fix: App directly minimizes on back pressed in Find in page (#673) 2018-04-28 00:06:57 +01:00
Arpan Konar
0585c4f68f Fixed stopped download restart on restarting app and line continuations spacing (#450) 2018-04-21 02:02:15 +01:00
Abdul Wadood
d7fae9b66b Add dependency injection in KiwixErrorActivity 2018-04-21 01:46:45 +01:00
Julian Harty
00c10762a3 A minor fix that was uncovered by running our automated tests on devices
without an internet connection (but WiFi had networks available).

I mimiced the behaviour of the lines earlier in the method. It might be
worth revising the code soon as it's not entirely accurate these days.

https://github.com/kiwix/kiwix-android/issues/722
2018-04-21 01:43:09 +01:00