Kelson
9954193fed
Merge pull request #4040 from kiwix/Fixes#4039
...
Fixed: Move `canReadFile()` method to IO thread.
2024-10-21 15:52:17 +02:00
MohitMaliFtechiz
9861133662
Clearing the webView list to avoid loading previous ZIM file URLs if we open a new ZIM file in the reader.
2024-10-21 14:29:11 +05:30
MohitMaliFtechiz
d46a850c44
Fixed: sometimes a native crash happens when opening new ZIM files in the reader.
2024-10-21 12:19:39 +05:30
MohitMaliFtechiz
b834e62b6a
Fixed: OpenSearchItemTest was failing after fixing the search functionality.
2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
c7f8d99eb0
Fixed: Search was not working properly, it always showing the current loaded page when we click on any searched item.
2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
ecbf1b3813
Fixed: books deletes entities whose file does not exist failing.
2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
c97cf0725d
Fixed: test search cancellation sometimes failing in CI.
2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
22daa3d86f
Reintroduced the fallback method for searched items.
2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
78e265b942
Fixed an issue where bookmarks would not open for a ZIM file if another ZIM file was already opened in the reader. Instead of opening the bookmarked page, it always opens the home page of the current ZIM file.
2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
31bb875d87
Removed the unused ZimReaderContainerUtils.kt class.
...
* Refactored some unnecessary code.
2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
656a64df32
Improved the search functionality of our application:
...
* The article URL was already available in the searchState, but we were redundantly retrieving the article URL from the pageTitle, resulting in an unnecessary extra call to libkiwix. To optimize this, we now directly use the URL provided by libkiwix for the searched item, reducing the extra call.
2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
a7f662fe45
Fixed: The search fragment test was failing in both the custom and app modules due to a socket exception during the ZIM file download.
2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
5c25b20ad7
Fixed: DonationDialogHandlerTest.
2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
01320a563e
Improved the refreshing of bookmarks after adding, deleting.
...
* Fixed the test cases.
2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
93a01e5c29
Fixed: NewBookDaoTest, and DonationDialogHandlerTest.
...
* Improved the saving of bookmarks.
2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
13014db1a1
Fixed EncodedUrlTest, LibkiwixBookmarkTest, MimeTypeTest, and ZimFileReaderWithSplittedZimFileTest.
2024-10-21 10:55:12 +05:30
MohitMaliFtechiz
33bd3397e3
Fixed: Move canReadFile() method to IO thread.
...
* Moved the file readability check to the IO thread to prevent ANR.
* Refactored the code to accommodate this change.
2024-10-21 10:55:12 +05:30
Kelson
5ceb3ceccb
Merge pull request #4030 from kiwix/Fixes#4029
...
Generated a dummy bundle to manually upload it to the playStore via CI.
2024-10-18 15:59:48 +02:00
MohitMaliFtechiz
da3654426e
Generated a dummy bundle to manually upload it to the playStore via CI.
...
* We have created a dummy_bundle.yml file that will trigger on the dummy_bundle tag and generate the app bundle, which can be uploaded to the Play Store or used in other scenarios.
2024-10-18 15:53:56 +02:00
Kelson
ad6d2c6339
Merge pull request #4007 from kiwix/Fixes#4000
...
Fixed: Medical wikimedia (mini) keeps crashing.
2024-10-18 15:53:37 +02:00
MohitMaliFtechiz
c3d9bb74f7
Added the test cases for CustomFileValidator with edge cases.
2024-10-18 15:18:42 +02:00
MohitMaliFtechiz
e25f0f0aad
Added unit test cases for testing this scenario to avoid this type of errors in future.
2024-10-18 15:18:42 +02:00
MohitMaliFtechiz
5f898be238
Fixed: Medical wikimedia (mini) keeps crashing.
...
* This issue occurred when we tried to access ZIM files from the application’s folder in the `zimFiles()` method. In this method, we add directories to a non-null list of files. However, when attempting to retrieve the list of files from the application directory, the SD card path was null due to the SD card being unmounted, which caused the application to crash.
* To fix this, we have improved our `zimFiles()` and `obbFiles()` methods to return only existing, non-null directories. This ensures proper handling of file system detection, so if a directory is unavailable or returns null, these methods handle it appropriately.
2024-10-18 15:18:42 +02:00
Kelson
f307700236
Merge pull request #4027 from kiwix/Fixes#4026
...
Removed the `Hotspot` feature from custom apps, and used the normal service instead of foreground service for `readAloud` feature.
2024-10-18 15:17:27 +02:00
MohitMaliFtechiz
f32d0d6e5b
Now we are using normal service instead of foreground service for readAloud feature.
...
* Since the `readAloud` feature only runs when the reader screen is active if we move to another screen, or close the application then `readAloud` stops so we do not need to use the foreground service for this.
2024-10-18 10:52:02 +05:30
MohitMaliFtechiz
9f7af51788
Refactored the test cases according to our this change.
2024-10-15 22:52:20 +02:00
MohitMaliFtechiz
02d732f763
Corrected the comments.
2024-10-15 22:52:20 +02:00
MohitMaliFtechiz
2bea9be589
Reverted the permission.
2024-10-15 22:52:20 +02:00
MohitMaliFtechiz
06ae81b8b0
Refactored the remaining code to remove the Hotspot feature from custom app.
2024-10-15 22:52:20 +02:00
MohitMaliFtechiz
4cb8776644
Re-enabled the WifiHotspot for app only and removed this for custom apps.
2024-10-15 22:52:20 +02:00
MohitMaliFtechiz
820c455d75
Changed the HotspotService type to dataSync.
2024-10-15 22:52:20 +02:00
MohitMaliFtechiz
c6ed1a91d0
Fixed: "Publish App to playStore" task failed to upload the application on PlayStore.
2024-10-15 22:52:20 +02:00
Kelson
bad8f4c716
Merge pull request #4034 from kiwix/Fixes#4031
...
Fixed: Application crashing due to `Input dispatching timed out` when deleting the ZIM files.
2024-10-15 18:14:17 +02:00
MohitMaliFtechiz
79a61e330d
Fixed CopyMoveFileHandlerTest failing.
2024-10-15 15:38:26 +05:30
MohitMaliFtechiz
a839b8d40c
Improved the deleting logic of files.
...
* Removed the unused code from FileUtils class.
2024-10-15 15:37:19 +05:30
MohitMaliFtechiz
676056a89f
Fixed the compilation error in CopyMoveFileHandlerTest.
2024-10-15 15:37:12 +05:30
MohitMaliFtechiz
7e8658bb83
Fixed: Application crashing due to Input dispatching timed out when deleting the ZIM files.
...
* Moved the file deleting logic on IO thread, and refactored our code according to this change.
2024-10-15 15:37:04 +05:30
Kelson
9c2b355f65
Merge pull request #4033 from kiwix/Fixes#4032
...
Upgraded the `java-libkiwix` to `2.2.3` to start using the `libkiwix14`.
2024-10-15 11:32:18 +02:00
MohitMaliFtechiz
0dc7224c2a
Upgraded the java-libkiwix to 2.2.3 to start using the libkiwix14.
2024-10-15 09:48:11 +05:30
Kelson
ff42e9f09a
Merge pull request #4025 from kiwix/Fixes#4024
...
Fixed: `app:theme` is now deprecated. Please move to using `android:theme` instead.
2024-10-10 09:31:38 +02:00
MohitMaliFtechiz
c2bacd6c41
Little improvement in DownloadTest, since we are downloading the smallest ZIM file so it can be downloaded immediately after starting, so in this case, do not fail the test case. Since we are testing the pause/resume functionality in our other DownloadTest.
2024-10-10 12:11:33 +05:30
MohitMaliFtechiz
3e52a897cd
Fixed: app:theme is now deprecated. Please move to using android:theme instead.
...
* Now we are using the `android:theme` everywhere in our project instead of `app:theme`.
2024-10-10 11:56:22 +05:30
Kelson
83899c61c4
Merge pull request #4012 from kiwix/Fixes#3736
...
Fixed: The donation popup does not look well in tablet.
2024-10-08 06:06:09 +00:00
MohitMaliFtechiz
300f681156
Fixed: The donation popup does not look well in tablet.
...
* Added a maximum width for large screen devices such as tablets. If the device has a large screen, the donation popup will be set to the maximum width, ensuring a consistent appearance similar to mobile phones.
2024-10-07 14:29:42 +05:30
Kelson
fc1b8ddccd
Merge pull request #4013 from kiwix/Fixes#4004
...
Removed the "Send feedback" option from Help tab.
2024-10-06 18:19:37 +00:00
MohitMaliFtechiz
6b12e4413f
Removed the "Send feedback" option from Help tab.
...
* Removed the all code related to this feature e.g. icon, strings, etc.
* Refactored the HelpFragmentTest.
2024-10-06 15:44:07 +00:00
Kelson
ce78712b21
Merge pull request #4017 from kiwix/Fixes#4016
...
Added the `foregroundServiceType` in manifest for `ReadAloudService`, and `HotspotService`.
2024-10-06 15:43:50 +00:00
MohitMaliFtechiz
1a0cb84917
Added the foregroundServiceType in manifest for ReadAloudService, and HotspotService.
2024-10-06 14:59:07 +00:00
Kelson
e6510f139c
Merge pull request #4019 from kiwix/Fixes#4001
...
Fixed: CI sometimes stuck on instrumentation test cases.
2024-10-06 14:58:47 +00:00
MohitMaliFtechiz
4c79c1066b
Re-enabled the testing of pause/resume functionality in DownloadTest.
2024-10-05 16:49:48 +00:00
