Merge pull request #109 from kiwix/108-fix-app-name-labels

Use app_name as the build target name, to fix macOS app naming

README.md

@@ -28,7 +28,7 @@ existing one if you need to create a new custom app.
 ### The required fields are:
 - `about_app_url` - this is an external link that is placed in the "About section" of the application. (Eg. "https://www.dwds.de")
 - `about_text` - this is a custom text that is placed in the "About section" describing what the application is about. It is not supporting html tags, but new lines can be added with '\n'.
-- `app_name` - Name of the app, as it will appear on device under the icon (the [CFBundleDisplayName](https://developer.apple.com/documentation/bundleresources/information-property-list/cfbundledisplayname)).
+- `app_name` - Name of the app, as it will appear on device under the icon (the [CFBundleDisplayName](https://developer.apple.com/documentation/bundleresources/information-property-list/cfbundledisplayname)). Additionally it will be used as the projects $(PRODUCT_NAME) variable. This makes sure that the app_name appears on macOS in the about section, in the top menu bar.
 - `app_store_id` - this should to be taken from the developer.apple.com, where the application release is prepared. Note you can use the app_store_id even if the app is not yet released. You can find this by visiting: https://appstoreconnect.apple.com/apps/, selecting your app, and go to General tab (on the left), and it will be under AppleID. The id is used within the app in the "Rate the app" section, so users can be redirected to a specific app in the App Store, to rate it. it is a sequence of numbers usually, although for the json file we need to append "id" to it. Eg.: "1281693200" becomes "id1281693200".
 - `development_team` - this is the development team id used for the build, it can be found in the relevant Apple Development Account (for apps under the Kiwix organisation it will be the same value: L7HWM3SP3L). You can find your team id in the upper right corner of the screen (after you login to) your [Apple Developer Account](https://developer.apple.com/account/resources/certificates/list).
 - `enforced_lang` - ISO 639-1 language code (eg: en, de, he) if it is set, it will include only this language in the final app, meaning no other languages can be selected (on iOS) for the application UI. See the current list of supported languages [already translated in the main repo](https://github.com/kiwix/kiwix-apple/tree/main/Support). When using this option, make sure that [the translation coverage](https://translatewiki.net/wiki/Special:MessageGroupStats/kiwix-apple?group=kiwix-apple&messages=&suppressempty=1&x=D) is 100% for the enforced language.

src/info_parser.py

@@ -60,7 +60,7 @@ class InfoParser:
             # handle Background mode audio:
             if self.uses_audio == False:
                 plist[PLIST_KEY_BACKGROUND_MODES].remove("audio")
-            
+
             # remove live activity for custom apps:
             plist.pop(PLIST_KEY_LIVE_ACTIVITY, None)
             plist.pop(PLIST_KEY_LIVE_ACTIVITY_FREQUENT, None)
@@ -78,12 +78,13 @@ class InfoParser:
         dict = {
             "templates": ["ApplicationTemplate"],
             "settings": {"base": {
-                "MARKETING_VERSION": self.version.semantic, 
+                "MARKETING_VERSION": self.version.semantic,
                 "PRODUCT_BUNDLE_IDENTIFIER": self._bundle_id(),
                 "INFOPLIST_FILE": f"custom/{self._info_plist_path()}",
                 "INFOPLIST_KEY_CFBundleDisplayName": self._app_name(),
                 "INFOPLIST_KEY_UILaunchStoryboardName": "SplashScreen.storyboard",
                 "DEVELOPMENT_LANGUAGE": self._dev_language(),
+                "PRODUCT_NAME": self._app_name(),
                 # without specifying DEVELOPMENT_LANGUAGE,
                 # the default value of it: English will be added to the list of
                 # selectable languages in iOS Settings,
@@ -121,7 +122,7 @@ class InfoParser:
             return os.getenv(auth_key)
         else:
             return None
-        
+
     def _bundle_id(self):
         if JSON_BUNDLE_ID in self.data:
             return self.data[JSON_BUNDLE_ID]
@@ -140,7 +141,7 @@ class InfoParser:
 
     def _app_name(self):
         return self.data[JSON_KEY_APP_NAME]
-    
+
     def _development_team(self):
         return self.data[JSON_KEY_DEVELOPMENT_TEAM]