kiwix/kiwix-apple-custom
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-apple-custom.git synced 2025-08-03 18:46:07 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove downgraded versioning

Browse Source
This commit is contained in:
Balazs Perlaki-Horvath 2024-01-15 01:22:24 +01:00
parent aaf4ddf185
commit b2b59b9afc
4 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/info_parser.py
View File

@ -57,7 +57,7 @@ class InfoParser:
"templates": ["ApplicationTemplate"],
"settings": {"base": {
# TODO: change to .semantic, once builds are OK
"MARKETING_VERSION": self.version.semantic_downgraded,
"MARKETING_VERSION": self.version.semantic,
"PRODUCT_BUNDLE_IDENTIFIER": self._bundle_id(),
"INFOPLIST_FILE": f"custom/{self._info_plist_path()}",
"INFOPLIST_KEY_CFBundleDisplayName": self._app_name(),

2
src/tag_validator.py
View File

@ -42,7 +42,7 @@ def _is_valid(tag):
# save the specific parts of the tag as temp files:
Path('.brand_name').write_text(f"{brand.name}")
Path('.build_number').write_text(f"{version.build_number}")
Path('.version_number').write_text(f"{version.semantic_downgraded}")
Path('.version_number').write_text(f"{version.semantic}")
# required as an output, we can pipe on:
print(f"{brand.name} {version.build_number}")

1
src/version.py
View File

@ -14,7 +14,6 @@ class Version:
raise ValueError(f"invalid year: {year}")
self.semantic = f"{year}.{month}.{build_number}"
self.semantic_downgraded = f"{year-1000}.{month}.{build_number}"
self.build_number = build_number
@classmethod

4
tests/version_test.py
View File

@ -8,19 +8,15 @@ class VersionTest(unittest.TestCase):
version = Version.from_file_name(
"dwds_de_dictionary_nopic_2023-11-20", build_number=10)
self.assertEqual(version.semantic, "2023.11.10")
self.assertEqual(version.semantic_downgraded, "1023.11.10")
version = Version.from_file_name(
"dwds_de_dictionary_nopic_2023-09-20", build_number=0)
self.assertEqual(version.semantic, "2023.9.0")
self.assertEqual(version.semantic_downgraded, "1023.9.0")
version = Version.from_file_name(
"dwds_de_dictionary_nopic_2023-01", build_number=7)
self.assertEqual(version.semantic, "2023.1.7")
self.assertEqual(version.semantic_downgraded, "1023.1.7")
version = Version.from_file_name(
"dwds_de_dictionary_nopic_2023-12", build_number=129)
self.assertEqual(version.semantic, "2023.12.129")
self.assertEqual(version.semantic_downgraded, "1023.12.129")