From 10df30b6340ae7fa2fc0eec663ce9cf322a0cac3 Mon Sep 17 00:00:00 2001 From: Balazs Perlaki-Horvath Date: Sun, 17 Mar 2024 01:03:52 +0100 Subject: [PATCH 1/2] Add bookmark functionality without long-press --- Views/Buttons/BookmarkButton.swift | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/Views/Buttons/BookmarkButton.swift b/Views/Buttons/BookmarkButton.swift index 5b24b7bb..72c96a05 100644 --- a/Views/Buttons/BookmarkButton.swift +++ b/Views/Buttons/BookmarkButton.swift @@ -71,6 +71,23 @@ struct BookmarkButton: View { Text("common.button.done".localized).fontWeight(.semibold) } } + ToolbarItem(placement: .navigationBarTrailing) { + Button { + if browser.articleBookmarked { + browser.deleteBookmark() + } else { + browser.createBookmark() + } + } label: { + Label { + Text(browser.articleBookmarked ? + "common.dialog.button.remove_bookmark".localized : "common.dialog.button.add_bookmark".localized) + } icon: { + Image(systemName: browser.articleBookmarked ? "star.fill" : "star") + .renderingMode(browser.articleBookmarked ? .original : .template) + } + }.disabled(browser.url == nil) + } } } .frame(idealWidth: 360, idealHeight: 600) From 8c2032bc8d8067d6df2dbadffa39f71bc82124d1 Mon Sep 17 00:00:00 2001 From: Balazs Perlaki-Horvath Date: Sun, 17 Mar 2024 01:05:27 +0100 Subject: [PATCH 2/2] Fixlint --- Views/Buttons/BookmarkButton.swift | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Views/Buttons/BookmarkButton.swift b/Views/Buttons/BookmarkButton.swift index 72c96a05..3a568d9a 100644 --- a/Views/Buttons/BookmarkButton.swift +++ b/Views/Buttons/BookmarkButton.swift @@ -80,8 +80,11 @@ struct BookmarkButton: View { } } label: { Label { - Text(browser.articleBookmarked ? - "common.dialog.button.remove_bookmark".localized : "common.dialog.button.add_bookmark".localized) + Text( + browser.articleBookmarked ? + "common.dialog.button.remove_bookmark".localized : + "common.dialog.button.add_bookmark".localized + ) } icon: { Image(systemName: browser.articleBookmarked ? "star.fill" : "star") .renderingMode(browser.articleBookmarked ? .original : .template)