kiwix/kiwix-apple
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-apple.git synced 2025-09-24 04:03:03 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #873 from kiwix/871-search-snippet-setting-is-outdated

Browse Source 
Change search snippet in setting to be a toggle
This commit is contained in:
Kelson 2024-07-20 12:21:47 +02:00 committed by GitHub
commit 86a037c4b2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 19 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
Views/Settings/Settings.swift
View File

@ -24,6 +24,14 @@ struct ReadingSettings: View {
@Default(.webViewPageZoom) private var webViewPageZoom
var body: some View {
let isSnippet = Binding {
switch searchResultSnippetMode {
case .matches: return true
case .disabled: return false
}
} set: { isOn in
searchResultSnippetMode = isOn ? .matches : .disabled
}
VStack(spacing: 16) {
SettingSection(name: "reading_settings.zoom.title".localized) {
HStack {
@ -45,11 +53,7 @@ struct ReadingSettings: View {
}
if FeatureFlags.showSearchSnippetInSettings {
SettingSection(name: "reading_settings.search_snippet.title".localized) {
Picker(selection: $searchResultSnippetMode) {
ForEach(SearchResultSnippetMode.allCases) { snippetMode in
Text(snippetMode.name).tag(snippetMode)
}
} label: { }
Toggle(" ", isOn: isSnippet)
}
}
}
@ -152,7 +156,15 @@ struct Settings: View {
}
var readingSettings: some View {
Section("reading_settings.tab.reading".localized) {
let isSnippet = Binding {
switch searchResultSnippetMode {
case .matches: return true
case .disabled: return false
}
} set: { isOn in
searchResultSnippetMode = isOn ? .matches : .disabled
}
return Section("reading_settings.tab.reading".localized) {
Stepper(value: $webViewPageZoom, in: 0.5...2, step: 0.05) {
Text("reading_settings.zoom.title".localized +
": \(Formatter.percent.string(from: NSNumber(value: webViewPageZoom)) ?? "")")
@ -165,11 +177,7 @@ struct Settings: View {
}
}
if FeatureFlags.showSearchSnippetInSettings {
Picker("reading_settings.search_snippet.title".localized, selection: $searchResultSnippetMode) {
ForEach(SearchResultSnippetMode.allCases) { snippetMode in
Text(snippetMode.name).tag(snippetMode)
}
}
Toggle("reading_settings.search_snippet.title".localized, isOn: isSnippet)
}
}
}