kiwix/kiwix-apple
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-apple.git synced 2025-09-26 13:29:31 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #598 from kiwix/585-fix-lego-messages-download_servicecompletedescription-and-file_importalertno_openmessage

Browse Source 
585: Replace 'lego' translations with placeholders and arguments
This commit is contained in:
Kelson 2023-12-22 11:33:02 +01:00 committed by GitHub
commit a3aeb9398e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Model/DownloadService.swift
View File

@ -194,7 +194,7 @@ class DownloadService: NSObject, URLSessionDelegate, URLSessionTaskDelegate, URL
content.title = "download_service.complete.title".localized
content.sound = .default
if let zimFile = try? context.fetch(ZimFile.fetchRequest(fileID: zimFileID)).first {
content.body = zimFile.name + "download_service.complete.description".localized
content.body = "download_service.complete.description".localizedWithFormat(withArgs: zimFile.name)
}
// schedule notification

4
Support/en.lproj/Localizable.strings
View File

@ -14,7 +14,7 @@
"library_refresh_error.process.description" = "Error processing library data.";
"download_service.complete.title" = "Download Completed";
"download_service.complete.description" = " has been downloaded successfully.";
"download_service.complete.description" = "%@ has been downloaded successfully.";
"common.dialog.button.open" = "Open";
"common.dialog.button.open_in_new_tab" = "Open in New Tab";
@ -62,7 +62,7 @@
"external_link_handler.alert.ask.description" = "An external link is tapped, do you wish to load the link?";
"external_link_handler.alert.not_loading.description" = "An external link is tapped. However, your current setting does not allow it to be loaded.";
"file_import.alert.no_open.title" = "Unable to open file";
"file_import.alert.no_open.message" = " cannot be opened.";
"file_import.alert.no_open.message" = "%@ cannot be opened.";
"article_cell.no_snippet.label" = "No snippet";
"attribute.detail.unknown" = "Unknown";

2
Views/ViewModifiers/FileImport.swift
View File

@ -104,7 +104,7 @@ struct OpenFileHandler: ViewModifier {
switch alert {
case .unableToOpen(let filenames):
let name = ListFormatter.localizedString(byJoining: filenames)
Text(name + "file_import.alert.no_open.message".localized)
Text("file_import.alert.no_open.message".localizedWithFormat(withArgs: name))
}
}
}