From 2022bb2acb9bb845cd171443d5edb8f66bbb0611 Mon Sep 17 00:00:00 2001
From: luddens <pierre.luddens@epitech.eu>
Date: Thu, 20 Jun 2019 15:26:45 +0200
Subject: [PATCH] Refresh only one book instead of all the library

These changes allow many improvements :
- they fix the infinite refresh of the library due to the multiple
"bookChanged" signal emitted when several operations on books were
performed simultaneously (launch several downloads)
- the scroll isn't reset to the top of the list when starting a download at
the bottom of the list
- (better optimization ?)

Now methods that concern only one book emit the signal "oneBookChanged"
with the id of the book, the JS slot search by id the correspondent book in
its list and replace it with an updated one.
---
 resources/js/_contentManager.js | 29 +++++++++++++++++++++++++++++
 src/contentmanager.cpp          | 16 ++++++++++++----
 src/contentmanager.h            |  2 ++
 3 files changed, 43 insertions(+), 4 deletions(-)

diff --git a/resources/js/_contentManager.js b/resources/js/_contentManager.js
index bf1240b..183a00b 100644
--- a/resources/js/_contentManager.js
+++ b/resources/js/_contentManager.js
@@ -7,6 +7,17 @@ function niceBytes(x){
   return(n.toFixed(n >= 10 || unitIndex < 1 ? 0 : 2) + ' ' + units[unitIndex]);
 }
 
+function getIndexById(id) {
+    var index = 0;
+    for(var i = 0; i < app.books.length; i++) {
+        if (app.books[i]["id"] == id) {
+            index = i;
+            break;
+        }
+    }
+    return index;
+}
+
 function createDict(keys, values) {
     var d = {}
     for(var i=0; i<keys.length; i++) {
@@ -34,6 +45,22 @@ function onBooksChanged () {
   app.displayedBooksNb = 20;
 }
 
+function onOneBookChanged (id) {
+    var index = getIndexById(id);
+    contentManager.getBookInfos(id, BOOK_KEYS, function(values) {
+        var b = createDict(BOOK_KEYS, values);
+        if (b.downloadId && !downloadUpdaters.hasOwnProperty(b.id)) {
+            downloadUpdaters[b.id] = setInterval(function() { getDownloadInfo(b.id); }, 1000);
+        }
+        app.books.splice(index, 1, b);
+    });
+}
+
+function onBookRemoved (id) {
+    var index = getIndexById(id);
+    app.books.splice(index, 1);
+}
+
 downloadUpdaters = {}
 const DOWNLOAD_KEYS = ["id", "status", "followedBy", "path", "totalLength", "completedLength", "downloadSpeed", "verifiedLength"];
 function getDownloadInfo(id) {
@@ -138,6 +165,8 @@ function init() {
       }
     });
     contentManager.booksChanged.connect(onBooksChanged);
+    contentManager.oneBookChanged.connect(onOneBookChanged);
+    contentManager.bookRemoved.connect(onBookRemoved);
     contentManager.pendingRequest.connect(displayLoadIcon);
     onBooksChanged();
     displayLoadIcon(false);
diff --git a/src/contentmanager.cpp b/src/contentmanager.cpp
index c8a4c8f..328eac5 100644
--- a/src/contentmanager.cpp
+++ b/src/contentmanager.cpp
@@ -123,7 +123,11 @@ QStringList ContentManager::updateDownloadInfos(QString id, const QStringList &k
         b.setPath(QDir::toNativeSeparators(tmp).toStdString());
         b.setDownloadId("");
         mp_library->save();
-        emit(mp_library->booksChanged());
+        if (!m_local) {
+            emit(oneBookChanged(id));
+        } else {
+            emit(mp_library->booksChanged());
+        }
     }
     for(auto& key: keys){
         ADD_V("id", getDid);
@@ -194,7 +198,7 @@ QString ContentManager::downloadBook(const QString &id)
     book.setDownloadId(download->getDid());
     mp_library->addBookToLibrary(book);
     mp_library->save();
-    emit(mp_library->booksChanged());
+    emit(oneBookChanged(id));
     return QString::fromStdString(download->getDid());
 }
 
@@ -214,7 +218,11 @@ void ContentManager::eraseBook(const QString& id)
     eraseBookFilesFromComputer(fileToRemove);
     mp_library->removeBookFromLibraryById(id);
     mp_library->save();
-    emit(mp_library->booksChanged());
+    if (m_local) {
+        emit(bookRemoved(id));
+    } else {
+        emit(oneBookChanged(id));
+    }
 }
 
 void ContentManager::pauseBook(const QString& id)
@@ -244,7 +252,7 @@ void ContentManager::cancelBook(const QString& id)
     eraseBookFilesFromComputer(fileToRemove);
     mp_library->removeBookFromLibraryById(id);
     mp_library->save();
-    emit(mp_library->booksChanged());
+    emit(oneBookChanged(id));
 }
 
 QStringList ContentManager::getDownloadIds()
diff --git a/src/contentmanager.h b/src/contentmanager.h
index 01bb802..b20b3db 100644
--- a/src/contentmanager.h
+++ b/src/contentmanager.h
@@ -44,6 +44,8 @@ private:
 signals:
     void filterParamsChanged();
     void booksChanged();
+    void oneBookChanged(const QString&);
+    void bookRemoved(const QString&);
     void downloadsChanged();
     void currentLangChanged();
     void pendingRequest(const bool);