From 7d94c068103bf9af3c9f0db9738bd7978c9262c1 Mon Sep 17 00:00:00 2001 From: sgourdas Date: Thu, 21 Mar 2024 18:52:04 +0200 Subject: [PATCH 1/2] Changed the icon of bookmarking action to a star Also: - Added tooltip for add/remove on reading list --- resources/i18n/en.json | 2 ++ resources/i18n/qqq.json | 2 ++ src/searchbar.cpp | 6 ++++-- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/resources/i18n/en.json b/resources/i18n/en.json index 67cbb6a..e8d67be 100644 --- a/resources/i18n/en.json +++ b/resources/i18n/en.json @@ -30,6 +30,8 @@ "set-fullscreen":"Set fullscreen", "quit-fullscreen":"Quit fullScreen", "table-of-content":"Table of content", + "add-bookmark": "Add to the reading list", + "remove-bookmark": "Remove from the reading list", "reading-list":"Reading list", "reading-list-title":"Reading List", "zoom-in":"Zoom in", diff --git a/resources/i18n/qqq.json b/resources/i18n/qqq.json index 38198f0..922511d 100644 --- a/resources/i18n/qqq.json +++ b/resources/i18n/qqq.json @@ -39,6 +39,8 @@ "videos": "{{identical|Video}}", "yes": "{{identical|yes}}", "no": "{{identical|no}}", + "add-bookmark": "Represents the action of adding a page as a bookmark", + "remove-bookmark": "Represents the action of removing a page from the bookmarks", "open-link-in-web-browser": "Ouvrir le lien dans le navigateur", "download-dir-dialog-msg": "Please note that {{DIRECTORY}} should be placed on a newline.", "monitor-dir-dialog-title": "\"Monitor\" means \"watch\" in this context. The monitor directory is monitored/watched for new ZIM files.", diff --git a/src/searchbar.cpp b/src/searchbar.cpp index c7a643c..a76c013 100644 --- a/src/searchbar.cpp +++ b/src/searchbar.cpp @@ -24,9 +24,11 @@ void SearchButton::set_searchMode(bool searchMode) } else { auto kiwixApp = KiwixApp::instance(); if (kiwixApp->isCurrentArticleBookmarked()) { - setIcon(QIcon(":/icons/reading-list-active.svg")); + setIcon(QIcon(":/icons/star.svg")); + setToolTip(gt("add-bookmark")); } else { - setIcon(QIcon(":/icons/reading-list.svg")); + setIcon(QIcon(":/icons/star-active.svg")); + setToolTip(gt("remove-bookmark")); } setIconSize(QSize(25, 25)); } From e61ca4b8b409137cb12bf0df1187de079d43f0af Mon Sep 17 00:00:00 2001 From: sgourdas Date: Sun, 31 Mar 2024 16:23:28 +0300 Subject: [PATCH 2/2] Fixed bookmark icon size and reversed display --- src/searchbar.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/searchbar.cpp b/src/searchbar.cpp index a76c013..3c3628a 100644 --- a/src/searchbar.cpp +++ b/src/searchbar.cpp @@ -24,13 +24,13 @@ void SearchButton::set_searchMode(bool searchMode) } else { auto kiwixApp = KiwixApp::instance(); if (kiwixApp->isCurrentArticleBookmarked()) { - setIcon(QIcon(":/icons/star.svg")); - setToolTip(gt("add-bookmark")); - } else { setIcon(QIcon(":/icons/star-active.svg")); setToolTip(gt("remove-bookmark")); + } else { + setIcon(QIcon(":/icons/star.svg")); + setToolTip(gt("add-bookmark")); } - setIconSize(QSize(25, 25)); + setIconSize(QSize(32, 32)); } }