From 4cbc6ee422a7720a7c908ddcf1c6806467b0c371 Mon Sep 17 00:00:00 2001
From: Veloman Yunkan <veloman.yunkan@gmail.com>
Date: Tue, 6 Feb 2024 17:14:29 +0400
Subject: [PATCH] Some renames in ThumbnailDownloader

Names should reflect the semantics rather than the anatomy.
---
 src/thumbnaildownloader.cpp | 12 ++++++------
 src/thumbnaildownloader.h   |  8 +++++---
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/src/thumbnaildownloader.cpp b/src/thumbnaildownloader.cpp
index fafd5ea..923b864 100644
--- a/src/thumbnaildownloader.cpp
+++ b/src/thumbnaildownloader.cpp
@@ -7,8 +7,8 @@
 ThumbnailDownloader::ThumbnailDownloader()
 {
     connect(this, &ThumbnailDownloader::oneThumbnailDownloaded, [=]() {
-        if (m_urlPairList.size() != 0)
-            downloadOnePair(m_urlPairList.takeFirst());
+        if (m_downloadQueue.size() != 0)
+            downloadThumbnail(m_downloadQueue.takeFirst());
         else
             m_isDownloading = false;
     });
@@ -20,22 +20,22 @@ ThumbnailDownloader::~ThumbnailDownloader()
 
 void ThumbnailDownloader::addDownload(QString url, ThumbnailId index)
 {
-    m_urlPairList.append({index, url});
+    m_downloadQueue.append({index, url});
     if (!m_isDownloading)
         startDownload();
 }
 
 void ThumbnailDownloader::startDownload()
 {
-    if (m_urlPairList.size() == 0) {
+    if (m_downloadQueue.size() == 0) {
         m_isDownloading = false;
         return;
     }
     m_isDownloading = true;
-    downloadOnePair(m_urlPairList.takeFirst());
+    downloadThumbnail(m_downloadQueue.takeFirst());
 }
 
-void ThumbnailDownloader::downloadOnePair(ThumbnailInfo thumbnailInfo)
+void ThumbnailDownloader::downloadThumbnail(ThumbnailInfo thumbnailInfo)
 {
     QNetworkRequest req(thumbnailInfo.second);
     auto reply = manager.get(req);
diff --git a/src/thumbnaildownloader.h b/src/thumbnaildownloader.h
index 8c5e450..b4f07c2 100644
--- a/src/thumbnaildownloader.h
+++ b/src/thumbnaildownloader.h
@@ -22,14 +22,16 @@ public:
 
     void addDownload(QString url, ThumbnailId index);
     void startDownload();
-    void downloadOnePair(ThumbnailInfo thumbnailInfo);
-    void clearQueue() { m_urlPairList.clear(); }
+    void clearQueue() { m_downloadQueue.clear(); }
+
+private:
+    void downloadThumbnail(ThumbnailInfo thumbnailInfo);
 
 signals:
     void oneThumbnailDownloaded(ThumbnailId, QString, QByteArray);
 
 private:
-    QQueue<ThumbnailInfo> m_urlPairList;
+    QQueue<ThumbnailInfo> m_downloadQueue;
     QNetworkAccessManager manager;
     bool m_isDownloading = false;