kiwix/kiwix-desktop
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-desktop.git synced 2025-09-23 03:58:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

Keep the mp_stackWidget in sync with the tabBar.

Browse Source 
We need to remove the child widget from the stackWidget before we remove
the tab. Else the onCurrentChanged will try to get the widget of the new
tab and if the tab and the stack are not in sync, we may get the wrong
widget.

As `closeTab` remove the widget from the stack we don't need to remove
it again in listen of `CloseTabAction`.
This commit is contained in:
Matthieu Gautier 2019-04-03 14:15:30 +02:00
parent c03b195325
commit 50ab4bfadb
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/tabbar.cpp
View File

@ -34,10 +34,6 @@ TabBar::TabBar(QWidget *parent) :
return;
}
this->closeTab(index);
auto widget = mp_stackedWidget->widget(index);
mp_stackedWidget->removeWidget(widget);
widget->setParent(nullptr);
delete widget;
});
connect(app->getAction(KiwixApp::ZoomInAction), &QAction::triggered,
this, [=]() {
@ -183,6 +179,8 @@ void TabBar::closeTab(int index)
if (index == 0)
return;
auto webview = widget(index);
mp_stackedWidget->removeWidget(webview);
webview->setParent(nullptr);
removeTab(index);
webview->close();
delete webview;