diff --git a/resources/css/style.css b/resources/css/style.css index 27f65eb..74eb2ff 100644 --- a/resources/css/style.css +++ b/resources/css/style.css @@ -70,10 +70,13 @@ TopWidget QToolButton::menu-arrow { image: none; } -TopWidget QToolButton#backButton { - margin-left: 6px; +TopWidget QToolButton#leftHistoryButton { + margin-left: 4px; } +TopWidget QToolButton#rightHistoryButton { + margin-right: 4px; +} TopWidget QToolButton#fullScreenButton { margin-right: 6px; diff --git a/resources/icons/back.svg b/resources/icons/history-left.svg similarity index 100% rename from resources/icons/back.svg rename to resources/icons/history-left.svg diff --git a/resources/icons/forward.svg b/resources/icons/history-right.svg similarity index 100% rename from resources/icons/forward.svg rename to resources/icons/history-right.svg diff --git a/resources/kiwix.qrc b/resources/kiwix.qrc index 1537bf8..5d65a97 100644 --- a/resources/kiwix.qrc +++ b/resources/kiwix.qrc @@ -4,8 +4,8 @@ icons/minimize.svg icons/download.svg icons/checkbox.svg - icons/back.svg - icons/forward.svg + icons/history-left.svg + icons/history-right.svg icons/help.svg icons/tick.svg icons/menu.svg diff --git a/src/kiwixapp.cpp b/src/kiwixapp.cpp index 83318e5..653b6b8 100644 --- a/src/kiwixapp.cpp +++ b/src/kiwixapp.cpp @@ -355,10 +355,18 @@ void KiwixApp::createAction() CREATE_ACTION_SHORTCUT(OpenHomePageAction, gt("home-page"), QKeySequence(Qt::ALT + Qt::Key_Home)); - CREATE_ACTION_ICON_SHORTCUT(HistoryBackAction, "back", gt("back"), QKeySequence(Qt::ALT + Qt::Key_Left)); + if (QGuiApplication::isLeftToRight()) { + CREATE_ACTION_ICON_SHORTCUT(HistoryBackAction, "history-left", gt("back"), QKeySequence(Qt::ALT + Qt::Key_Left)); + } else { + CREATE_ACTION_ICON_SHORTCUT(HistoryBackAction, "history-right", gt("back"), QKeySequence(Qt::ALT + Qt::Key_Right)); + } DISABLE_ACTION(HistoryBackAction); - CREATE_ACTION_ICON_SHORTCUT(HistoryForwardAction, "forward", gt("forward"), QKeySequence(Qt::ALT + Qt::Key_Right)); + if (QGuiApplication::isLeftToRight()) { + CREATE_ACTION_ICON_SHORTCUT(HistoryForwardAction, "history-right", gt("forward"), QKeySequence(Qt::ALT + Qt::Key_Right)); + } else { + CREATE_ACTION_ICON_SHORTCUT(HistoryForwardAction, "history-left", gt("forward"), QKeySequence(Qt::ALT + Qt::Key_Left)); + } DISABLE_ACTION(HistoryForwardAction); CREATE_ACTION_ICON_SHORTCUT(PrintAction, "print", gt("print"), QKeySequence::Print); diff --git a/src/topwidget.cpp b/src/topwidget.cpp index c82e962..5692ba9 100644 --- a/src/topwidget.cpp +++ b/src/topwidget.cpp @@ -17,7 +17,6 @@ TopWidget::TopWidget(QWidget *parent) : KiwixApp::instance()->getTabWidget()->triggerWebPageAction(QWebEnginePage::Back); }); addAction(back); - widgetForAction(back)->setObjectName("backButton"); // For CSS QAction *forward = app->getAction(KiwixApp::HistoryForwardAction); connect(forward, &QAction::triggered, [](){ @@ -25,6 +24,15 @@ TopWidget::TopWidget(QWidget *parent) : }); addAction(forward); + // For CSS + if (QGuiApplication::isLeftToRight()) { + widgetForAction(back)->setObjectName("leftHistoryButton"); + widgetForAction(forward)->setObjectName("rightHistoryButton"); + } else { + widgetForAction(forward)->setObjectName("leftHistoryButton"); + widgetForAction(back)->setObjectName("rightHistoryButton"); + } + addSeparator(); addWidget(&m_searchEntry); @@ -77,7 +85,7 @@ void TopWidget::handleWebActionEnabledChanged(QWebEnginePage::WebAction action, void TopWidget::mousePressEvent(QMouseEvent *event) { - if(event->button() != Qt::LeftButton) + if (event->button() != Qt::LeftButton) return; m_cursorPos = event->globalPos() + frameGeometry().topLeft() - parentWidget()->frameGeometry().topLeft(); @@ -86,7 +94,7 @@ void TopWidget::mousePressEvent(QMouseEvent *event) { } void TopWidget::mouseMoveEvent(QMouseEvent *event) { - if(event->timestamp() <= m_timestamp) + if (event->timestamp() <= m_timestamp) return; m_timestamp = event->timestamp();