From 8d6d6833e711b620cd064d7f2632b9f10944694c Mon Sep 17 00:00:00 2001
From: Nikhil Tanwar <2002nikhiltanwar@gmail.com>
Date: Tue, 8 Feb 2022 20:09:53 +0530
Subject: [PATCH] Make SettingsManager::setDownloadDir a void function

The current implementation doesn't have any effect on it being a bool
---
 src/settingsmanager.cpp | 3 +--
 src/settingsmanager.h   | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/settingsmanager.cpp b/src/settingsmanager.cpp
index 288c23c..7941329 100644
--- a/src/settingsmanager.cpp
+++ b/src/settingsmanager.cpp
@@ -73,12 +73,11 @@ void SettingsManager::setZoomFactor(qreal zoomFactor)
     emit(zoomChanged(zoomFactor));
 }
 
-bool SettingsManager::setDownloadDir(QString downloadDir)
+void SettingsManager::setDownloadDir(QString downloadDir)
 {
     m_downloadDir = downloadDir;
     m_settings.setValue("download/dir", downloadDir);
     emit(downloadDirChanged(downloadDir));
-    return true;
 }
 
 void SettingsManager::initSettings()
diff --git a/src/settingsmanager.h b/src/settingsmanager.h
index 2dd4a26..8540e87 100644
--- a/src/settingsmanager.h
+++ b/src/settingsmanager.h
@@ -31,7 +31,7 @@ public slots:
     void setKiwixServerPort(int port);
     void setKiwixServerIpAddress(QString ipAddress);
     void setZoomFactor(qreal zoomFactor);
-    bool setDownloadDir(QString downloadDir);
+    void setDownloadDir(QString downloadDir);
 private:
     void initSettings();