kiwix/kiwix-desktop
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-desktop.git synced 2025-09-22 11:37:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix Suggestion Flickering when Typing

Browse Source 
setCompleter call setCompletionPrefix on typing which flicker
This commit is contained in:
ShaopengLin 2024-10-09 01:09:26 -04:00
parent ec39c09979
commit 9982a22df7
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/searchbar.cpp
View File

@ -71,7 +71,7 @@ SearchBarLineEdit::SearchBarLineEdit(QWidget *parent) :
/* The items should be less than fetch size to enable scrolling. */ /* The items should be less than fetch size to enable scrolling. */
m_completer.setMaxVisibleItems(SuggestionListWorker::getFetchSize() / 2); m_completer.setMaxVisibleItems(SuggestionListWorker::getFetchSize() / 2);
setCompleter(&m_completer); m_completer.setWidget(this);
/* QCompleter's uses default list views, which do not have headers. */ /* QCompleter's uses default list views, which do not have headers. */
m_completer.setPopup(m_suggestionView); m_completer.setPopup(m_suggestionView);
@ -171,9 +171,18 @@ void SearchBarLineEdit::focusInEvent( QFocusEvent* event)
if (event->reason() == Qt::ActiveWindowFocusReason || if (event->reason() == Qt::ActiveWindowFocusReason ||
event->reason() == Qt::MouseFocusReason || event->reason() == Qt::MouseFocusReason ||
event->reason() == Qt::ShortcutFocusReason) { event->reason() == Qt::ShortcutFocusReason) {
connect(&m_completer, QOverload<const QString &>::of(&QCompleter::activated),
this, &QLineEdit::setText,Qt::UniqueConnection);
connect(&m_completer, QOverload<const QModelIndex &>::of(&QCompleter::activated), connect(&m_completer, QOverload<const QModelIndex &>::of(&QCompleter::activated),
this, QOverload<const QModelIndex &>::of(&SearchBarLineEdit::openCompletion), this, QOverload<const QModelIndex &>::of(&SearchBarLineEdit::openCompletion),
Qt::UniqueConnection); Qt::UniqueConnection);
connect(&m_completer, QOverload<const QModelIndex &>::of(&QCompleter::highlighted), this,
[=](const QModelIndex &index){
setText(index.isValid() ? index.data().toString() : m_searchbarInput);
},
Qt::UniqueConnection);
} }
QLineEdit::focusInEvent(event); QLineEdit::focusInEvent(event);
} }
@ -185,6 +194,7 @@ void SearchBarLineEdit::focusOutEvent(QFocusEvent* event)
setText(m_title); setText(m_title);
} }
deselect(); deselect();
disconnect(&m_completer, nullptr, this, nullptr);
return QLineEdit::focusOutEvent(event); return QLineEdit::focusOutEvent(event);
} }