kiwix/kiwix-desktop
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-desktop.git synced 2025-09-24 12:40:55 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix random crash

Browse Source 
The buffers, where reply of a request is send, were deleted when they were about
to close but it makes the app crash, they have to be deleted when the request
object is deleted
This commit is contained in:
luddens 2019-06-04 11:13:38 +02:00
parent d809533ee8
commit cb9707a511
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/urlschemehandler.cpp
View File

@ -49,7 +49,7 @@ UrlSchemeHandler::handleContentRequest(QWebEngineUrlRequestJob *request)
BlobBuffer* buffer = new BlobBuffer(entry.getBlob());
auto mimeType = QByteArray::fromStdString(entry.getMimetype());
mimeType = mimeType.split(';')[0];
connect(buffer, &QIODevice::aboutToClose, buffer, &QObject::deleteLater);
connect(request, &QObject::destroyed, buffer, &QObject::deleteLater);
request->reply(mimeType, buffer);
}
@ -69,7 +69,7 @@ UrlSchemeHandler::handleMetaRequest(QWebEngineUrlRequestJob* request)
std::string mimeType = book.getFaviconMimeType();
QBuffer* buffer = new QBuffer;
buffer->setData(content.data(), content.size());
connect(buffer, &QIODevice::aboutToClose, buffer, &QObject::deleteLater);
connect(request, &QObject::destroyed, buffer, &QObject::deleteLater);
request->reply(QByteArray::fromStdString(mimeType), buffer);
}
request->fail(QWebEngineUrlRequestJob::UrlNotFound);