kiwix/kiwix-desktop
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-desktop.git synced 2025-09-25 22:06:16 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix pagination by setting pageLength properly

Browse Source 
The pageLength parameter of kiwix::SearchRenderer is not set properly
which causes it to take an arbitrary large value breaking pagination.

The solution is to use the same convention as kiwix-serve. Try to read
the pageLength from query if found, else use a default value of 25. Use
this pageLength to find end. Use renderer.setPageLength() method to set
the pageLength properly.
This commit is contained in:
Maneesh P M 2021-04-22 12:38:58 +05:30
parent 1d8c556075
commit e738905223
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/urlschemehandler.cpp
View File

@ -101,10 +101,12 @@ UrlSchemeHandler::handleSearchRequest(QWebEngineUrlRequestJob* request)
int temp = query.queryItemValue("start").toInt(&ok);
if (ok)
start = temp;
int end = 25;
temp = query.queryItemValue("end").toInt(&ok);
int pageLength = 25;
temp = query.queryItemValue("pageLength").toInt(&ok);
if (ok)
end = temp;
pageLength = temp;
auto end = start + pageLength;
auto searcher = app->getLibrary()->getSearcher(bookId);
searcher->search(searchQuery, start, end);
@ -115,6 +117,7 @@ UrlSchemeHandler::handleSearchRequest(QWebEngineUrlRequestJob* request)
renderer.setSearchContent(bookId.toStdString());
renderer.setProtocolPrefix("zim://");
renderer.setSearchProtocolPrefix("zim://" + host.toStdString() + "/?");
renderer.setPageLength(pageLength);
auto content = renderer.getHtml();
QBuffer *buffer = new QBuffer;
buffer->setData(content.data(), content.size());