From f576df02fdcb9718b0821f2fdc8946381ce1dcf2 Mon Sep 17 00:00:00 2001 From: Alexander Sashnov Date: Sat, 13 Feb 2021 02:38:52 +0700 Subject: [PATCH] be clear about which pointer we get (instead of 'auto') --- src/searchbar.cpp | 4 ++-- src/suggestionlistworker.cpp | 6 +++--- src/tabbar.cpp | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/searchbar.cpp b/src/searchbar.cpp index e7d53dc..f7f76e3 100644 --- a/src/searchbar.cpp +++ b/src/searchbar.cpp @@ -155,8 +155,8 @@ void SearchBar::updateCompletion() { mp_typingTimer->stop(); clearSuggestions(); - auto currentWidget = KiwixApp::instance()->getTabWidget()->currentWebView(); - if (!currentWidget || currentWidget->url().isEmpty() || m_searchbarInput.isEmpty()) { + WebView* current = KiwixApp::instance()->getTabWidget()->currentWebView(); + if (!current || current->url().isEmpty() || m_searchbarInput.isEmpty()) { hideSuggestions(); return; } diff --git a/src/suggestionlistworker.cpp b/src/suggestionlistworker.cpp index 98aa846..770a29a 100644 --- a/src/suggestionlistworker.cpp +++ b/src/suggestionlistworker.cpp @@ -13,10 +13,10 @@ void SuggestionListWorker::run() QStringList suggestionList; QVector urlList; - auto currentWidget = KiwixApp::instance()->getTabWidget()->currentWebView(); - if(!currentWidget) + WebView *current = KiwixApp::instance()->getTabWidget()->currentWebView(); + if(!current) return; - auto qurl = currentWidget->url(); + auto qurl = current->url(); auto currentZimId = qurl.host().split(".")[0]; auto reader = KiwixApp::instance()->getLibrary()->getReader(currentZimId); QUrl url; diff --git a/src/tabbar.cpp b/src/tabbar.cpp index fde6280..8904522 100644 --- a/src/tabbar.cpp +++ b/src/tabbar.cpp @@ -55,9 +55,9 @@ TabBar::TabBar(QWidget *parent) : setCurrentIndex(m_settingsIndex); return; } - auto index = currentIndex() + 1; + int index = currentIndex() + 1; m_settingsIndex = index; - auto view = KiwixApp::instance()->getSettingsManager()->getView(); + SettingsManagerView* view = KiwixApp::instance()->getSettingsManager()->getView(); mp_stackedWidget->insertWidget(index, view); insertTab(index,QIcon(":/icons/settings.svg"), gt("settings")); QToolButton *tb = new QToolButton(this);