Matthieu Gautier
7d06bdc91b
Merge pull request #1041 from kiwix/refactoring
2024-02-26 14:02:37 +01:00
Veloman Yunkan
852fa7cdb7
Extracted checkEnoughStorageAvailable()
...
... mainly for readability.
2024-02-22 13:31:19 +04:00
Veloman Yunkan
7ec85ac2fb
Introduced ContentManagerError
2024-02-22 13:31:19 +04:00
Veloman Yunkan
142e6fed58
Dropped unused return value
2024-02-22 13:31:19 +04:00
Veloman Yunkan
a31aec56f8
Extracted ContentManager::getRemoteOrLocalBook()
...
... mainly for readability.
2024-02-22 13:31:19 +04:00
Veloman Yunkan
c70ab0ed0d
Unsplit download pause/resume operations
...
Download pause/resume operations are no longer split across
ContentManager and ContentManagerModel.
2024-02-22 13:31:19 +04:00
Veloman Yunkan
bd54da2cb2
Deleted obsolete/unused stuff from ContentManager
2024-02-22 13:31:19 +04:00
Veloman Yunkan
7db27fd576
Better grouped declaration of ContentManager
2024-02-22 13:31:19 +04:00
Veloman Yunkan
a1c60d8dbe
Moved ownership of download state to ContentManager
...
ContentManagerModel depends on the current view settings (filters) much
more than ContentManager does. Since the download state (the set of
active and/or paused downloads and their progress info) is independent
of the view settings it is more natural for ContentManager to own it.
2024-02-22 13:31:19 +04:00
Veloman Yunkan
b0b592dfd8
Extracted ContentManager::downloadStarted()
2024-02-22 13:31:19 +04:00
Veloman Yunkan
2fbfe40c11
Extracted ContentManager::getDownloadInfo()
2024-02-22 13:31:19 +04:00
Veloman Yunkan
dd69a9d2bd
ContentManager::DownloadInfo typedef
2024-02-22 13:31:19 +04:00
Veloman Yunkan
4f4c811711
Extracted ContentManager::downloadCancelled()
2024-02-22 13:31:19 +04:00
Veloman Yunkan
fecf83a061
Extracted ContentManager::downloadCompleted()
2024-02-22 13:31:19 +04:00
Veloman Yunkan
da1f06f9c8
Extracted getDownloadInfo()
2024-02-22 13:31:19 +04:00
Veloman Yunkan
a89e9b4799
Extracted downloadStatus2String()
2024-02-22 13:31:19 +04:00
Veloman Yunkan
17ac566b07
Merge pull request #1034 from kiwix/translatewiki
...
Localisation updates from https://translatewiki.net .
2024-02-20 14:44:04 +04:00
translatewiki.net
11e6e6b3f5
Localisation updates from https://translatewiki.net .
2024-02-19 13:07:47 +01:00
Matthieu Gautier
cc159a2928
Merge pull request #1036 from kiwix/more_reliable_thumbnail_loading
...
More reliable loading of remote thumbnails
2024-02-14 12:00:08 +01:00
Veloman Yunkan
82e6cc48cd
Using the book id as the thumbnail id
...
Since the content manager model may be updated (e.g. by applying a
filter) while the thumbnails/favicons are still being loaded it is
better to use a model invariant id for the thumbnails.
2024-02-07 19:08:43 +04:00
Veloman Yunkan
cf8b010ddc
Simpler ThumbnailDownloader ctor
2024-02-07 19:08:43 +04:00
Veloman Yunkan
4cbc6ee422
Some renames in ThumbnailDownloader
...
Names should reflect the semantics rather than the anatomy.
2024-02-07 19:08:43 +04:00
Veloman Yunkan
b252033cc0
Deleted unused parameter
2024-02-07 19:08:43 +04:00
Veloman Yunkan
847c65baf1
typedefs in ThumbnailDownloader
2024-02-07 19:08:43 +04:00
Veloman Yunkan
535675afdb
Fixed fetching of favicons from debug server
...
When using a debug server (enabled by the environment variables
KIWIX_CATALOG_HOST and KIWIX_CATALOG_PORT) the URLs of the favicons
must be composed correspondingly.
2024-02-07 19:08:43 +04:00
Matthieu Gautier
4914bb86eb
Merge pull request #1035 from kiwix/confirmbox_utils
...
Made it easier to display info and/or confirmation boxes
2024-02-07 14:41:54 +01:00
Veloman Yunkan
0f088697c6
Introduced showConfirmBox()
2024-02-06 15:14:58 +04:00
Veloman Yunkan
c07838806b
Extracted ContentManager::reallyEraseBook()
2024-02-06 15:14:58 +04:00
Veloman Yunkan
c77004d925
Extracted openFileLocation()
2024-02-06 15:14:58 +04:00
Veloman Yunkan
188d5eabe9
Introduced showInfoBox()
2024-02-06 15:14:58 +04:00
Veloman Yunkan
ebf444690b
Merge pull request #1026 from kiwix/translatewiki
...
Localisation updates from https://translatewiki.net .
2024-01-30 14:29:03 +04:00
translatewiki.net
a3a9e9b610
Localisation updates from https://translatewiki.net .
2024-01-29 13:09:37 +01:00
Matthieu Gautier
5b1a16caa0
Merge pull request #1027 from kiwix/ghaction
...
Use kiwix-build's github action to download dependencies.
2023-12-20 12:02:45 +01:00
Matthieu Gautier
205754b549
Use kiwix-build's github action to download dependencies.
2023-12-20 11:57:35 +01:00
Kelson
352cdcca97
Merge pull request #1017 from kiwix/translatewiki
...
Localisation updates from https://translatewiki.net .
2023-12-17 11:54:45 +01:00
Matthieu Gautier
2d49d79fc2
Merge pull request #1024 from kiwix/download_bugfixes
...
A couple of bugfixes in Download management
2023-12-14 18:02:32 +01:00
Veloman Yunkan
341c7ed8e3
Extracted ContentManagerModel::updateDownload()
...
The diff is simpler if whitespace changes are ignored.
2023-12-14 17:21:21 +04:00
Veloman Yunkan
3e3cd676b5
More reliable updates of download status
...
This fix is rather a temporary and ugly hack, since the current mess
with how download states are being maintained (in the presence of
multiple sources of their updates) asks for a major clean-up.
2023-12-14 17:21:21 +04:00
Veloman Yunkan
79e71e3c3d
Consistent capitalization across download actions
2023-12-14 17:21:21 +04:00
Veloman Yunkan
e020d52745
Rearranged code in DonwloadState::update()
...
It's more logical to check for the conditions of a disappeared download
first.
2023-12-14 17:21:12 +04:00
translatewiki.net
d0006519a5
Localisation updates from https://translatewiki.net .
2023-12-14 13:07:09 +01:00
Veloman Yunkan
c20eedf9f6
ContentManagerModel maintains the download state
...
This fixes the bugs related to pending download statuses being discarded
by filtering and similar operations that result in full update of the
ContentManagerModel.
Instead this commit leads to a new bug - completion of a download
is not always properly detected for very small (and thus instantaneous)
downloads. This is caused by library update events triggered by ZIM
directory monitoring (which notifies about a new ZIM file appearing
in the download directory) interfering with the download status update
signal.
2023-12-14 13:03:16 +04:00
Veloman Yunkan
ef2131d7f3
Preparing RowNode for shared DownloadState
...
This is needed for preserving download state across filtering and
similar operations that currently work by fully rebuilding the
ContentManagerModel.
2023-12-13 21:31:29 +04:00
Veloman Yunkan
a13a1c0f6b
Renamed a few member functions
2023-12-13 20:26:09 +04:00
Veloman Yunkan
9ce484a664
RowNode stops deriving from DownloadState
...
Now DownloadState is an optional element of the state of RowNode
and is set in it only in case of an active (even if paused) download
associated with the that entry.
2023-12-13 20:22:49 +04:00
Veloman Yunkan
ad09ee10e1
Better grouping of code
2023-12-13 19:43:49 +04:00
Veloman Yunkan
8ad42a2dc2
Got rid of DownloadState::setDownloadInfo()
2023-12-13 19:40:55 +04:00
Veloman Yunkan
960f955723
Extracted DownloadState
2023-12-13 19:36:20 +04:00
Veloman Yunkan
06a93d117f
RowNode::{pause,resume}Download()
2023-12-13 17:39:34 +04:00
Veloman Yunkan
509e7be467
Deleted unused local variables
2023-12-13 17:28:40 +04:00
