kiwix/kiwix-js
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-js.git synced 2025-09-24 04:54:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix links to articles with a long name

Browse Source 
Fixes #47
This commit is contained in:
mossroy 2013-08-04 12:26:52 +02:00
parent e141a769db
commit 3f8162e377
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
index.html
View File

@ -92,7 +92,6 @@
<br />
It's still a beta version : there are many ways this could be enhanced (suggestions and patches are welcome : the source code is on <a href="https://github.com/mossroy/evopedia-html5" target="_blank">github</a>). In particular :
<ul>
<li>In some rare cases, the links inside an article do not work, or do not lead to the right article</li>
<li>It is not easy to use on the Peak device from Geeksphone because the buttons and inputs are too small</li>
<li>Some features of the original application still have to be implemented : in particular the "Articles nearby" feature (geolocation)</li>
</ul>

11
js/lib/archive.js
View File

@ -17,6 +17,10 @@ define(function(require) {
// The maximum number of titles that can have the same name after normalizing
// This is used by the algorithm that searches for a specific article by its name
var MAX_TITLES_WITH_SAME_NORMALIZED_NAME = 30;
// Maximum length of a title
// 300 bytes is arbitrary : we actually do not really know how long the titles will be
// But mediawiki titles seem to be limited to ~200 bytes, so 300 should be more than enough
var MAX_TITLE_LENGTH = 300;
/**
* LocalArchive class : defines a wikipedia dump on the filesystem
@ -259,8 +263,7 @@ define(function(require) {
LocalArchive.prototype.recursivePrefixSearch = function(reader, normalizedPrefix, lo, hi, callbackFunction) {
if (lo < hi - 1) {
var mid = Math.floor((lo + hi) / 2);
// TODO : improve the way we read this file : 128 bytes is arbitrary and might be too small
var blob = this.titleFile.slice(mid, mid + 128);
var blob = this.titleFile.slice(mid, mid + MAX_TITLE_LENGTH);
var currentLocalArchiveInstance = this;
reader.onload = function(e) {
var binaryTitleFile = e.target.result;
@ -352,9 +355,7 @@ define(function(require) {
}
callbackFunction(titleList);
};
// 300 bytes is arbitrary : we actually do not really know how long the titles will be
// But mediawiki titles seem to be limited to ~200 bytes, so 300 should be more than enough
var blob = this.titleFile.slice(titleOffset, titleOffset + titleCount * 300);
var blob = this.titleFile.slice(titleOffset, titleOffset + titleCount * MAX_TITLE_LENGTH);
// Read in the file as a binary string
reader.readAsArrayBuffer(blob);
};