kiwix/kiwix-js
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-js.git synced 2025-09-24 04:54:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Updated cookie to ensure SameSite is set as Strict #627 (#635)

Browse Source 
Fixes #627 .
This commit is contained in:
Abhirup Pal 2020-07-11 14:57:12 +05:30 committed by GitHub
parent bc82070102
commit 638728a58e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
www/js/lib/settingsStore.js
View File

@ -62,10 +62,10 @@ define([], function () {
localStorageTest = false;
}
// Now test for document.cookie API support
document.cookie = 'tempKiwixCookieTest=working;expires=Fri, 31 Dec 9999 23:59:59 GMT';
document.cookie = 'tempKiwixCookieTest=working; expires=Fri, 31 Dec 9999 23:59:59 GMT; SameSite=Strict';
var kiwixCookieTest = /tempKiwixCookieTest=working/.test(document.cookie);
// Remove test value by expiring the key
document.cookie = 'tempKiwixCookieTest=;expires=Thu, 01 Jan 1970 00:00:00 GMT';
document.cookie = 'tempKiwixCookieTest=; expires=Thu, 01 Jan 1970 00:00:00 GMT; SameSite=Strict';
if (kiwixCookieTest) type = 'cookie';
// Prefer localStorage if supported due to some platforms removing cookies once the session ends in some contexts
if (localStorageTest) type = 'local_storage';
@ -167,4 +167,4 @@ define([], function () {
hasItem: settingsStore.hasItem,
getBestAvailableStorageAPI: getBestAvailableStorageAPI
};
});
});