From 0e6919300bebb0bfdaacbcba30e55a9c6c4816d1 Mon Sep 17 00:00:00 2001 From: benoit74 Date: Tue, 8 Oct 2024 11:56:58 +0000 Subject: [PATCH] Fix help and add test case to check this important feature --- .github/workflows/Tests.yaml | 3 +++ CHANGELOG.md | 4 ++++ src/zimit/zimit.py | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/Tests.yaml b/.github/workflows/Tests.yaml index 2b77f1e..9e21fa7 100644 --- a/.github/workflows/Tests.yaml +++ b/.github/workflows/Tests.yaml @@ -59,6 +59,9 @@ jobs: - name: build image run: docker build -t zimit . + - name: ensure help display without issue + run: docker run -v $PWD/output:/output zimit zimit --help + - name: run crawl run: docker run -v $PWD/output:/output zimit zimit --url http://isago.rskg.org/ --name isago --zim-file isago.zim --adminEmail test@example.com --mobileDevice "Pixel 5" --statsFilename /output/stats.json --keep diff --git a/CHANGELOG.md b/CHANGELOG.md index a4b733a..9237d92 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Upgrade to browsertrix crawler 1.3.2, warc2zim 2.1.2 and other dependencies (#406) +### Fixed + +- Fix help (#393) + ## [2.1.2] - 2024-09-09 ### Changed diff --git a/src/zimit/zimit.py b/src/zimit/zimit.py index 45219f8..44c6d4f 100755 --- a/src/zimit/zimit.py +++ b/src/zimit/zimit.py @@ -287,7 +287,7 @@ def run(raw_args): parser.add_argument( "--diskUtilization", help="Save state and exit if disk utilization exceeds this percentage value." - " Default (if not set) is 90%. Set to 0 to disable disk utilization check.", + " Default (if not set) is 90%%. Set to 0 to disable disk utilization check.", type=int, default=90, )