mirror of
https://github.com/Stichting-MINIX-Research-Foundation/pkgsrc-ng.git
synced 2025-09-09 20:40:13 -04:00
132 lines
4.4 KiB
Plaintext
132 lines
4.4 KiB
Plaintext
$NetBSD: patch-CVE-2015-3456,v 1.1 2015/06/05 18:18:41 khorben Exp $
|
|
|
|
fdc: force the fifo access to be in bounds of the allocated buffer
|
|
|
|
During processing of certain commands such as FD_CMD_READ_ID and
|
|
FD_CMD_DRIVE_SPECIFICATION_COMMAND the fifo memory access could
|
|
get out of bounds leading to memory corruption with values coming
|
|
from the guest.
|
|
|
|
Fix this by making sure that the index is always bounded by the
|
|
allocated memory.
|
|
|
|
This is CVE-2015-3456.
|
|
|
|
Signed-off-by: Petr Matousek <pmatouse@redhat.com>
|
|
Reviewed-by: John Snow <jsnow@redhat.com>
|
|
|
|
--- tools/qemu-xen/hw/fdc.c.orig
|
|
+++ tools/qemu-xen/hw/fdc.c
|
|
@@ -1497,7 +1497,7 @@ static uint32_t fdctrl_read_data(FDCtrl *fdctrl)
|
|
{
|
|
FDrive *cur_drv;
|
|
uint32_t retval = 0;
|
|
- int pos;
|
|
+ uint32_t pos;
|
|
|
|
cur_drv = get_cur_drv(fdctrl);
|
|
fdctrl->dsr &= ~FD_DSR_PWRDOWN;
|
|
@@ -1506,8 +1506,8 @@ static uint32_t fdctrl_read_data(FDCtrl *fdctrl)
|
|
return 0;
|
|
}
|
|
pos = fdctrl->data_pos;
|
|
+ pos %= FD_SECTOR_LEN;
|
|
if (fdctrl->msr & FD_MSR_NONDMA) {
|
|
- pos %= FD_SECTOR_LEN;
|
|
if (pos == 0) {
|
|
if (fdctrl->data_pos != 0)
|
|
if (!fdctrl_seek_to_next_sect(fdctrl, cur_drv)) {
|
|
@@ -1852,10 +1852,13 @@ static void fdctrl_handle_option(FDCtrl *fdctrl, int direction)
|
|
static void fdctrl_handle_drive_specification_command(FDCtrl *fdctrl, int direction)
|
|
{
|
|
FDrive *cur_drv = get_cur_drv(fdctrl);
|
|
+ uint32_t pos;
|
|
|
|
- if (fdctrl->fifo[fdctrl->data_pos - 1] & 0x80) {
|
|
+ pos = fdctrl->data_pos - 1;
|
|
+ pos %= FD_SECTOR_LEN;
|
|
+ if (fdctrl->fifo[pos] & 0x80) {
|
|
/* Command parameters done */
|
|
- if (fdctrl->fifo[fdctrl->data_pos - 1] & 0x40) {
|
|
+ if (fdctrl->fifo[pos] & 0x40) {
|
|
fdctrl->fifo[0] = fdctrl->fifo[1];
|
|
fdctrl->fifo[2] = 0;
|
|
fdctrl->fifo[3] = 0;
|
|
@@ -1955,7 +1958,7 @@ static uint8_t command_to_handler[256];
|
|
static void fdctrl_write_data(FDCtrl *fdctrl, uint32_t value)
|
|
{
|
|
FDrive *cur_drv;
|
|
- int pos;
|
|
+ uint32_t pos;
|
|
|
|
/* Reset mode */
|
|
if (!(fdctrl->dor & FD_DOR_nRESET)) {
|
|
@@ -2004,7 +2007,9 @@ static void fdctrl_write_data(FDCtrl *fdctrl, uint32_t value)
|
|
}
|
|
|
|
FLOPPY_DPRINTF("%s: %02x\n", __func__, value);
|
|
- fdctrl->fifo[fdctrl->data_pos++] = value;
|
|
+ pos = fdctrl->data_pos++;
|
|
+ pos %= FD_SECTOR_LEN;
|
|
+ fdctrl->fifo[pos] = value;
|
|
if (fdctrl->data_pos == fdctrl->data_len) {
|
|
/* We now have all parameters
|
|
* and will be able to treat the command
|
|
--- tools/qemu-xen-traditional/hw/fdc.c.orig
|
|
+++ tools/qemu-xen-traditional/hw/fdc.c
|
|
@@ -1318,7 +1318,7 @@ static uint32_t fdctrl_read_data (fdctrl_t *fdctrl)
|
|
{
|
|
fdrive_t *cur_drv;
|
|
uint32_t retval = 0;
|
|
- int pos;
|
|
+ uint32_t pos;
|
|
|
|
cur_drv = get_cur_drv(fdctrl);
|
|
fdctrl->dsr &= ~FD_DSR_PWRDOWN;
|
|
@@ -1327,8 +1327,8 @@ static uint32_t fdctrl_read_data (fdctrl_t *fdctrl)
|
|
return 0;
|
|
}
|
|
pos = fdctrl->data_pos;
|
|
+ pos %= FD_SECTOR_LEN;
|
|
if (fdctrl->msr & FD_MSR_NONDMA) {
|
|
- pos %= FD_SECTOR_LEN;
|
|
if (pos == 0) {
|
|
if (fdctrl->data_pos != 0)
|
|
if (!fdctrl_seek_to_next_sect(fdctrl, cur_drv)) {
|
|
@@ -1673,10 +1673,13 @@ static void fdctrl_handle_option (fdctrl_t *fdctrl, int direction)
|
|
static void fdctrl_handle_drive_specification_command (fdctrl_t *fdctrl, int direction)
|
|
{
|
|
fdrive_t *cur_drv = get_cur_drv(fdctrl);
|
|
+ uint32_t pos;
|
|
|
|
- if (fdctrl->fifo[fdctrl->data_pos - 1] & 0x80) {
|
|
+ pos = fdctrl->data_pos - 1;
|
|
+ pos %= FD_SECTOR_LEN;
|
|
+ if (fdctrl->fifo[pos] & 0x80) {
|
|
/* Command parameters done */
|
|
- if (fdctrl->fifo[fdctrl->data_pos - 1] & 0x40) {
|
|
+ if (fdctrl->fifo[pos] & 0x40) {
|
|
fdctrl->fifo[0] = fdctrl->fifo[1];
|
|
fdctrl->fifo[2] = 0;
|
|
fdctrl->fifo[3] = 0;
|
|
@@ -1771,7 +1774,7 @@ static uint8_t command_to_handler[256];
|
|
static void fdctrl_write_data (fdctrl_t *fdctrl, uint32_t value)
|
|
{
|
|
fdrive_t *cur_drv;
|
|
- int pos;
|
|
+ uint32_t pos;
|
|
|
|
/* Reset mode */
|
|
if (!(fdctrl->dor & FD_DOR_nRESET)) {
|
|
@@ -1817,7 +1820,9 @@ static void fdctrl_write_data (fdctrl_t *fdctrl, uint32_t value)
|
|
}
|
|
|
|
FLOPPY_DPRINTF("%s: %02x\n", __func__, value);
|
|
- fdctrl->fifo[fdctrl->data_pos++] = value;
|
|
+ pos = fdctrl->data_pos++;
|
|
+ pos %= FD_SECTOR_LEN;
|
|
+ fdctrl->fifo[pos] = value;
|
|
if (fdctrl->data_pos == fdctrl->data_len) {
|
|
/* We now have all parameters
|
|
* and will be able to treat the command
|