minix/u-boot
1
0
Fork 0
mirror of https://github.com/Stichting-MINIX-Research-Foundation/u-boot.git synced 2025-09-10 12:39:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

IXP: Fix NAND build warning on PDNB3 and SCPU

Browse Source 
nand.c: In function ‘pdnb3_nand_read_buf’:
nand.c:107:4: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
nand.c: In function ‘pdnb3_nand_dev_ready’:
nand.c:124:18: warning: variable ‘val’ set but not used [-Wunused-but-set-variable]

Remove the 4-byte-at-time read mode altogether, the most is bogus and will
likely cause unaligned accesses.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Bryan Hundven <bryanhundven@gmail.com>
Cc: Michael Schwingen <rincewind@discworld.dascon.de>
This commit is contained in:
Marek Vasut 2012-03-06 01:10:00 +01:00 committed by Albert ARIBAUD
parent 2152df67c3
commit 44e63c228e
1 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
board/prodrive/pdnb3/nand.c
View File

@ -96,16 +96,8 @@ static void pdnb3_nand_read_buf(struct mtd_info *mtd, u_char *buf, int len)
{ {
int i; int i;
if (len % 4) { for (i = 0; i < len; i++)
for (i = 0; i < len; i++) buf[i] = readb(&(pdnb3_ndfc->data));
buf[i] = readb(&(pdnb3_ndfc->data));
} else {
ulong *ptr = (ulong *)buf;
int count = len >> 2;
for (i = 0; i < count; i++)
*ptr++ = readl(&(pdnb3_ndfc->data));
}
} }
static int pdnb3_nand_verify_buf(struct mtd_info *mtd, const u_char *buf, int len) static int pdnb3_nand_verify_buf(struct mtd_info *mtd, const u_char *buf, int len)
@ -121,12 +113,10 @@ static int pdnb3_nand_verify_buf(struct mtd_info *mtd, const u_char *buf, int le
static int pdnb3_nand_dev_ready(struct mtd_info *mtd) static int pdnb3_nand_dev_ready(struct mtd_info *mtd)
{ {
volatile u_char val;
/* /*
* Blocking read to wait for NAND to be ready * Blocking read to wait for NAND to be ready
*/ */
val = readb(&(pdnb3_ndfc->wait)); readb(&(pdnb3_ndfc->wait));
/* /*
* Return always true * Return always true