minix/u-boot
1
0
Fork 0
mirror of https://github.com/Stichting-MINIX-Research-Foundation/u-boot.git synced 2025-09-09 20:18:54 -04:00
Code Issues Packages Projects Releases Wiki Activity

net/eth.c: Fix env_enetaddr signed overflow

Browse Source 
Assigning the output of simple_strtoul(CB:A9:87:65:43:21) to `char', we are
warned as below:

  U-Boot 1.2.0 (Aug 30 2007 - 08:27:37)

  DRAM:  256 MB
  Flash: 32 MB
  In:    serial
  Out:   serial
  Err:   serial
  Net:   NEC-Candy
  Warning: NEC-Candy MAC addresses don't match:
  Address in SROM is         00:00:4C:80:92:A2
  Address in environment is  FFFFFFCB:FFFFFFA9:FFFFFF87:65:43:21

This patch changes env_enetaddr type from `char' to `unsigned char'.

Cc: Masaki Ishikawa <ishikawa-masaki@cnt.mxe.nes.nec.co.jp>
Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
Signed-off-by: Ben Warren <biggerbadderben@gmail.com>
This commit is contained in:
Shinya Kuribayashi 2007-11-19 20:27:04 +09:00 committed by Ben Warren
parent f85b607105
commit 5ca2d0953e
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
net/eth.c
View File

@ -149,7 +149,8 @@ int eth_register(struct eth_device* dev)
int eth_initialize(bd_t *bis) int eth_initialize(bd_t *bis)
{ {
char enetvar[32], env_enetaddr[6]; char enetvar[32];
unsigned char env_enetaddr[6];
int i, eth_number = 0; int i, eth_number = 0;
char *tmp, *end; char *tmp, *end;