minix/u-boot
1
0
Fork 0
mirror of https://github.com/Stichting-MINIX-Research-Foundation/u-boot.git synced 2025-08-19 03:36:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0

Browse Source 
save_boot_params_default() in cpu.c accesses uninitialized stack area
when it compiled with -O0 (not optimized).
This patch removes save_boot_params_default() and put the equivalent in start.S

Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
Acked-by: Tom Rini <trini@ti.com>
This commit is contained in:
Tetsuyuki Kobayashi 2012-07-06 21:14:20 +00:00 committed by Albert ARIBAUD
parent cca60769fc
commit 6f0dba85a9
2 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
arch/arm/cpu/armv7/cpu.c
View File

@ -38,13 +38,6 @@
#include <asm/armv7.h> #include <asm/armv7.h>
#include <linux/compiler.h> #include <linux/compiler.h>
void save_boot_params_default(u32 r0, u32 r1, u32 r2, u32 r3)
{
}
void save_boot_params(u32 r0, u32 r1, u32 r2, u32 r3)
__attribute__((weak, alias("save_boot_params_default")));
void __weak cpu_cache_initialization(void){} void __weak cpu_cache_initialization(void){}
int cleanup_before_linux(void) int cleanup_before_linux(void)

14
arch/arm/cpu/armv7/start.S
View File

@ -303,6 +303,20 @@ _board_init_r_ofs:
.word board_init_r - _start .word board_init_r - _start
ENDPROC(relocate_code) ENDPROC(relocate_code)
/*************************************************************************
*
* void save_boot_params(u32 r0, u32 r1, u32 r2, u32 r3)
* __attribute__((weak));
*
* Stack pointer is not yet initialized at this moment
* Don't save anything to stack even if compiled with -O0
*
*************************************************************************/
ENTRY(save_boot_params)
bx lr @ back to my caller
ENDPROC(save_boot_params)
.weak save_boot_params
/************************************************************************* /*************************************************************************
* *
* cpu_init_cp15 * cpu_init_cp15