minix/u-boot
1
0
Fork 0
mirror of https://github.com/Stichting-MINIX-Research-Foundation/u-boot.git synced 2025-09-16 15:36:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

env: clean env_nvram.c checkpatch and code style

Browse Source 
Cleanup the env_nvram.c checkpatch warnings, errors and coding style.
There are 2 wanring left about the extern used in c file:
 WARNING: externs should be avoided in .c files
 #53: FILE: env_nvram.c:53:
 +extern void *nvram_read(void *dest, const long src, size_t count);

 WARNING: externs should be avoided in .c files
 #54: FILE: env_nvram.c:54:
 +extern void nvram_write(long dest, const void *src, size_t count);

 total: 0 errors, 2 warnings, 138 lines checked

There is no common nvram header file to use instead of the externs.

Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
This commit is contained in:
Igor Grinberg 2011-11-07 01:14:04 +00:00 committed by Stefano Babic
parent b919ec25e7
commit 91494ca6a0
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
common/env_nvram.c
View File

@ -52,7 +52,7 @@ DECLARE_GLOBAL_DATA_PTR;
#ifdef CONFIG_SYS_NVRAM_ACCESS_ROUTINE #ifdef CONFIG_SYS_NVRAM_ACCESS_ROUTINE
extern void *nvram_read(void *dest, const long src, size_t count); extern void *nvram_read(void *dest, const long src, size_t count);
extern void nvram_write(long dest, const void *src, size_t count); extern void nvram_write(long dest, const void *src, size_t count);
env_t *env_ptr = NULL; env_t *env_ptr;
#else #else
env_t *env_ptr = (env_t *)CONFIG_ENV_ADDR; env_t *env_ptr = (env_t *)CONFIG_ENV_ADDR;
#endif #endif
@ -108,7 +108,6 @@ int saveenv(void)
return rcode; return rcode;
} }
/* /*
* Initialize Environment use * Initialize Environment use
* *
@ -127,12 +126,13 @@ int env_init(void)
gd->env_addr = (ulong)CONFIG_ENV_ADDR + sizeof(long); gd->env_addr = (ulong)CONFIG_ENV_ADDR + sizeof(long);
#else #else
if (crc32(0, env_ptr->data, ENV_SIZE) == env_ptr->crc) { if (crc32(0, env_ptr->data, ENV_SIZE) == env_ptr->crc) {
gd->env_addr = (ulong)&(env_ptr->data); gd->env_addr = (ulong)&env_ptr->data;
#endif #endif
gd->env_valid = 1; gd->env_valid = 1;
} else { } else {
gd->env_addr = (ulong)&default_environment[0]; gd->env_addr = (ulong)&default_environment[0];
gd->env_valid = 0; gd->env_valid = 0;
} }
return (0);
return 0;
} }