nullworks/cathook
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix memory leak in DispatchUserMessage

Browse Source
This commit is contained in:
Unnamed 2018-12-05 10:59:48 +00:00
parent 7ac5cfa0ad
commit 2dcfece72b
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/hooks/DispatchUserMessage.cpp
View File

@ -99,6 +99,8 @@ DEFINE_HOOKED_METHOD(DispatchUserMessage, bool, void *this_, int type,
g_IEngine->ClientCmd_Unrestricted("cat_disconnect;wait 100;cat_mm_join"); g_IEngine->ClientCmd_Unrestricted("cat_disconnect;wait 100;cat_mm_join");
buf.Seek(0); buf.Seek(0);
} }
std::string cleaned_data;
if (type == 4) if (type == 4)
{ {
loop_index = 0; loop_index = 0;
@ -106,7 +108,6 @@ DEFINE_HOOKED_METHOD(DispatchUserMessage, bool, void *this_, int type,
if (s < 256) if (s < 256)
{ {
std::string data; std::string data;
std::string cleaned_data;
for (i = 0; i < s; i++) for (i = 0; i < s; i++)
{ {
char to_app = buf.ReadByte(); char to_app = buf.ReadByte();
@ -253,15 +254,7 @@ DEFINE_HOOKED_METHOD(DispatchUserMessage, bool, void *this_, int type,
} }
} }
chatlog::LogMessage(cleaned_data[0], message); chatlog::LogMessage(cleaned_data[0], message);
char *cleaned_data_c = new char[cleaned_data.size()+1]; buf = bf_read(cleaned_data.c_str(), cleaned_data.size());
int idx = 0;
for (char i : cleaned_data)
{
cleaned_data_c[idx] = i;
idx++;
}
cleaned_data_c[cleaned_data.size()] = '\0';
buf = bf_read(cleaned_data_c, cleaned_data.size());
buf.Seek(0); buf.Seek(0);
} }
} }