nullworks/cathook
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make randoms not depend on rand() (#1135)

Browse Source 
* Make randoms not depend on rand()

Changed UniformRandomInt and RandFloatRange to not depend on rand, because this can cause little to no randomness depending on system.
This commit is contained in:
aUniqueUser 2020-10-19 16:11:07 -04:00 committed by GitHub
parent 54aafc5d18
commit be4baf0f18
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/helpers.cpp
View File

@ -962,34 +962,19 @@ bool AmbassadorCanHeadshot()
return true;
}
static std::random_device random_device;
static std::mt19937 engine{random_device()};
float RandFloatRange(float min, float max)
{
return (min + 1) + (((float) rand()) / (float) RAND_MAX) * (max - (min + 1));
std::uniform_real_distribution<float> random(min, max);
return random(engine);
}
int UniformRandomInt(int min, int max)
{
uint32_t bound, len, r, result = 0;
/* Protect from random stupidity */
if (min > max)
std::swap(min, max);
len = max - min + 1;
/* RAND_MAX is implementation dependent.
* It's guaranteed that this value is at least 32767.
* glibc's RAND_MAX is 2^31 - 1 exactly. Since source games hard
* depend on glibc, we will do so as well
*/
while (len)
{
bound = (1U + RAND_MAX) % len;
while ((r = rand()) < bound)
;
result *= 1U + RAND_MAX;
result += r % len;
len -= len > RAND_MAX ? RAND_MAX : len;
}
return int(result) + min;
std::uniform_int_distribution<int> random(min, max);
return random(engine);
}
bool IsEntityVisible(CachedEntity *entity, int hb)