oneechanhax/phunix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fail unsafe sdevio. Disallow unaligned I/O ports.

Browse Source
This commit is contained in:
Philip Homburg 2007-04-23 13:22:26 +00:00
parent bc17115a34
commit 2b2d3d5131
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
kernel/arch/i386/do_sdevio.c
View File

@ -71,14 +71,27 @@ register message *m_ptr; /* pointer to request message */
return(EPERM); return(EPERM);
} else { } else {
if(proc_nr != who_p) if(proc_nr != who_p)
kprintf("unsafe sdevio by %d in %d\n", who_e, proc_nr_e); {
kprintf("do_sdevio: unsafe sdevio by %d in %d denied\n",
who_e, proc_nr_e);
return EPERM;
}
/* Get and check physical address. */ /* Get and check physical address. */
if ((phys_buf = numap_local(proc_nr, if ((phys_buf = numap_local(proc_nr,
(vir_bytes) m_ptr->DIO_VEC_ADDR, count)) == 0) (vir_bytes) m_ptr->DIO_VEC_ADDR, count)) == 0)
return(EFAULT); return(EFAULT);
} }
switch (io_type)
{
case _DIO_BYTE: size= 1; break;
case _DIO_WORD: size= 2; break;
case _DIO_LONG: size= 4; break;
default: size= 4; break; /* Be conservative */
}
rp= proc_addr(who_p); rp= proc_addr(who_p);
privp= priv(rp);
if (privp && privp->s_flags & CHECK_IO_PORT) if (privp && privp->s_flags & CHECK_IO_PORT)
{ {
switch (io_type) switch (io_type)
@ -104,6 +117,12 @@ register message *m_ptr; /* pointer to request message */
} }
} }
if (port & (size-1))
{
kprintf("do_devio: unaligned port 0x%x (size %d)\n", port, size);
return EPERM;
}
/* Perform device I/O for bytes and words. Longs are not supported. */ /* Perform device I/O for bytes and words. Longs are not supported. */
if (req_dir == _DIO_INPUT) { if (req_dir == _DIO_INPUT) {
switch (req_type) { switch (req_type) {
@ -125,4 +144,3 @@ register message *m_ptr; /* pointer to request message */
} }
#endif /* USE_SDEVIO */ #endif /* USE_SDEVIO */