oneechanhax/phunix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pm - sys_sigsend can fail legitimately

Browse Source 
. specifically, if a signal handler can't be invoked due
    to process memory, EFAULT is returned from the kernel.
    don't panic() then.
This commit is contained in:
Ben Gras 2011-02-18 15:44:54 +00:00
parent 8f860a27d1
commit 32f3d9842d
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
servers/pm/signal.c
View File

@ -449,6 +449,8 @@ int ksig; /* non-zero means signal comes from kernel */
return; return;
/* We were unable to spawn a signal handler. Kill the process. */ /* We were unable to spawn a signal handler. Kill the process. */
printf("PM: %d can't catch signal %d - killing\n",
rmp->mp_pid, signo);
} }
else if (!badignore && sigismember(&ign_sset, signo)) { else if (!badignore && sigismember(&ign_sset, signo)) {
/* Signal defaults to being ignored. */ /* Signal defaults to being ignored. */
@ -732,8 +734,16 @@ int signo; /* signal to send to process (1 to _NSIG-1) */
/* Ask the kernel to deliver the signal */ /* Ask the kernel to deliver the signal */
r = sys_sigsend(rmp->mp_endpoint, &sigmsg); r = sys_sigsend(rmp->mp_endpoint, &sigmsg);
if (r != OK) /* sys_sigsend can fail legitimately with EFAULT if
* the process memory can't accomodate the signal handler.
*/
if(r == EFAULT) {
return(FALSE);
}
/* Other errors are unexpected pm/kernel discrepancies. */
if (r != OK) {
panic("sys_sigsend failed: %d", r); panic("sys_sigsend failed: %d", r);
}
/* Was the process suspended in PM? Then interrupt the blocking call. */ /* Was the process suspended in PM? Then interrupt the blocking call. */
if (rmp->mp_flags & (PAUSED | WAITING | SIGSUSPENDED)) { if (rmp->mp_flags & (PAUSED | WAITING | SIGSUSPENDED)) {