oneechanhax/phunix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

readclock/tda19988: fix compiler/cppcheck warnings

Browse Source 
readclock:
 - the setup function for readclock on i386 was missing a return.
 - the message field for RTCDEV_GRANT wasn't the right type.

tda19988:
 - position variable was used without being initialized.

Change-Id: I3f78dd0a9d44f35eb38cb7da0974909f066b7007
This commit is contained in:
Thomas Cort 2013-08-10 18:30:42 +00:00
parent 039c8db774
commit 6405d78182
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/readclock/arch/i386/arch_readclock.c
View File

@ -94,6 +94,8 @@ arch_setup(struct rtc *r)
r->set_time = arch_set_time; r->set_time = arch_set_time;
r->pwr_off = arch_pwr_off; r->pwr_off = arch_pwr_off;
r->exit = arch_exit; r->exit = arch_exit;
return OK;
} }
static int static int

3
drivers/tda19988/tda19988.c
View File

@ -232,7 +232,6 @@ tda19988_blk_transfer(dev_t minor, int do_write, u64_t pos64,
struct device *dv; struct device *dv;
u64_t dv_size; u64_t dv_size;
int r; int r;
u64_t position;
cp_grant_id_t grant; cp_grant_id_t grant;
log_trace(&log, "tda19988_blk_transfer()\n"); log_trace(&log, "tda19988_blk_transfer()\n");
@ -265,7 +264,7 @@ tda19988_blk_transfer(dev_t minor, int do_write, u64_t pos64,
/* don't go past the end of the device */ /* don't go past the end of the device */
if (pos64 + count > dv_size) { if (pos64 + count > dv_size) {
count = dv_size - position; count = dv_size - pos64;
} }
/* don't overflow copybuf */ /* don't overflow copybuf */

2
include/minix/com.h
View File

@ -1333,7 +1333,7 @@
#define RTCDEV_TM m2_p1 /* pointer to struct tm */ #define RTCDEV_TM m2_p1 /* pointer to struct tm */
#define RTCDEV_FLAGS m2_s1 /* clock flags flags */ #define RTCDEV_FLAGS m2_s1 /* clock flags flags */
#define RTCDEV_STATUS m2_i2 /* OK or error code */ #define RTCDEV_STATUS m2_i2 /* OK or error code */
#define RTCDEV_GRANT m2_p1 /* grant containing struct tm */ #define RTCDEV_GRANT m2_i3 /* grant containing struct tm */
/* Bits in 'RTCDEV_FLAGS' field of real time clock requests. */ /* Bits in 'RTCDEV_FLAGS' field of real time clock requests. */
#define RTCDEV_NOFLAGS 0x00 /* no flags are set */ #define RTCDEV_NOFLAGS 0x00 /* no flags are set */