David van Moolenbroek 5b1db95619 IPC server: subscribe to process events on demand
As mentioned in previous patches, services may not subscribe to
process events from specific processes only, since this results in
race conditions.  However, the IPC server can safely turn on and off
its entire subscription based on whether any System V IPC semaphores
(and, in the future, message queues) are allocated at all.  Since
the System V IPC facilities are not so commonly used, this removes
the extra round trip from PM to the IPC server and back for caught
signals and process exits in the common case.

Change-Id: I937259034872be32f4e26ab99270f4d475ff6134
2016-01-16 14:04:11 +01:00

211 lines
4.8 KiB
C

#include "inc.h"
#define SEM_EVENTS 0x01 /* semaphore code wants process events */
static unsigned int event_mask = 0;
static int verbose = 0;
/*
* The call table for this service.
*/
#define CALL(n) [((n) - IPC_BASE)]
static int (* const call_vec[])(message *) = {
CALL(IPC_SHMGET) = do_shmget,
CALL(IPC_SHMAT) = do_shmat,
CALL(IPC_SHMDT) = do_shmdt,
CALL(IPC_SHMCTL) = do_shmctl,
CALL(IPC_SEMGET) = do_semget,
CALL(IPC_SEMCTL) = do_semctl,
CALL(IPC_SEMOP) = do_semop,
};
/*
* Initialize the IPC server.
*/
static int
sef_cb_init_fresh(int type __unused, sef_init_info_t * info __unused)
{
/* Nothing to do. */
return OK;
}
/*
* The service has received a signal.
*/
static void
sef_cb_signal_handler(int signo)
{
/* Only check for termination signal, ignore anything else. */
if (signo != SIGTERM) return;
/*
* Check if there are still IPC keys around. If not, we can safely
* exit immediately. Otherwise, warn the system administrator.
*/
if (is_sem_nil() && is_shm_nil())
sef_exit(0);
printf("IPC: exit with unclean state\n");
}
/*
* Perform SEF initialization.
*/
static void
sef_local_startup(void)
{
/* Register init callbacks. */
sef_setcb_init_fresh(sef_cb_init_fresh);
sef_setcb_init_restart(sef_cb_init_fresh);
/* Register signal callbacks. */
sef_setcb_signal_handler(sef_cb_signal_handler);
/* Let SEF perform startup. */
sef_startup();
}
/*
* Update the process event subscription mask if necessary, after one of the
* modules has changed its subscription needs. This code is set up so that
* support for SysV IPC message queues can be added easily later.
*/
static void
update_sub(unsigned int new_mask)
{
/* If the old and new mask are not both zero or nonzero, update. */
if (!event_mask != !new_mask) {
/*
* Subscribe to PM process events, or unsubscribe. While it
* might be tempting to implement a system that subscribes to
* events only from processes that are actually blocked (or
* using the SysV IPC facilities at all), this would result in
* race conditions where subscription could happen "too late"
* for an ongoing signal delivery, causing the affected process
* to deadlock. Subscribing to events from any other call is
* safe however, and we exploit that to limit the kernel-level
* message passing overhead in the common case (which is that
* the IPC servier is not being used at all). After we have
* unsubscribed, we may still get a few leftover events for the
* previous subscription, and we must properly reply to those.
*/
if (new_mask)
proceventmask(PROC_EVENT_EXIT | PROC_EVENT_SIGNAL);
else
proceventmask(0);
}
event_mask = new_mask;
}
/*
* Update the process event subscription mask for the semaphore code.
*/
void
update_sem_sub(int want_events)
{
unsigned int new_mask;
new_mask = event_mask & ~SEM_EVENTS;
if (want_events)
new_mask |= SEM_EVENTS;
update_sub(new_mask);
}
/*
* PM sent us a process event message. Handle it, and reply.
*/
static void
got_proc_event(message * m)
{
endpoint_t endpt;
int r, has_exited;
endpt = m->m_pm_lsys_proc_event.endpt;
has_exited = (m->m_pm_lsys_proc_event.event == PROC_EVENT_EXIT);
/*
* Currently, only semaphore handling needs to know about processes
* being signaled and exiting.
*/
if (event_mask & SEM_EVENTS)
sem_process_event(endpt, has_exited);
/* Echo the request as a reply back to PM. */
m->m_type = PROC_EVENT_REPLY;
if ((r = asynsend3(m->m_source, m, AMF_NOREPLY)) != OK)
printf("IPC: replying to PM process event failed (%d)\n", r);
}
/*
* The System V IPC server.
*/
int
main(int argc, char ** argv)
{
message m;
unsigned int call_index;
int r, ipc_status;
/* SEF local startup. */
env_setargs(argc, argv);
sef_local_startup();
/* The main message loop. */
for (;;) {
if ((r = sef_receive_status(ANY, &m, &ipc_status)) != OK)
panic("IPC: sef_receive_status failed: %d", r);
if (verbose)
printf("IPC: got %d from %d\n", m.m_type, m.m_source);
if (is_ipc_notify(ipc_status)) {
printf("IPC: ignoring notification from %d\n",
m.m_source);
continue;
}
/* Process event messages from PM are handled separately. */
if (m.m_source == PM_PROC_NR && m.m_type == PROC_EVENT) {
got_proc_event(&m);
continue;
}
/* Dispatch the request. */
call_index = (unsigned int)(m.m_type - IPC_BASE);
if (call_index < __arraycount(call_vec) &&
call_vec[call_index] != NULL) {
r = call_vec[call_index](&m);
} else
r = ENOSYS;
/* Send a reply, if needed. */
if (r != SUSPEND) {
if (verbose)
printf("IPC: call result %d\n", r);
m.m_type = r;
/*
* Other fields may have been set by the handler
* function already.
*/
if ((r = ipc_sendnb(m.m_source, &m)) != OK)
printf("IPC: send error %d\n", r);
}
/* XXX there must be a better way to do this! */
update_refcount_and_destroy();
}
/* NOTREACHED */
return 0;
}