SomeTroglodyte
29e32303ec
Replace incorrect GraphicsEnvironment.maximumWindowBounds ( #10117 )
2023-09-18 09:46:44 +03:00
SomeTroglodyte
a3d431155d
A "Status" column for City Overview ( #10126 )
...
* Avoid the detekt false positive for typed lambda `it` and its comment
* Fix regression of what-is-a-garrison (8952)
* Initial implementation of "Status" column
* "Status" column gets a header icon
2023-09-18 09:46:29 +03:00
SpacedOutChicken
9e1ea2d4cb
Remove Faith bonus from Vanilla Siam ( #10141 )
...
* Destroy Arsenal when city is captured
* Remove unused Faith bonus from Siam unique
2023-09-18 08:21:27 +03:00
Framonti
fba3198887
Unit tests for Battle.kt ( #10127 )
...
* ✨ add testing helper function to create the barbarian civilization
* add tests for Battle class
* add more tests for Battle class
* ♻️ let compiler infer types
* add helper test methods to create unit with uniques
* use unit with unique explicitly created to loose tests from specific ruleset
* add even more tests for Battle
2023-09-14 18:53:40 +03:00
Yair Morgenstern
bdd3af9a43
docs: linting - List for victory illustrations to be shown as list
2023-09-14 09:09:53 +03:00
SomeTroglodyte
e59426fb03
Generic Widget/Provider framework for sortable grids ( #8962 )
...
* City Overview reorg - adding a Column should get easier
* City Overview reorg - patch
* City Overview reorg - SortableGrid Widget
* SortableGrid Widget - cleanup
* Generalize equalizeColumns
* SortableGrid framework - cleaner v2
* Revert file rename to facilitate merge
* Post-merge missed change
* SortableGrid merge fix
* Resolve wildcard import
* Post-merge fix: showOneTimeNotification
* Post-merge fixes
* Post-merge cleanup
* More Post-merge cleanup
* Fix sort (bug symptom: dependence on column click order)
* Tooltip update to "fix" icons if hideIcons=false
* Allow hideIcons control for grid header Tooltip
* Lint String.tr() Kdoc
* Move getComparator() default implementation to interface
* Nicer getComparator() implementations, better sorting for WLTK column
* Fix "Tooltip update to "fix" icons" reverting tooltip color
* Suppress detekt false positives
* Fix merge error
2023-09-13 19:42:22 +03:00
Yair Morgenstern
fe18a22cf7
4.8.5
...
Replace double quotes with single ones, so the android deploy works
2023-09-13 12:04:11 +03:00
Yair Morgenstern
0be6cd062f
4.8.5
2023-09-13 11:17:57 +03:00
Yair Morgenstern
55809c9b22
Unique deprecation - "Receive free [unit] when you discover [tech]" replaced with trigger + condition, tested
2023-09-13 11:11:37 +03:00
Yair Morgenstern
550e18689a
Version rollout ( #10115 )
...
* Bump version and create initial changelog entry
* Update Korean.properties (#10112 )
* Update Polish.properties (#10110 )
* Update Brazilian_Portuguese.properties (#10109 )
* Update Simplified_Chinese (#10108 )
* russian (#10106 )
* Update Russian.properties
Corrections some cities
* Update Russian.properties
def. pact with..
* Update Spanish.properties (#10105 )
* Japanese translation (#10104 )
* Randomly chose not translated strings.
* Some more translation
* Some more translation
* Added more translation
* Chinese names
* Update Japanese.properties
Fixed 2 typos
* Update Catalan.properties (#10103 )
* Update French.properties (#10102 )
* Update German translation (#10099 )
* Update Italian.properties (#10098 )
* Update Italian.properties (#10097 )
Co-authored-by: Tommaso Petrolito <tpetrolito@deloitte.it>
---------
Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Yattong the Mackerel <saud2410@naver.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: chr_56 <30681738+chr56@users.noreply.github.com>
Co-authored-by: Anoant <143289571+Anoant@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: 有賀 清一 Seiichi Ariga <seiichi.ariga@gmail.com>
Co-authored-by: Joan Josep <juanjo.ng.83@gmail.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: mape6 <mape6@posteo.de>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: TommasoPetrolito <tommasouni@gmail.com>
Co-authored-by: Tommaso Petrolito <tpetrolito@deloitte.it>
2023-09-13 10:33:59 +03:00
Oskar Niesen
16d716d794
Removed double notifications and processing of treaties when traded ( #10101 )
...
* Removed double notifications and processing of treaties when traded
* Added comment to only processing one side of the trade
2023-09-13 10:28:07 +03:00
SomeTroglodyte
8e3ebc7724
Global Constructions Blacklist ( #10061 )
...
* Improved handling of "Nothing" construction
* Suppress "All" entries when you have only one city
* Global Construction Blacklist
* Reviews
* Reviews - missed renames
2023-09-13 10:27:43 +03:00
SomeTroglodyte
8aeae30050
Prevent selling free buildings ( #10094 )
...
* A few yield extensions - use in existing code to do later
* Refactor getFreeBuildings to allow hasFreeBuilding not enumerating all
* Prevent selling free buildings - with a little easter egg
* Test translatability
* Shift "Free Building" methods towards preferring object parameters
* Remove easter egg
* Linting and improving Kdoc precision
* Linting and improving Kdoc precision: CityConstructions
2023-09-13 10:27:32 +03:00
SomeTroglodyte
6016754a18
Defense against Circular upgrade paths in mods ( #10114 )
...
* Convert stack overflow into explicit exception when a mod has recursive unit upgrade/replaces
* RulesetValidator detects recursive unit upgrade/replaces
2023-09-13 10:26:47 +03:00
Yair Morgenstern
b4a2b5cc3b
4.8.4
2023-09-11 10:09:10 +03:00
Yair Morgenstern
824b0d2af9
Version rollout ( #10096 )
...
* Bump version and create initial changelog entry
* Update Korean.properties (#10093 )
* Update Spanish.properties (#10084 )
* Update Italian.properties (#10082 )
---------
Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Yattong the Mackerel <saud2410@naver.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
2023-09-11 09:47:55 +03:00
SeventhM
c2acdadc50
Fix unique Great Prophets not having the correct cost when buying at an increasing cost ( #10095 )
2023-09-11 09:29:25 +03:00
SeventhM
2061b2cc03
Fix free units with a build limit not spawning ( #10091 )
...
* Fix free units with a build limit not spawning
* Flip the amount when at the limit
* Unrelated linting
2023-09-11 09:29:18 +03:00
SeventhM
fbb516f90f
Fix AI getting stuck when it can't promote with enough xp ( #10089 )
...
* Fix AI getting stuck when it can't promote with enough xp
* Reverse the check for promotions
* Forgot to remove extra break
2023-09-11 09:29:06 +03:00
SomeTroglodyte
19f9cba058
Allow the Space key to close Alert popups with no actual choice ( #10085 )
2023-09-11 09:28:59 +03:00
Oskar Niesen
c3484381c3
Fixed politics tab not showing defensive pacts ( #10079 )
...
* Override DoF displayed on Politics table with defensive pact when applicable and added CYAN color to table and diagram.
* City-state alliances now show as CYAN in the politics table
2023-09-11 09:28:52 +03:00
Oskar Niesen
ee81b3e84e
Defensive pact Tests ( #10088 )
2023-09-11 09:06:09 +03:00
Framonti
885675bea3
💚 add tests for Diplomacy manager ( #10087 )
2023-09-09 21:27:03 +03:00
Yair Morgenstern
9e557c8890
Update Privacy-Policy.md
2023-09-07 18:23:33 +03:00
Yair Morgenstern
06c14cd520
4.8.3
2023-09-07 10:19:02 +03:00
Yair Morgenstern
a68f7db463
Version rollout ( #10080 )
...
* Bump version and create initial changelog entry
* Update Polish.properties (#10075 )
* Update Brazilian_Portuguese.properties (#10074 )
* Update Russian.properties (#10073 )
* Update Russian.properties
* Update Russian.properties
New string and corrects
* Update Russian.properties
#2
* Update Russian.properties
*3
* Update German translation (#10069 )
* Update Dutch.properties (#10067 )
* Update French.properties (#10066 )
---------
Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Anoant <143289571+Anoant@users.noreply.github.com>
Co-authored-by: mape6 <mape6@posteo.de>
Co-authored-by: Lena Bullens <95299589+LenaBullens@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
2023-09-07 10:13:19 +03:00
Yair Morgenstern
30570747a8
Unify placeholder parsing for unique parameters ( #10072 )
...
* Unify placeholder parsing for unique parameters
* Remove double "remove conditional" call - kudos @SomeTroglodyte
2023-09-07 09:57:40 +03:00
Yair Morgenstern
e8c740da31
build: unify coroutines version to buildconfig variable
2023-09-06 15:20:32 +03:00
Yair Morgenstern
55a3fa2a75
cleanup: Copy Zero vectors before passing to localToStageCoordinates ( #10048 )
2023-09-06 12:38:14 +03:00
Yair Morgenstern
7597447b7e
build: Change Docker JDK download to adoptium used in other releases
2023-09-06 12:35:00 +03:00
Yair Morgenstern
0c089f0e6d
Revert "build: Kotlin plugins tied to kotlin version"
...
This reverts commit d7ccc11d8c8cbe02ad0ef3f7db0ce7e403181f0c.
2023-09-06 12:24:33 +03:00
Yair Morgenstern
4081b76025
build: removed 'testImplementation' double-imports for tests project
2023-09-06 12:18:31 +03:00
Yair Morgenstern
adbbb18685
build: remove unused mockk library
2023-09-06 12:11:55 +03:00
Yair Morgenstern
d7ccc11d8c
build: Kotlin plugins tied to kotlin version
2023-09-06 12:05:07 +03:00
Yair Morgenstern
057b2e1d5b
chore: upgrade androidx versions
...
Resolves #9966
2023-09-06 12:00:30 +03:00
Framonti
538330db87
Test/refactor target helper and test it ( #10048 )
...
* ♻️ merge together two branches executing same code
* ♻️ swap if-else chain with when to improve readability
* ⚡ ️ swap conditions to first check the lighter computationally-wise
* ♻️ extract method to increase readability
* 💚 add some tests for TargetHelper
* 💡 add comment explaining how Unciv grid system works using a graphical example
* 💚 add other tests
* ♻️ change method name to better reflect what it does
* 🐛 fix import after rebase
* 🔥 remove parameter when value is the default and use static field for Vector2(0f, 0f)
* ♻️ split setTileTerrainAndFeatures in two different methods
* ♻️ update older tests to use the new functions
2023-09-05 22:25:28 +03:00
Yair Morgenstern
e80acdbb6a
4.8.2
2023-09-05 19:14:04 +03:00
Yair Morgenstern
4f9dc953cb
Version rollout ( #10065 )
...
* Bump version and create initial changelog entry
* Update Polish.properties (#10057 )
* Update German translation (#10056 )
* Update Spanish.properties (#10051 )
* Update French.properties (#10049 )
* Update Italian.properties (#10046 )
---------
Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: mape6 <mape6@posteo.de>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
2023-09-05 19:10:29 +03:00
Yair Morgenstern
4ddaf9b2c4
performance: Don't enqueue multiplayer game update for 0 games
2023-09-05 19:07:36 +03:00
SomeTroglodyte
855b2959a1
Fix Map Editor double map holders after ruleset change ( #10047 )
...
* Fix Map Editor double map holders after ruleset change
* Fix buttons are vertical in AskFitMapToRulesetPopup
* Sort imports over mapeditor package
2023-09-05 19:02:36 +03:00
SomeTroglodyte
5bccc4abf3
Fix longpress triggering when an onClick discards its actor ( #10052 )
2023-09-05 19:02:27 +03:00
Oskar Niesen
eec3732c96
Defensive pact notification fix ( #10025 )
...
* Fixed Civ getting two notifications of canceling their defensive pact when attacking.
* Added Defensive Pact related warnings to the Declare War popup
* Improved the warning to not include Civs that are already at war with the aggressor
* Improved the warning to not include Civs that are already at war with the aggressor
* Added defensive pact related warning translations
* Refactored removeDefensivePacts
* DeclareWarButton text now uses arrayListOf<String> and changed the for loop to a while loop
* Extracted the DeclareWarButton text to a new method.
2023-09-05 19:01:45 +03:00
Yair Morgenstern
a4cc566a8a
performance: Don't autoupdate multiplayer games more than a week old - they're inactive games
2023-09-05 19:00:44 +03:00
Yair Morgenstern
5cc57f9293
performance: Don't calc checksum for non-multiplayer games, no one cares if you hack your own game
2023-09-05 18:52:42 +03:00
SomeTroglodyte
a2fa4cebf4
Improve BaseUnit hasUnique(FoundCity) handling ( #10063 )
2023-09-05 15:40:55 +03:00
SomeTroglodyte
f7069851c7
Fix Gdx not forced to UTF-8 when saving a game ( #10062 )
2023-09-05 14:35:54 +03:00
Yair Morgenstern
93f882d3c8
tests: Load vanilla game test fixed
2023-09-04 17:08:52 +03:00
Yair Morgenstern
e58dd7c1f6
Buildings missing from ruleset are removed from loaded games *properly*
2023-09-04 16:42:21 +03:00
Yair Morgenstern
df03f36207
chore: Added missing imports
2023-09-04 16:09:55 +03:00
Yair Morgenstern
f4c7dc4890
chore: Reorg tests, so /testing folder contains only test-helper classes
2023-09-04 16:06:06 +03:00
