psi29a
cc68316f72
Merge branch 'lua-jail-skills' into 'master'
...
Bring jail time skill changes over to lua
Closes #8399
See merge request OpenMW/openmw!4593
2025-08-02 08:39:14 +00:00
Mads Buvik Sandvei
978d8668f4
Bring jail time skill changes over to lua
2025-08-02 08:39:13 +00:00
Evil Eye
dbd92e6844
Merge branch 'spacetraining' into 'master'
...
Training menu fixes (#8584 )
Closes #8584
See merge request OpenMW/openmw!4758
2025-08-02 07:04:02 +00:00
Alexei Kotov
4c4d6078d8
Training menu fixes ( #8584 )
...
Rework the layout
Use "OK" instead of "Cancel" for the OK button
Add gp to the price
Use entry spacing consistent with other service menus
2025-08-02 03:47:22 +03:00
psi29a
b160cee0b7
Merge branch 'sonarview' into 'master'
...
Address string_view conversions flagged by SonarQube
See merge request OpenMW/openmw!4693
2025-08-01 08:06:36 +00:00
psi29a
2a8dc56619
Merge branch 'pedanticmsvc' into 'master'
...
Resolve unused code warnings when compiling in Debug mode using MSVC
See merge request OpenMW/openmw!4820
2025-08-01 08:06:11 +00:00
Skyhasacat
04f42f12e1
Merge branch 'onUpdate' into 'master'
...
Run onUpdate when the game is paused
Closes #8012
See merge request OpenMW/openmw!4487
2025-08-01 02:11:21 +00:00
Andrei Kortunov
645eb81133
Run onUpdate when the game is paused
2025-08-01 04:18:03 +03:00
psi29a
405388b89f
Merge branch 'scripteditorplz' into 'master'
...
Improve multiline script editing
Closes #8579
See merge request OpenMW/openmw!4728
2025-07-31 07:21:06 +00:00
Skyhasacat
27e1a842a0
Merge branch 'partially-dehardcode-onhit' into 'master'
...
[Lua] Partially dehardcode onHit
See merge request OpenMW/openmw!4334
2025-07-30 20:21:15 +00:00
Mads Buvik Sandvei
34eb3d485d
[Lua] Partially dehardcode onHit
2025-07-30 20:21:15 +00:00
Evil Eye
2efa76052f
Merge branch 'master' into 'master'
...
Update Installation Instructions to include Fedora installation
See merge request OpenMW/openmw!4819
2025-07-30 19:22:56 +00:00
Evil Eye
bc05628fa8
Resolve unused code warnings when compiling in Debug mode using MSVC
2025-07-30 20:44:59 +02:00
Evil Eye
75845bf863
Work around compiler versions that haven't addressed defect 3865
2025-07-30 19:41:14 +02:00
Evil Eye
ee540039a1
Address string_view conversions flagged by SonarQube
2025-07-30 19:37:37 +02:00
Claire
24c7d2f075
Edit install-openmw.rst
2025-07-30 09:54:54 -07:00
Claire
62492c7738
Edit install-openmw.rst
2025-07-30 09:11:00 -07:00
Claire
442e8796b4
Edit install-openmw.rst
2025-07-30 09:08:56 -07:00
Evil Eye
27ee192354
Set default hotkeys for (un)commenting script lines
2025-07-30 16:58:32 +02:00
Evil Eye
aefa0ec1c4
Add multiline (un)indent behaviour to the script editor
2025-07-30 16:58:32 +02:00
Alexei Kotov
399ec4eccc
Merge branch 'qt6' into 'master'
...
Drop support for Qt5
Closes #8578
See merge request OpenMW/openmw!4742
2025-07-30 13:26:46 +03:00
Alexei Kotov
b0e8544d58
Merge branch 'addthoseactivespells' into 'master'
...
Remove minimum duration from continuous effects and add clarification to the docs
Closes #8641
See merge request OpenMW/openmw!4817
2025-07-29 23:36:39 +03:00
Alexei Kotov
0e8ca0cf19
Merge branch 'changelog' into 'master'
...
Sync changelog
See merge request OpenMW/openmw!4816
2025-07-29 23:36:05 +03:00
Claire
b7fe1a6eb2
Edit install-openmw.rst
2025-07-29 11:59:42 -07:00
psi29a
b937b0271f
Merge branch 'fightthechameleon' into 'master'
...
Prevent witnesses from ending combat because they didn't get hit
See merge request OpenMW/openmw!4814
2025-07-29 07:43:59 +00:00
Alexei Kotov
45a7040bc7
Merge branch 'fix_tests' into 'master'
...
Make tests more stable
See merge request OpenMW/openmw!4818
2025-07-29 08:05:58 +03:00
AnyOldName3
7c3fa3c89f
Merge branch 'classheader' into 'master'
...
Some include cleanup
See merge request OpenMW/openmw!4815
2025-07-28 22:35:24 +00:00
Alexei Kotov
ebcacf04bc
Sync changelog for 0.50.0
2025-07-28 23:12:52 +03:00
elsid
70207750f2
Make tests more stable
2025-07-28 20:23:45 +02:00
Evil Eye
395f6811c9
Remove minimum duration from continuous effects and add clarification to the docs
2025-07-28 18:59:23 +02:00
psi29a
176dab5b3d
Merge branch 'nomagnitudeforyou' into 'master'
...
Don't multiply magnitudes for effects that don't have magnitudes
Closes #8540
See merge request OpenMW/openmw!4810
2025-07-28 15:59:13 +00:00
psi29a
e304ceb449
Merge branch 'fix_init' into 'master'
...
Do not copy cell store to count refs
See merge request OpenMW/openmw!4813
2025-07-28 15:58:46 +00:00
psi29a
4efc8bf99d
Merge branch 'fix_clang_tidy' into 'master'
...
Fix clang tidy warnings
See merge request OpenMW/openmw!4811
2025-07-28 15:55:53 +00:00
Alexei Kotov
0a8373987d
Merge branch 'aiwander' into 'master'
...
Build checkpoints based path for wandering actors (#8433 )
Closes #8433
See merge request OpenMW/openmw!4652
2025-07-28 00:48:17 +03:00
Alexei Kotov
272e6fabf9
Turn GreetingState into enum class and cut some mechanics manager includes
2025-07-27 23:02:06 +03:00
Evil Eye
f6a6a33c59
Prevent witnesses from ending combat because they didn't get hit
2025-07-27 21:12:52 +02:00
Alexei Kotov
ee501d8d0d
Remove some redundant class header includes
2025-07-27 22:02:02 +03:00
elsid
e77ee5c20f
Do not copy cell store to count refs
2025-07-27 18:40:39 +02:00
psi29a
2051d5cbef
Merge branch 'master' into 'master'
...
Fixed Unit Test in `apps/openmw_tests/mwworld/testptr.cpp`
See merge request OpenMW/openmw!4807
2025-07-27 16:33:39 +00:00
Claire
af58da58fd
Fixed Unit Test in apps/openmw_tests/mwworld/testptr.cpp
2025-07-27 16:33:38 +00:00
psi29a
d3309e0a8d
Merge branch 'vfxdocs' into 'master'
...
Fix useAmbientLight references in docs
See merge request OpenMW/openmw!4803
2025-07-27 16:33:22 +00:00
psi29a
7637ca536b
Merge branch 'turnedwerewolf' into 'master'
...
Remove completion threshold-based turning for the player (#8447 )
Closes #8447
See merge request OpenMW/openmw!4628
2025-07-27 16:32:43 +00:00
psi29a
7aeff7e473
Merge branch 'combatparalysis' into 'master'
...
Put combat actions on hold when the actor is incapacitated (#7979 )
Closes #7979
See merge request OpenMW/openmw!4597
2025-07-27 16:32:22 +00:00
psi29a
02102eeeca
Merge branch 'instantmagicjustaddwater' into 'master'
...
Update effects upon applying them
Closes #7996
See merge request OpenMW/openmw!4124
2025-07-27 16:30:56 +00:00
psi29a
c8aa644111
Merge branch 'collisionprediction' into 'master'
...
Avoid recomputing collision prediction things an extra N times (#8548 )
Closes #8548
See merge request OpenMW/openmw!4801
2025-07-27 16:30:11 +00:00
Evil Eye
aae954643c
Don't multiply magnitudes for effects that don't have magnitudes
2025-07-27 12:47:35 +02:00
elsid
c6f381f1c4
Ignore readability-identifier-naming for boost::program_options namespace alias
2025-07-27 12:21:13 +02:00
elsid
8682ea522f
Remove unused namespace alias
2025-07-27 12:20:10 +02:00
elsid
ec0c76d2f3
Ignore false positive warning
...
cellSize > 1 so the result of the division cannot be undefined.
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:18:35: error: The result of the '/' expression is undefined [clang-analyzer-core.UndefinedBinaryOperatorResult,-warnings-as-errors]
18 | std::size_t cell = global / (cellSize - 1);
| ^
/home/elsid/dev/openmw/components/esmterrain/storage.cpp:244:13: note: Assuming 'lodLevel' is >= 0
244 | if (lodLevel < 0 || 63 < lodLevel)
| ^~~~~~~~~~~~
/home/elsid/dev/openmw/components/esmterrain/storage.cpp:244:13: note: Left side of '||' is false
/home/elsid/dev/openmw/components/esmterrain/storage.cpp:244:29: note: Assuming 'lodLevel' is <= 63
244 | if (lodLevel < 0 || 63 < lodLevel)
| ^~~~~~~~~~~~~
/home/elsid/dev/openmw/components/esmterrain/storage.cpp:244:9: note: Taking false branch
244 | if (lodLevel < 0 || 63 < lodLevel)
| ^
/home/elsid/dev/openmw/components/esmterrain/storage.cpp:247:13: note: Assuming 'size' is > 0
247 | if (size <= 0)
| ^~~~~~~~~
/home/elsid/dev/openmw/components/esmterrain/storage.cpp:247:9: note: Taking false branch
247 | if (size <= 0)
| ^
/home/elsid/dev/openmw/components/esmterrain/storage.cpp:272:13: note: Assuming the condition is false
272 | if (land != nullptr)
| ^~~~~~~~~~~~~~~
/home/elsid/dev/openmw/components/esmterrain/storage.cpp:272:9: note: Taking false branch
272 | if (land != nullptr)
| ^
/home/elsid/dev/openmw/components/esmterrain/storage.cpp:363:9: note: Calling 'sampleCellGrid<const (lambda at /home/elsid/dev/openmw/components/esmterrain/storage.cpp:280:35) &>'
363 | sampleCellGrid(cellSize, sampleSize, beginX, beginY, distance, handleSample);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:72:13: note: Assuming 'cellSize' is >= 2
72 | if (cellSize < 2 || !Misc::isPowerOfTwo(cellSize - 1))
| ^~~~~~~~~~~~
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:72:13: note: Left side of '||' is false
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:72:9: note: Taking false branch
72 | if (cellSize < 2 || !Misc::isPowerOfTwo(cellSize - 1))
| ^
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:75:13: note: Assuming 'sampleSize' is not equal to 0
75 | if (sampleSize == 0 || !Misc::isPowerOfTwo(sampleSize))
| ^~~~~~~~~~~~~~~
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:75:13: note: Left side of '||' is false
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:75:9: note: Taking false branch
75 | if (sampleSize == 0 || !Misc::isPowerOfTwo(sampleSize))
| ^
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:78:13: note: Assuming 'distance' is >= 2
78 | if (distance < 2 || !Misc::isPowerOfTwo(distance - 1))
| ^~~~~~~~~~~~
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:78:13: note: Left side of '||' is false
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:78:9: note: Taking false branch
78 | if (distance < 2 || !Misc::isPowerOfTwo(distance - 1))
| ^
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:84:13: note: Assuming 'distance' is >= 'cellSize'
84 | if (distance < cellSize || sampleSize > cellSize - 1)
| ^~~~~~~~~~~~~~~~~~~
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:84:13: note: Left side of '||' is false
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:84:36: note: Assuming the condition is true
84 | if (distance < cellSize || sampleSize > cellSize - 1)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:84:9: note: Taking true branch
84 | if (distance < cellSize || sampleSize > cellSize - 1)
| ^
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:85:20: note: Calling 'sampleCellGridSimple<const (lambda at /home/elsid/dev/openmw/components/esmterrain/storage.cpp:280:35) &>'
85 | return sampleCellGridSimple(cellSize, sampleSize, beginX, beginY, endX, endY, f);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:56:16: note: 'cellSize' is > 1
56 | assert(cellSize > 1);
| ^
/usr/include/assert.h💯 27: note: expanded from macro 'assert'
100 | (static_cast <bool> (expr) \
| ^~~~
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:56:9: note: '?' condition is true
56 | assert(cellSize > 1);
| ^
/usr/include/assert.h💯 7: note: expanded from macro 'assert'
100 | (static_cast <bool> (expr) \
| ^
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:57:9: note: '?' condition is true
57 | assert(Misc::isPowerOfTwo(cellSize - 1));
| ^
/usr/include/assert.h💯 7: note: expanded from macro 'assert'
100 | (static_cast <bool> (expr) \
| ^
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:58:16: note: 'sampleSize' is not equal to 0
58 | assert(sampleSize != 0);
| ^
/usr/include/assert.h💯 27: note: expanded from macro 'assert'
100 | (static_cast <bool> (expr) \
| ^~~~
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:58:9: note: '?' condition is true
58 | assert(sampleSize != 0);
| ^
/usr/include/assert.h💯 7: note: expanded from macro 'assert'
100 | (static_cast <bool> (expr) \
| ^
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:60:9: note: Calling 'sampleGrid<(lambda at /home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:61:13)>'
60 | sampleGrid(sampleSize, beginX, beginY, endX, endY,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
61 | [&](std::size_t globalX, std::size_t globalY, std::size_t vertX, std::size_t vertY) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
62 | const auto [cellX, x] = toCellAndLocal(beginX, globalX, cellSize);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
63 | const auto [cellY, y] = toCellAndLocal(beginY, globalY, cellSize);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
64 | f(cellX, cellY, x, y, vertX, vertY);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
65 | });
| ~~
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:33:38: note: Assuming 'y' is < 'endY'
33 | for (std::size_t y = beginY; y < endY; y += sampleSize)
| ^~~~~~~~
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:33:9: note: Loop condition is true. Entering loop body
33 | for (std::size_t y = beginY; y < endY; y += sampleSize)
| ^
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:36:42: note: Assuming 'x' is < 'endX'
36 | for (std::size_t x = beginX; x < endX; x += sampleSize)
| ^~~~~~~~
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:36:13: note: Loop condition is true. Entering loop body
36 | for (std::size_t x = beginX; x < endX; x += sampleSize)
| ^
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:36:42: note: Assuming 'x' is < 'endX'
36 | for (std::size_t x = beginX; x < endX; x += sampleSize)
| ^~~~~~~~
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:36:13: note: Loop condition is true. Entering loop body
36 | for (std::size_t x = beginX; x < endX; x += sampleSize)
| ^
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:37:17: note: Calling 'operator()'
37 | f(x, y, vertX++, vertY);
| ^~~~~~~~~~~~~~~~~~~~~~~
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:62:41: note: Calling 'toCellAndLocal'
62 | const auto [cellX, x] = toCellAndLocal(beginX, globalX, cellSize);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/elsid/dev/openmw/components/esmterrain/gridsampling.hpp:18:35: note: The result of the '/' expression is undefined
18 | std::size_t cell = global / (cellSize - 1);
| ~~~~~~~^~~~~~~~~~~~~~~~
2025-07-27 12:11:24 +02:00
elsid
c5d74818eb
Disable portability-template-virtual-member-function clang tidy warning
...
There is no compatibility problem in practice.
/home/elsid/dev/openmw/components/settings/sanitizer.hpp:11:19: error: unspecified virtual member function instantiation; the virtual member function is not instantiated but it might be with a different compiler [portability-template-virtual-member-function,-warnings-as-errors]
11 | virtual T apply(const T& value) const = 0;
| ^
/home/elsid/dev/openmw/components/settings/sanitizerimpl.cpp:20:28: note: template instantiated here
20 | struct Max final : Sanitizer<T>
| ^
2025-07-27 11:30:07 +02:00