TheCloud/Digital
1
0
Fork 0
mirror of https://github.com/hneemann/Digital.git synced 2025-09-28 07:28:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

checkstyle issues make the build fail

Browse Source
This commit is contained in:
hneemann 2017-03-18 11:21:50 +01:00
parent e9dde8df34
commit e1e94ead52
3 changed files with 43 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
pom.xml
View File

@ -36,21 +36,6 @@
<artifactId>findbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<version>3.0.1</version> <version>3.0.1</version>
</plugin> </plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.17</version>
<configuration>
<configLocation>sun_checks_neemann.xml</configLocation>
</configuration>
<reportSets>
<reportSet>
<reports>
<report>checkstyle</report>
</reports>
</reportSet>
</reportSets>
</plugin>
<plugin> <plugin>
<artifactId>maven-pmd-plugin</artifactId> <artifactId>maven-pmd-plugin</artifactId>
<version>3.6</version> <version>3.6</version>
@ -76,6 +61,22 @@
<build> <build>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.17</version>
<dependencies>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<version>7.6</version>
</dependency>
</dependencies>
</plugin>
</plugins>
</pluginManagement>
<plugins> <plugins>
<plugin> <plugin>
<groupId>org.apache.maven.plugins</groupId> <groupId>org.apache.maven.plugins</groupId>
@ -152,6 +153,27 @@
</configuration> </configuration>
</plugin> </plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.17</version>
<executions>
<execution>
<id>validate</id>
<phase>validate</phase>
<configuration>
<configLocation>sun_checks_neemann.xml</configLocation>
<encoding>UTF-8</encoding>
<consoleOutput>true</consoleOutput>
<failsOnError>true</failsOnError>
</configuration>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin> <plugin>
<groupId>org.apache.maven.plugins</groupId> <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId> <artifactId>maven-assembly-plugin</artifactId>

3
src/main/java/de/neemann/digital/core/Signal.java
View File

@ -17,7 +17,8 @@ public final class Signal implements Comparable<Signal> {
* @param value the signals value * @param value the signals value
*/ */
public Signal(String name, ObservableValue value) { public Signal(String name, ObservableValue value) {
this.name = name.trim().replace(' ', '_'); if (name == null) this.name = null;
else this.name = name.trim().replace(' ', '_');
this.value = value; this.value = value;
} }

4
src/main/java/de/neemann/digital/draw/elements/Wire.java
View File

@ -15,6 +15,9 @@ import java.util.Collection;
*/ */
public class Wire implements Drawable, Moveable { public class Wire implements Drawable, Moveable {
private static final int MIN_LABEL_LEN = 80; private static final int MIN_LABEL_LEN = 80;
//Every value of p1 or p2 is valid. There are no hidden state constrains or dependencies.
//So both fields are allowed to by public to allow more readable code.
//CHECKSTYLE.OFF: VisibilityModifier
/** /**
* The first endpoint of the line * The first endpoint of the line
*/ */
@ -23,6 +26,7 @@ public class Wire implements Drawable, Moveable {
* The second endpoint of the line * The second endpoint of the line
*/ */
public Vector p2; public Vector p2;
//CHECKSTYLE.ON: VisibilityModifier
private transient ObservableValue value; private transient ObservableValue value;
private transient boolean p1Dot; private transient boolean p1Dot;
private transient boolean p2Dot; private transient boolean p2Dot;