63 Commits

Author SHA1 Message Date
Dilshod Mukhtarov
f1a698b50e
Forked subprocess not exited if execve failed (#54)
* Fixed: forked subprocess not exited if execve failed

In lengthy processes (daemons, etc) this bug keeps open this subprocess. The subprocess continues to work (parallel to parent process) from after failed command start

* Fixed: deadlock on using multithreaded application

For example if application uses spdlog logger library and set spdlog::flush_every(std::chrono::seconds(1)); then it starts it's own thread which flushes logs every 1 second. In this case if execve failed to execute given command, then parent and subprocess deadlocked.
2020-04-14 20:29:25 +05:30
Arun Muralidharan
a458bcfc4a
Update README.md 2020-04-09 17:34:16 +05:30
xoviat
9c624ce4e3 Enable basic windows support (#33)
* windows: fix implementation error
- repair configure_pipe
- allow vector initialization
- add draft destructor
- close pipes correctly

* windows: add some test compatibility

* windows: update readme

* windows: add vector args to check_output
v2.0
2020-01-18 20:01:03 +05:30
CrashOverride
126ee2978f Update subprocess.hpp (#51)
fixed type
2019-11-23 22:49:14 +05:30
Adam Kewley
a5cc965f72 Remove trailing semicolons on namespace decls: required to build with -pedantic compiler flag (#45) 2019-08-28 22:22:11 +05:30
bibermann
6931e3d69f Add option to disable building tests (#41) 2019-07-11 15:10:02 +05:30
bibermann
3ab04aecaa Add install target (#40) 2019-07-10 22:55:50 +05:30
bibermann
785ff230a8 Allow usage in multiple object files (#39) 2019-07-10 17:13:15 +05:30
xoviat
f6799fcc34 WIP: add windows compatibility (#32)
* windows: add util functions

* windows: add cmake files

* windows: add travis.yml

* windows: address compatibility
- set cxx standard
- conditionally exclude codecvt

* windows: improve test coverage

* windows: improve test coverage

* windows: consolidate tests

* windows: disable failing test

* windows: modify read_atmost_n to use file object

* windows: modify read_all to use file object

* windows: update read_all test to use new api

* windows: implement main subprocess logic

* windows: add macro names

* windows: setup comm channels

* windows: compatibility fixes
2019-05-09 22:02:58 +05:30
Arun Muralidharan
871577770a
Revert "WIP: Add windows compatibility (#30)" (#31)
This reverts commit 5d92f4849276aa313dc1ba56c1556f4cca27fc7f.
2019-05-02 12:24:40 +05:30
xoviat
5d92f48492 WIP: Add windows compatibility (#30)
* add package files

* add windows compat to subprocess.hpp

* add test modifications

* repair test_read_all
2019-05-02 12:02:17 +05:30
jvilk-stripe
de5f791d04 Add virtual destructor to HolderBase (#28) 2019-03-11 12:44:12 +05:30
Gerardwx
3e29149ad1 Change rethrow statements (#25) 2019-01-26 13:08:44 +05:30
Arun M
e6cb89cb6e readme minor missing content #22 2019-01-03 22:06:20 +05:30
mohamedAlaaK
d74481c564 fixed a bug in util::read_all() function and added a test for it (#23) 2019-01-03 21:59:49 +05:30
Arun M
7ebcd80c05 Merge conflict v1.0.4 2018-12-31 17:43:15 +05:30
Arun M
ced3d53e3a I can send() but I have no way of closing the input channel #21 2018-12-31 17:41:24 +05:30
ilue
0894e7f6db Fix for preexec_func (#19) 2018-12-22 00:37:51 +05:30
Ben Dang
899e9b997d Replace throw with noexcept for C17 compatibility (#17)
C++11 started to deprecate the use of throw function identifiers.  In
C++17, this header no longer compiles due to the deprecation.

Signed-off-by: Ben Dang <me@bdang.it>
v1.0.3
2018-10-08 12:45:10 +05:30
Arun M
a90174cf5c is throwing errors #16 v1.0.2 2018-09-30 10:10:40 +05:30
Arun M
05c76a5311 Reading from a pipe is messed up #14 v1.0.1 2018-04-16 10:50:46 +05:30
Arun M
b5e3da1cf7 Cannot access process retcode after #13 2018-04-14 22:51:06 +05:30
Dmitry Petrashko
4cc467e2aa Fix lto build on clang by marking HolderBase::operator() as abstract (#12) v1.0 2018-03-07 09:47:12 +05:30
okaymaged
7534a9cddb Don't waitpid on SIGCHLD, which lost the retcode (#11)
* Don't waitpid on SIGCHLD, which lost the retcode

* Adding test
2018-03-02 20:28:24 +05:30
Arun M
ca74a559c5 Fix all the compilation warnings #9 2018-03-01 16:10:05 +05:30
Arun Muralidharan
09ee99a282 Merge pull request #7 from mirror3000/master
Make library usable from multiple object files
2017-08-22 17:56:36 +05:30
Andrei Preda
83da3cc629 Make all static functions inline 2017-08-22 05:06:47 -07:00
Andrei Preda
55d9433422 Fix linker errors when using library in multiple object files 2017-08-22 04:14:51 -07:00
Andrei Preda
78651742fb Replace tabs with spaces
Coding style uses indent with spaces, but there were a few lost tabs
that had to be replaced.
2017-08-22 02:41:29 -07:00
Arun Muralidharan
b012256919 Merge pull request #6 from mirror3000/master
Fix warnings (compiling with clang++ -Wall)
2017-08-20 10:39:44 +05:30
Andrei Preda
c8577e3d83 Remove unused sys_ret variable 2017-08-19 16:39:09 +03:00
Andrei Preda
a665bff1bd Make split inline 2017-08-19 16:38:49 +03:00
Andrei Preda
fb63ff77d3 Use 'friend struct' instead of 'firend class ArgumentDeducer' in Popen
Signed-off-by: Andrei Preda <andreipreda07@gmail.com>
2017-08-19 16:28:42 +03:00
Arun Muralidharan
f650a47250 Merge pull request #5 from yytdfc/dev
Fix Issue #4 adding a SIGCHLD handler.
2017-08-04 10:44:04 +05:30
yytdfc
814be9e635 fix a bug of defunct process by adding a SIGCHLD handler. 2017-08-04 11:14:34 +08:00
arunmu
a23c1033df Fixed 2 issues:
1. When more than 2 streams are piped, we use threads to read/write data
parallely. In this scenariod read_atmost_n API was being used instead of
read_all.
2. Another issue with check_output argument validation fixed.
2016-03-21 20:25:37 +05:30
arunmu
a67cb2a439 Issue pointed by elfring: Non standard header guard 2016-03-21 18:07:05 +05:30
arunmu
faa6e3af2f Updated readme 2016-03-20 10:45:39 +05:30
arunmu
79932b1f42 Updated readme 2016-03-20 10:44:41 +05:30
arunmu
de49e349dc some test changes 2016-03-19 23:49:37 +05:30
arunmu
5e1a9c9088 Fixed poll return status 2016-03-19 18:18:47 +05:30
arunmu
9b2e9229a5 Added documentation 2016-03-19 17:40:39 +05:30
arunmu
9762f241ae quite a few changes and added functionalities and tests 2016-03-19 00:32:58 +05:30
arunmu
cccc08e7c5 Uncommented previously commented tests 2016-03-18 17:07:52 +05:30
arunmu
aab30d19bf Major issue resolved execv args was not terminated with nullptr 2016-03-18 17:06:44 +05:30
arunmu
f409d50c8d overload stream arguments for file pointer and new pipeline test case 2016-03-18 15:46:53 +05:30
arunmu
6a9f0aab51 added more tests 2016-03-17 21:19:36 +05:30
arunmu
fd9efecf05 New test case for cat and env 2016-03-17 15:23:11 +05:30
arunmu
943c6ee0de Corrected call API 2016-03-17 14:38:28 +05:30
arunmu
b5a3d3fb47 Add cat test case 2016-03-17 12:56:40 +05:30