Finalize classes

src/dwarfs/block_cache.cpp

@@ -199,7 +199,7 @@ class block_request_set {
 
 // multi-threaded block cache
 template <typename LoggerPolicy>
-class block_cache_ : public block_cache::impl {
+class block_cache_ final : public block_cache::impl {
  public:
   block_cache_(logger& lgr, std::shared_ptr<mmif> mm,
                block_cache_options const& options)

src/dwarfs/block_manager.cpp

@@ -179,7 +179,7 @@ class active_block {
 };
 
 template <typename LoggerPolicy>
-class block_manager_ : public block_manager::impl {
+class block_manager_ final : public block_manager::impl {
  public:
   block_manager_(logger& lgr, progress& prog, const block_manager::config& cfg,
                  std::shared_ptr<os_access> os, filesystem_writer& fsw)

src/dwarfs/filesystem_extractor.cpp

@@ -68,7 +68,7 @@ class cache_semaphore {
 } // namespace
 
 template <typename LoggerPolicy>
-class filesystem_extractor_ : public filesystem_extractor::impl {
+class filesystem_extractor_ final : public filesystem_extractor::impl {
  public:
   filesystem_extractor_(logger& lgr)
       : log_{lgr} {}

src/dwarfs/filesystem_v2.cpp

@@ -173,7 +173,7 @@ make_metadata(logger& lgr, std::shared_ptr<mmif> mm,
 }
 
 template <typename LoggerPolicy>
-class filesystem_ : public filesystem_v2::impl {
+class filesystem_ final : public filesystem_v2::impl {
  public:
   filesystem_(logger& lgr_, std::shared_ptr<mmif> mm,
               const filesystem_options& options,

src/dwarfs/filesystem_writer.cpp

@@ -203,7 +203,7 @@ fsblock::fsblock(section_type type, compression_type compression,
     : impl_(std::make_unique<compressed_fsblock>(type, compression, data)) {}
 
 template <typename LoggerPolicy>
-class filesystem_writer_ : public filesystem_writer::impl {
+class filesystem_writer_ final : public filesystem_writer::impl {
  public:
   filesystem_writer_(logger& lgr, std::ostream& os, worker_group& wg,
                      progress& prog, const block_compressor& bc,

src/dwarfs/inode_manager.cpp

@@ -172,7 +172,7 @@ class nilsimsa_cache_entry {
 } // namespace
 
 template <typename LoggerPolicy>
-class inode_manager_ : public inode_manager::impl {
+class inode_manager_ final : public inode_manager::impl {
  public:
   inode_manager_(logger& lgr, progress& prog)
       : LOG_PROXY_INIT(lgr)

src/dwarfs/inode_reader_v2.cpp

@@ -42,7 +42,7 @@ namespace dwarfs {
 namespace {
 
 template <typename LoggerPolicy>
-class inode_reader_ : public inode_reader_v2::impl {
+class inode_reader_ final : public inode_reader_v2::impl {
  public:
   inode_reader_(logger& lgr, block_cache&& bc)
       : cache_(std::move(bc))

src/dwarfs/metadata_v2.cpp

@@ -104,7 +104,7 @@ const uint16_t READ_ONLY_MASK = ~(S_IWUSR | S_IWGRP | S_IWOTH);
 } // namespace
 
 template <typename LoggerPolicy>
-class metadata_ : public metadata_v2::impl {
+class metadata_ final : public metadata_v2::impl {
  public:
   // TODO: defaults?, remove
   metadata_(logger& lgr, folly::ByteRange schema, folly::ByteRange data,

src/dwarfs/scanner.cpp

@@ -294,7 +294,7 @@ std::string status_string(progress const& p, size_t width) {
 } // namespace
 
 template <typename LoggerPolicy>
-class scanner_ : public scanner::impl {
+class scanner_ final : public scanner::impl {
  public:
   scanner_(logger& lgr, worker_group& wg, const block_manager::config& config,
            std::shared_ptr<entry_factory> ef, std::shared_ptr<os_access> os,