TheCloud/dwarfs
1
0
Fork 0
mirror of https://github.com/mhx/dwarfs.git synced 2025-09-11 13:30:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore(inode_reader): add TODO and move namespace scope

Browse Source
This commit is contained in:
Marcus Holland-Moritz 2024-07-29 13:00:07 +02:00
parent 4ff99eddfb
commit 72a69dd1e4
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/dwarfs/internal/inode_reader_v2.cpp
View File

@ -90,6 +90,8 @@ constexpr size_t const offset_cache_updater_max_inline_offsets = 4;
constexpr size_t const offset_cache_size = 64; constexpr size_t const offset_cache_size = 64;
constexpr size_t const readahead_cache_size = 64; constexpr size_t const readahead_cache_size = 64;
} // namespace
template <typename LoggerPolicy> template <typename LoggerPolicy>
class inode_reader_ final : public inode_reader_v2::impl { class inode_reader_ final : public inode_reader_v2::impl {
public: public:
@ -295,6 +297,7 @@ inode_reader_<LoggerPolicy>::read_internal(uint32_t inode, size_t const size,
size_t const copyoff = it->offset() + offset; size_t const copyoff = it->offset() + offset;
size_t copysize = chunksize - offset; size_t copysize = chunksize - offset;
// TODO: should this rather be an assertion?
if (copysize == 0) { if (copysize == 0) {
LOG_ERROR << "invalid zero-sized chunk"; LOG_ERROR << "invalid zero-sized chunk";
ec = std::make_error_code(std::errc::invalid_argument); ec = std::make_error_code(std::errc::invalid_argument);
@ -413,8 +416,6 @@ size_t inode_reader_<LoggerPolicy>::readv(iovec_read_buf& buf, uint32_t inode,
return rv; return rv;
} }
} // namespace
inode_reader_v2::inode_reader_v2( inode_reader_v2::inode_reader_v2(
logger& lgr, block_cache&& bc, inode_reader_options const& opts, logger& lgr, block_cache&& bc, inode_reader_options const& opts,
std::shared_ptr<performance_monitor const> perfmon) std::shared_ptr<performance_monitor const> perfmon)